brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.87k stars 2.34k forks source link

Downloads aren’t saving, files disappear after download #41073

Closed Saoiray closed 1 month ago

Saoiray commented 1 month ago

Description

When downloading anything and trying to save to Files, it never appears. This issue appears to only exist with Brave and does not happen in Chrome or Safari.

Steps to reproduce

  1. Navigate to a site with a downloadable file
  2. Download the file
  3. Go to Downloads in Brave or navigate to Files on iOS

Actual result

The downloaded file doesn't exist. Downloads is empty

Expected result

File should be downloaded and available for use.

Reproduces how often

Easily reproduced

Brave version

1.69.1

Device/iOS version

iOS 17.6.1 iOS 17.4.1

Affected browser versions

Reproducibility

Miscellaneous information

Issue reported by users at https://community.brave.com/t/downloaded-videos-on-ios/568738/

Then was able to replicate myself as well.

SIDE NOTE I could swear we used to have the ability to choose download destinations within Brave on iOS but I don't see that anywhere now. Did this change or am I thinking more of Android?

GROSU1 commented 1 month ago

Happened after latest release on Friday 13th, previously worked without issues. Version build 171 of 1.69.1. Just tested on 18.0 today with the same issue. Was thinking some change might have been for the new major iOS release but it doesn't seem like it.

bompao108 commented 1 month ago

Got the same problem. Can't even download anything although the download section is finished tho

roafhtun commented 1 month ago

same problem here, goes to look into Files app on iOS nothing is downloaded there.

Brave-Matt commented 1 month ago

Another +1 from Community: https://community.brave.com/t/downloads-nowhere-to-be-found/569337

Brave-Matt commented 1 month ago

More +1s: https://community.brave.com/t/after-latest-update-downloading-is-not-working/568956

lukemulks commented 1 month ago

+1 from user via DM on X Screenshot_20240917_183634_X

teanea commented 1 month ago

me too

KMatuszak commented 1 month ago

Same issue on iPadOS 18.0

bompao108 commented 1 month ago

issue

This download issue is terrible cuz I can't download anything via Brave I need to have another browser in my iPhone

bompao108 commented 1 month ago

@kylehickinson no bro it ain't fix nothing yet I just downloaded Brave back Tested Youtube, Tiktok, ... Still aint got any videos after the download finishes

bompao108 commented 1 month ago

@kylehickinson proof : IMG_0465 IMG_0466 IMG_0467

kylehickinson commented 1 month ago

@bompao108 this fix hasn't shipped to any public builds yet. Keep an eye out for 1.69.2 in the next few days

bompao108 commented 1 month ago

@bompao108 this fix hasn't shipped to any public builds yet. Keep an eye out for 1.69.2 in the next few days

Thanks. I need it

kjozwiak commented 1 month ago

The above requires 1.69.172 or higher for 1.69.x verification. We'll be starting RC builds shorty and hoping to get them approved by Apple sometime today/tomorrow. Once approved, we'll start pushing the fix out via 1.69.172. Unless we find other issues related to Downloads & Passbook while verifying the RC builds.

kjozwiak commented 1 month ago

Verification PASSED on iPhone 11 running iOS 18 using the following build(s):

Brave | 1.69.172 Chromium: 128.0.6613.138 (Official Build) stable (64-bit) 
--- | ---
Revision | 6da7ca9e1ca7...
OS | iOS

Using similar STR/Cases outlined via https://github.com/brave/brave-core/pull/25651#issuecomment-2364318981, went through the following:

Passbook verification(s):

Example Example Example Example Example
IMG_0564 IMG_0565 IMG_0567 IMG_0566 IMG_0568
Example Example Example Example
IMG_0569 IMG_0571 IMG_0570 IMG_0572

PDF download verification(s):

Example Example Example Example
IMG_0580 IMG_0581 IMG_0582 IMG_0583

Image download verification(s):

Example Example Example Example
IMG_0575 IMG_0576 IMG_0577 IMG_0578

Instagram download verification (case provided by Community):

Example Example Example Example Example Example
IMG_0584 IMG_0586 IMG_0588 IMG_0589 IMG_0590 IMG_0591
Uni-verse commented 1 month ago

Verified on iPad (7th Gen) running iPadOS 17.5.1 using version 1.69.2 (172)

Case: snapinsta.app - PASSED

- Went through the test steps below and ensured that file is downloaded successfully and shown in `Downloads` folder. - Copy an instagram link (e.g. https://www.instagram.com/reel/DABSg8nJb4D/) - Visit snapinsta.app and submit the link to be downloaded - Click "Download" when it appears example | example | example ---|---|--- ![IMG_1625](https://github.com/user-attachments/assets/f75f7d18-8566-4f6c-90a6-6251bfecc8a5) | ![IMG_1626](https://github.com/user-attachments/assets/a8adfdb5-e682-4e4f-bfc1-7904b0dd2418) | ![IMG_1627](https://github.com/user-attachments/assets/ab4433f5-68f0-481e-ab2d-43c008418964)

Case: PDF download - PASSED

- Ensured that downloading PDF files is working using `Save to Files` in share menu example | example | example ---|---|--- ![IMG_1628](https://github.com/user-attachments/assets/5407cc14-b9ae-4029-91e2-640ffe4fc9da) | ![IMG_1629](https://github.com/user-attachments/assets/9baeb648-5437-4b6c-8053-35194764c4b5) | ![IMG_1630](https://github.com/user-attachments/assets/85dd7bdc-4b0d-49bd-95c5-916de9a51838)

Case: Saving Image to Photos - PASSED

example | example | example ---|---|--- ![IMG_1634](https://github.com/user-attachments/assets/ea6117a4-d1c7-4e29-aca8-59817067bc88) | ![IMG_1635](https://github.com/user-attachments/assets/d294f8c8-707f-439c-8ae8-6db1f0cc2b97) | ![IMG_1637](https://github.com/user-attachments/assets/2301ed42-65de-48e7-81e0-4fd7ac820c68)

Case: Add to Wallet - DEFERRED

example | example ---|--- ![IMG_1638](https://github.com/user-attachments/assets/6db54e8c-7d18-4fb9-bb13-d9155b11b4a1) | ![IMG_1639](https://github.com/user-attachments/assets/f282c9fe-f2fb-4143-a691-4826981f84e5) *Note: iPad (7th Gen) does not support Passbook.

Case: Direct Download (unsplash) - PASSED

example | example | example ---|---|--- ![IMG_1631](https://github.com/user-attachments/assets/1b844bfb-cce3-4819-adb0-400d08f04c23) | ![IMG_1632](https://github.com/user-attachments/assets/1b4e33f2-7a37-4922-b689-a7f897d8acb8) | ![IMG_1633](https://github.com/user-attachments/assets/44ba6099-ff50-417b-ac1a-16b8dc8f8627)