Open StephenHeaps opened 2 days ago
When a site is shredded, all first party data is removed but caches stored under different domains are not removed
brave://flags
...
Remove All
https://google.ca
Done
Shred Site Data
google.ca
google.com
gstatic.com
https://github.com/user-attachments/assets/56d6a19b-6497-4668-a324-203a2d44f24c
--
Easily reproduced
v1.69+ (note: Shred feature flag is disabled by default)
Any
The Brave iOS Manage Website Data view displays it's data using the WKWebsiteDataStore.fetchDataRecords(ofTypes:completionHandler:) API. This API does not allow retrieving which site stored the given data, so we are only able to remove the data whose displayName we can match to the site being Shred.
Manage Website Data
displayName
@ShivanKaul added it into the 1.70.x milestone as release/blocking for now. If you feel differently or we eventually think it's not, we can remove the label/remove it from the milestone.
1.70.x
release/blocking
Description
When a site is shredded, all first party data is removed but caches stored under different domains are not removed
Steps to reproduce
brave://flags
, then quit and relaunch the app....
, then open Settings -> Shields settings -> Manage Website Data viewRemove All
to remove all data storedhttps://google.ca
...
, then open Settings -> Shields settings -> Manage Website Data viewDone
to close Manage Website Data, and close settingsShred Site Data
...
, then open Settings -> Shields settings -> Manage Website Data viewgoogle.ca
website data is removed, butgoogle.com
&gstatic.com
data is still thereActual result
https://github.com/user-attachments/assets/56d6a19b-6497-4668-a324-203a2d44f24c
Expected result
--
Reproduces how often
Easily reproduced
Brave version
v1.69+ (note: Shred feature flag is disabled by default)
Device/iOS version
Any
Affected browser versions
Reproducibility
Miscellaneous information
The Brave iOS
Manage Website Data
view displays it's data using the WKWebsiteDataStore.fetchDataRecords(ofTypes:completionHandler:) API. This API does not allow retrieving which site stored the given data, so we are only able to remove the data whosedisplayName
we can match to the site being Shred.