search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.57k stars 2.28k forks source link

Removed unused options from https://brave-browser-rpm-release.s3.brave.com/brave-browser.repo for fedora #41182

Open grumpey opened 3 hours ago

grumpey commented 3 hours ago

Description

[brave-browser]
name=Brave Browser
enabled=1
autorefresh=1
baseurl=https://brave-browser-rpm-release.s3.brave.com/$basearch

autorefresh is no longer an option for dnf4 or dnf5.

dnf4 still allows the repository to be installed. dnf5 (f41) does not allow the repository to be installed. 

sudo dnf config-manager addrepo --from-repofile=https://brave-browser-rpm-release.s3.brave.com/brave-browser.repo
 https://brave-browser-rpm-release.s3.brave.com/brave-browser.repo                                                                                                                                    100% | 688.0   B/s | 124.0   B |  00m00s
Error in added repository configuration file. Cannot set repository option "autorefresh=1": Option "autorefresh" not found

Steps to reproduce

  1. On a fedora 41 beta installation attempt to install the brave browser repository with sudo dnf config-manager addrepo --from-repofile=https://brave-browser-rpm-release.s3.brave.com/brave-browser.repo
  2. Observe error regarding autofresh sudo dnf repolist
  3. Observer brave repository is not listed.

Actual result

Brave repo is not added.

Expected result

Brave repo is added.

Reproduces how often

Easily reproduced

Brave version (brave://version info)

n/a repository file

Channel information

Reproducibility

Miscellaneous information

dnf5 configuration reference: https://dnf5.readthedocs.io/en/latest/dnf5.conf.5.html#dnf5-conf-label dnf4 configuration reference: https://dnf.readthedocs.io/en/latest/conf_ref.html

Since this is also used for Suse, where that option appears to be valid maybe you could try setting the metadata_expire value to something appropriate for both. The reference indicates it defaults to 48 hours or you could do separate repo files.

Thanks

grumpey commented 2 hours ago

For dnf5 (F41) You could also skip the repo file and just do: sudo dnf config-manager addrepo --id=brave-browser --set=name='Brave Browser' --set=baseurl='https://brave-browser-rpm-release.s3.brave.com/$basearch'