brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.9k stars 2.34k forks source link

Vertical tabs: Could not drag second tab into the tab group #41278

Open MadhaviSeelam opened 1 month ago

MadhaviSeelam commented 1 month ago

Description

After adding a tab to a new group via context menu option Add tab to new group, tried dragging second tab to the same group. The tab didn't move into the group so added the second tab manually to the group via context menu. Was able to drag third tab successfully to the group.

Steps to reproduce

  1. Install 1.71.98
  2. launch Brave
  3. open few tabs
  4. add first tab to a group via tab context menu option Add tab to new group
  5. name the group
  6. drag second to tab group

Actual result

Couldn't drag second tab into the tab group

https://github.com/user-attachments/assets/5245c08c-09be-4c75-81b1-06a28996b2de

Expected result

Should be able to drag into the group

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave 1.71.98 Chromium: 129.0.6668.70 (Official Build) beta (64-bit)
Revision 453ddf665beda526b19af7aa60047a0e757b6a7a
OS Windows 11 Version 23H2 (Build 22631.4169)

Channel information

Reproducibility

Miscellaneous information

@rebron cc: @brave/qa-team

LaurenWags commented 1 month ago

@MadhaviSeelam does this reproduce on 1.70.x?

MadhaviSeelam commented 1 month ago

Yes, it's reproducible in 1.70.119.

kjozwiak commented 1 month ago

++ as I run into this all the time when creating various groups. I always have to add the second tab via the context menu before I can start dragging/dropping other tabs into the group. Seems like you need two or more tabs in a group to be able to drag/drop.

Currently still an issue on Win x64 with the following build(s):

Brave | 1.73.5 Chromium: 130.0.6723.31 (Official Build) nightly (64-bit)
-- | --
Revision | 2fa08a74a31815d19960daea47ab1eaa9f28dc87
OS | Windows 11 Version 23H2 (Build 22631.4317)