Closed zenparsing closed 1 month ago
Verification INPROGRESS on
Brave | 1.72.85 Chromium: 130.0.6723.58 (Official Build) beta (64-bit)
-- | --
Revision | 2c872aa4d2694bc73ec58e3b14538a4008a6381e
OS | Windows 10 Version 22H2 (Build 19045.5011)
Added QA blocked label. I am unable to test this issue as I am getting the crash when click on the BAT icon/BR panel. The crash issue PR https://github.com/brave/brave-core/pull/26118#issuecomment-2429083629 needs to be uplifted to beta 1.72.x to continue testing on this issue.
cc: @Miyayes @zenparsing @LaurenWags
Verification PASSED on
Brave | 1.72.86 Chromium: 130.0.6723.70 (Official Build) beta (64-bit)
-- | --
Revision | f0bc5ea984bb6d35613d0c0b22c26fbb09b60198
OS | Windows 10 Version 22H2 (Build 19045.5011)
@zenparsing: When I connect to Gemini custodian and open a uphold publisher on 1.72.x without #brave-rewards-new-rewards-ui
flag enabled, I am getting Can't send your contribution, This creator is unable to receive contributions from Gemini.
message on the tipping banner, but with #brave-rewards-new-rewards-ui
flag enabled I am seeing the following message on the contribution banner looks like this is the custodian mismatch message on 1.72.x rewards 3.0 with flag enabled. Can you review the same and let me know whether this is expected custodian mismatch message on rewards 3.0 with new rewards ui flag enable?. Thanks!
@zenparsing: When user is connected to Gemini and open alexvincentmusic.com (creator is verified with both bitFlyer and Web3), click on Contribute
button directly redirects to creators staging env, the message This creator currently only accepts contributions via the following method
. The web 3
option is NOT shown contribution panel after clicking on Contribute
button. Also, the old contribution amount UI is shown. The contribution amount new UI is not applicable for web 3 creators contribution banner?
Same issue with case below:
Gemini
and Web 3
e.g github.com/miyayes, click on the Contribute
button redirects to the creators staging evn with old contribution amount options. Ideally, click on contribute button should open panel with the message This creator currently only accepts contributions via the following methods:
Gemini
and Web 3
options but it's redirecting to creators staging env (looks like a bug)cc: @Miyayes @LaurenWags
Example | Example | new contribution amount UI |
---|---|---|
@Miyayes @zenparsing: One time tip and recurring tips are not processing for Gemini publisher. I have connected to Gemini custodian and setup recurring tip and sent a one time tip to a verified Gemini publisher and waited for enough time (3 to 4 hours) but still one-time tip did not go through. I have set sys date ahead and waited for recurring tip process as well but no luck.
@zenparsing: let me know if you would like to have a look at the logs.
cc: @LaurenWags
@GeetaSarvadnya The screenshots look like the expected behavior according to the designs. @Miyayes do you agree?
I'm current testing Gemini staging transactions, and will post results on Slack.
@zenparsing: I am verifying tipping via Solana custodian I need clarification on the questions for the following steps 5, 8 and 9.
Please let me know if steps are not clear.
Connect Solana custodian
case via https://github.com/brave/brave-browser/issues/41295#issuecomment-2431783785Contribute
buttonContribute
button should display contribution panel with Web 3
custodian option or it should redirect to publisher staging banner directly?
Q2. Publisher staging banner doesn't have the contribution amount new UI. Is this expected?
Q3. To tip a web 3 publisher github.com/miyayes what network we supposed to select from the dropdown? I have funded Solana Mainnet
from 1Passwod and connected the same wallet to the rewards which has the actual BAT hence I have not done tipping so far.
Q4. SPL-BAT(Wormhole)
network has 29+BAT can QA use this for tipping?Step 2 | Step 4 | Step 5 |
---|---|---|
Contribute
button I see the custodian mismatch message as expected below:Example | Example |
---|---|
Contribute
button I see the custodian mismatch message as expected below:Example | Example |
---|---|
Contribute
button opens up the publisher staging contribution banner.
Q. Is this expected?Example | Example |
---|---|
Contribute
button opens up the publisher staging contribution banner.
Q. Is this expected?Example | Example |
---|---|
cc: @Miyayes @LaurenWags
@GeetaSarvadnya Everything looks expected to me.
Thanks for the clarifications @zenparsing!
@Miyayes: Can you provide clarifications on the above https://github.com/brave/brave-browser/issues/41295#issuecomment-2465024267? (Points 5.3 and 5.4). Thanks!
cc: @LaurenWags
@GeetaSarvadnya afaik Dapp is separate from browser process so I wouldn't worry about it (it has generally been outside the scope of our testing), but we can see what @Miyayes says 👍🏻
For testing Web3 contributions, as long as you can load the correct contribution webpage (dApp) for the creator, that is enough. For this, we do not need to test actually making an on-chain Web3 contribution. @GeetaSarvadnya @LaurenWags
Thanks @Miyayes !
Description
Add the contribution flow to the new Rewards panel based on Figma designs.