brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.97k stars 2.35k forks source link

[Rewards 3.0] Add contribution flow to Rewards panel #41295

Closed zenparsing closed 1 month ago

zenparsing commented 1 month ago

Description

Add the contribution flow to the new Rewards panel based on Figma designs.

GeetaSarvadnya commented 1 month ago

Verification INPROGRESS on

Brave | 1.72.85 Chromium: 130.0.6723.58 (Official Build) beta (64-bit)
-- | --
Revision | 2c872aa4d2694bc73ec58e3b14538a4008a6381e
OS | Windows 10 Version 22H2 (Build 19045.5011)
GeetaSarvadnya commented 1 month ago

Added QA blocked label. I am unable to test this issue as I am getting the crash when click on the BAT icon/BR panel. The crash issue PR https://github.com/brave/brave-core/pull/26118#issuecomment-2429083629 needs to be uplifted to beta 1.72.x to continue testing on this issue.

cc: @Miyayes @zenparsing @LaurenWags

GeetaSarvadnya commented 1 month ago

Verification PASSED on

Brave | 1.72.86 Chromium: 130.0.6723.70 (Official Build) beta (64-bit)
-- | --
Revision | f0bc5ea984bb6d35613d0c0b22c26fbb09b60198
OS | Windows 10 Version 22H2 (Build 19045.5011)
Uphold_connected state_One_Time_Tip_PASSED 1. Clean profile 1.72.x and enable #brave-rewards-new-rewards-ui via brave://flags 2. Enable rewards and connect to a uphold custodian 3. Open a uphold verified publisher e.g laurenwags.github.io 4. Open contribution banner and click on `Contribute` button 5. Confirmed that the contribution selection popup is displayed with list of contribution amounts 6. Select default contribution amount or custom contribution amount 7. Click on send tip button 8. Confirmed that tip sent message is shown 9. Confirmed that wallet balance is reduced after sending one time tip 10. Confirmed that tip is sent transactions are listed under uphold 11. Confirmed that tip sent logs (5% fees and 95% fees deduction logs) are shown on the console 12. Confirmed that tip sent are shown under brave://rewards-internals page Example | Example | Example | Example | Example ----------|-----------|-----------|----------|---------- ![Image](https://github.com/user-attachments/assets/b8a682bd-126a-454c-a017-ccb0639f1712) | ![Image](https://github.com/user-attachments/assets/d7ac3b94-2846-460a-8d03-716e9b17c25e) | ![Image](https://github.com/user-attachments/assets/4456ff58-6389-4d16-9c21-129eb7ac2727) | ![Image](https://github.com/user-attachments/assets/477ed6b0-a319-4e87-8c8f-d21824f88cc9) | ![Image](https://github.com/user-attachments/assets/991edd7b-4523-43c2-a071-25efd88d991e) **Logs:** 5% transactions fees logs ``` [ REQUEST ] > URL: https://api-sandbox.uphold.com/v0/me/transactions/9ff12ddc-b6d9-463c-812f-b72dd844d0fc > Method: GET [25536:6212:1030/211941.167:VERBOSE1:url_loader.cc(111)] [ RESPONSE ] > URL: https://api-sandbox.uphold.com/v0/me/transactions/9ff12ddc-b6d9-463c-812f-b72dd844d0fc > Result: Success > HTTP Code: 200 > Body: {"application":{"clientId":"4c2b665ca060d912fec5c735c734859a06118cc8","name":"Brave Browser"},"createdAt":"2024-10-30T15:49:07.655Z","denomination":{"amount":"0.05","currency":"BAT","pair":"BATBAT","rate":"1.00","target":"origin"},"destination":{"amount":"0.05","base":"0.05","commission":"0.00","currency":"BAT","description":"Brave Browser","fee":"0.00","node":{"type":"anonymous"},"rate":"1.00","type":"anonymous"},"fees":[],"id":"9ff12ddc-b6d9-463c-812f-b72dd844d0fc","message":"5% transaction fee collected by Brave Software International","network":"uphold","normalized":[{"amount":"0.01","commission":"0.00","currency":"USD","fee":"0.00","rate":"0.17038780820000000000","target":"origin"}],"order":null,"origin":{"CardId":"a93f3116-6bfb-46ae-aafe-a644ffa78437","amount":"0.05","base":"0.05","commission":"0.00","currency":"BAT","description":"geeta sarvadnya","fee":"0.00","isMember":true,"node":{"id":"a93f3116-6bfb-46ae-aafe-a644ffa78437","type":"card","user":{"id":"d830ec11-4f12-4d23-b7c8-fee31f9a249e"}},"rate":"1.00","sources":[{"amount":"0.05","id":"796842de-c4b3-4b05-9e37-91330cdf0ed4"}],"type":"card"},"params":{"currency":"BAT","pair":"BATBAT","progress":"1","rate":"1.00","ttl":3599996,"type":"internal"},"priority":"normal","reference":null,"status":"completed","type":"transfer"} ``` 95% transactions fees logs: ``` [ REQUEST ] > URL: https://api-sandbox.uphold.com/v0/me/transactions/9ff12ddc-b6d9-463c-812f-b72dd844d0fc > Method: GET [25536:6212:1030/211941.167:VERBOSE1:url_loader.cc(111)] [ RESPONSE ] > URL: https://api-sandbox.uphold.com/v0/me/transactions/9ff12ddc-b6d9-463c-812f-b72dd844d0fc > Result: Success > HTTP Code: 200 > Body: {"application":{"clientId":"4c2b665ca060d912fec5c735c734859a06118cc8","name":"Brave Browser"},"createdAt":"2024-10-30T15:49:07.655Z","denomination":{"amount":"0.05","currency":"BAT","pair":"BATBAT","rate":"1.00","target":"origin"},"destination":{"amount":"0.05","base":"0.05","commission":"0.00","currency":"BAT","description":"Brave Browser","fee":"0.00","node":{"type":"anonymous"},"rate":"1.00","type":"anonymous"},"fees":[],"id":"9ff12ddc-b6d9-463c-812f-b72dd844d0fc","message":"5% transaction fee collected by Brave Software International","network":"uphold","normalized":[{"amount":"0.01","commission":"0.00","currency":"USD","fee":"0.00","rate":"0.17038780820000000000","target":"origin"}],"order":null,"origin":{"CardId":"a93f3116-6bfb-46ae-aafe-a644ffa78437","amount":"0.05","base":"0.05","commission":"0.00","currency":"BAT","description":"geeta sarvadnya","fee":"0.00","isMember":true,"node":{"id":"a93f3116-6bfb-46ae-aafe-a644ffa78437","type":"card","user":{"id":"d830ec11-4f12-4d23-b7c8-fee31f9a249e"}},"rate":"1.00","sources":[{"amount":"0.05","id":"796842de-c4b3-4b05-9e37-91330cdf0ed4"}],"type":"card"},"params":{"currency":"BAT","pair":"BATBAT","progress":"1","rate":"1.00","ttl":3599996,"type":"internal"},"priority":"normal","reference":null,"status":"completed","type":"transfer"} ```
Uphold connected state_Recurring_Tip_PASSED 1. Clean profile 1.72.x and enable #brave-rewards-new-rewards-ui via brave://flags 2. Enable rewards and connect to a uphold custodian 3. Open a uphold verified publisher e.g laurenwags.github.io 4. Open contribution banner and click on `Contribute` button 5. Confirmed that the contribution selection popup is displayed with list of contribution amounts 6. Select default contribution amount or enter custom contribution amount 7. Click recurring tip checkbox and click on send tip button 8. Confirmed that tip sent message is shown 9. Confirmed that one-time tip is sent and recurring tip is set 10. Confirmed that wallet balance is reduced after sending one time tip 11. Confirmed that tip is sent transactions are listed under uphold for one time tip 12. Confirmed that tip sent logs (5% fees and 95% fees deduction logs) are shown on the console for one time tip 13. Confirmed that tip sent are shown under brave://rewards-internals page 14. Confirmed that recurring tip set is displayed under `Recurring Contributions` panel on brave://rewards page 15. Confirmed that `Next contribution` date is displayed in the `Recurring Contributions` panel 16. Close the browser and forward the sys date to the date displayed in the recurring contribution panel 17. Confirmed that recurring tip is processed and wallet balance is reduced 18. Confirmed that recurring tip processed shown on the brave://rewards-internals page 19. Confirmed that tip is sent transactions are listed under uphold for recurring tip Example | Example | Example | Example ----------|-----------|-----------|---------- ![Image](https://github.com/user-attachments/assets/5cc32ba3-a7b1-4c19-b1d5-c951c58d12a0) | ![Image](https://github.com/user-attachments/assets/bcd83c9c-0833-49f4-a766-a18f107ea626) | ![Image](https://github.com/user-attachments/assets/afb6390e-e64e-4c4e-a532-83dba9fc20fc) | ![Image](https://github.com/user-attachments/assets/90ebe082-0cfe-4d68-8c0a-8f81a91441bb) One time tip processed logs: ``` [25732:6788:1104/150835.539:VERBOSE1:contribution.cc(524)] Creating contribution for wallet type uphold (amount: 1, type: ONE_TIME_TIP) [25732:6788:1104/150835.564:VERBOSE1:contribution.cc(137)] Queue timer set for 29 s [25732:6788:1104/150835.566:VERBOSE1:url_loader.cc(72)] [ REQUESt ] > URL: https://api-sandbox.uphold.com/v0/me/transactions/30e86689-30ff-45b8-b293-c322fe2de2e1 > Method: GET [25732:6788:1104/150848.624:VERBOSE1:url_loader.cc(111)] [ RESPONSE ] > URL: https://api-sandbox.uphold.com/v0/me/transactions/30e86689-30ff-45b8-b293-c322fe2de2e1 > Result: Success > HTTP Code: 200 > Body: {"application":{"clientId":"4c2b665ca060d912fec5c735c734859a06118cc8","name":"Brave Browser"},"createdAt":"2024-11-04T09:38:37.352Z","denomination":{"amount":"0.95","currency":"BAT","pair":"BATBAT","rate":"1.00","target":"origin"},"destination":{"amount":"0.95","base":"0.95","commission":"0.00","currency":"BAT","description":"Uphold Member","fee":"0.00","node":{"type":"anonymous"},"rate":"1.00","type":"anonymous"},"fees":[],"id":"30e86689-30ff-45b8-b293-c322fe2de2e1","message":null,"network":"uphold","normalized":[{"amount":"0.14","commission":"0.00","currency":"USD","fee":"0.00","rate":"0.14925340640000000000","target":"origin"}],"order":null,"origin":{"CardId":"a93f3116-6bfb-46ae-aafe-a644ffa78437","amount":"0.95","base":"0.95","commission":"0.00","currency":"BAT","description":"geeta sarvadnya","fee":"0.00","isMember":true,"node">Body:{"id":"a93f3116-6bfb-46ae-aafe-a644ffa78437","type":"card","user":{"id":"d830ec11-4f12-4d23-b7c8-fee31f9a249e"}},"rate":"1.00","sources":[{"amount":"0.95","id":"796842de-c4b3-4b05-9e37-91330cdf0ed4"}],"type":"card"},"params":{"currency":"BAT","pair":"BATBAT","progress":"1","rate":"1.00","ttl":3599996,"type":"internal"},"priority":"normal","reference":null,"status":"completed","type":"transfer"} [25732:6788:1104/150848.626:VERBOSE1:wallet_provider.cc(157)] uphold transfer fee timer is being set for 10 s ------- [ REQUEST ] > URL: https://api-sandbox.uphold.com/v0/me/transactions/74b328df-bbb8-4fa0-be22-2c986a984ae2 > Method: GET [25732:6788:1104/150918.816:VERBOSE1:url_loader.cc(111)] [ RESPONSE ] > URL: https://api-sandbox.uphold.com/v0/me/transactions/74b328df-bbb8-4fa0-be22-2c986a984ae2 > Result: Success > HTTP Code: 200 > Body: {"application":{"clientId":"4c2b665ca060d912fec5c735c734859a06118cc8","name":"Brave Browser"},"createdAt":"2024-11-04T09:39:00.011Z","denomination":{"amount":"0.05","currency":"BAT","pair":"BATBAT","rate":"1.00","target":"origin"},"destination":{"amount":"0.05","base":"0.05","commission":"0.00","currency":"BAT","description":"Brave Browser","fee":"0.00","node":{"type":"anonymous"},"rate":"1.00","type":"anonymous"},"fees":[],"id":"74b328df-bbb8-4fa0-be22-2c986a984ae2","message":"5% transaction fee collected by Brave Software International","network":"uphold","normalized":[{"amount":"0.01","commission":"0.00","currency":"USD","fee":"0.00","rate":"0.14926767275000000000","target":"origin"}],"order":null,"origin":{"CardId":"a93f3116-6bfb-46ae-aafe-a644ffa78437","amount":"0.05","base":"0.05","commission":"0.00","currency":"BAT","description":"geeta sarvadnya","fee":"0.00","isMember":true,"node":{"id":"a93f3116-6bfb-46ae-aafe-a644ffa78437","type":"card","user":{"id":"d830ec11-4f12-4d23-b7c8-fee31f9a249e"}},"rate":"1.00","sources":[{"amount":"0.05","id":"796842de-c4b3-4b05-9e37-91330cdf0ed4"}],"type":"card"},"params":{"currency":"BAT","pair":"BATBAT","progress":"1","rate":"1.00","ttl":3599996,"type":"internal"},"priority":"normal","reference":null,"status":"completed","type":"transfer"} ``` Recurring tip processed logs: ``` [20284:24044:1104/153138.525:VERBOSE1:contribution.cc(524)] Creating contribution for wallet type uphold (amount: 1, type: RECURRING_TIP) [20284:24044:1104/153138.556:VERBOSE1:contribution.cc(137)] Queue timer set for 5 s [20284:24044:1104/153138.559:VERBOSE1:url_loader.cc(72)] ---- [ REQUEST ] > URL: https://api-sandbox.uphold.com/v0/me/transactions/252e6312-cc19-493d-9532-cc8f28956af6 > Method: GET [20284:24044:1104/153151.182:VERBOSE1:url_loader.cc(111)] [ RESPONSE ] > URL: https://api-sandbox.uphold.com/v0/me/transactions/252e6312-cc19-493d-9532-cc8f28956af6 > Result: Success > HTTP Code: 200 > Body: {"application":{"clientId":"4c2b665ca060d912fec5c735c734859a06118cc8","name":"Brave Browser"},"createdAt":"2024-11-04T10:01:40.543Z","denomination":{"amount":"0.95","currency":"BAT","pair":"BATBAT","rate":"1.00","target":"origin"},"destination":{"amount":"0.95","base":"0.95","commission":"0.00","currency":"BAT","description":"Uphold Member","fee":"0.00","node":{"type":"anonymous"},"rate":"1.00","type":"anonymous"},"fees":[],"id":"252e6312-cc19-493d-9532-cc8f28956af6","message":null,"network":"uphold","normalized":[{"amount":"0.14","commission":"0.00","currency":"USD","fee":"0.00","rate":"0.14959104205000000000","target":"origin"}],"order":null,"origin":{"CardId":"a93f3116-6bfb-46ae-aafe-a644ffa78437","amount":"0.95","base":"0.95","commission":"0.00","currency":"BAT","description":"geeta sarvadnya","fee":"0.00","isMember":true,"node":{"id":"a93f3116-6bfb-46ae-aafe-a644ffa78437","type":"card","user":{"id":"d830ec11-4f12-4d23-b7c8-fee31f9a249e"}},"rate":"1.00","sources":[{"amount":"0.95","id":"796842de-c4b3-4b05-9e37-91330cdf0ed4"}],"type":"card"},"params":{"currency":"BAT","pair":"BATBAT","progress":"1","rate":"1.00","ttl":3599995,"type":"internal"},"priority":"normal","reference":null,"status":"completed","type":"transfer"} [20284:24044:1104/153151.184:VERBOSE1:wallet_provider.cc(157)] uphold transfer fee timer is being set for 90 s ----- [ REQUEST ] > URL: https://api-sandbox.uphold.com/v0/me/transactions/0fe46b11-7049-4cf1-b10f-6bc45689ed93 > Method: GET [20284:24044:1104/153528.212:VERBOSE1:url_loader.cc(111)] [ RESPONSE ] > URL: https://api-sandbox.uphold.com/v0/me/transactions/0fe46b11-7049-4cf1-b10f-6bc45689ed93 > Result: Success > HTTP Code: 200 > Body: {"application":{"clientId":"4c2b665ca060d912fec5c735c734859a06118cc8","name":"Brave Browser"},"createdAt":"2024-11-04T10:03:23.859Z","denomination":{"amount":"0.05","currency":"BAT","pair":"BATBAT","rate":"1.00","target":"origin"},"destination":{"amount":"0.05","base":"0.05","commission":"0.00","currency":"BAT","description":"Brave Browser","fee":"0.00","node":{"type":"anonymous"},"rate":"1.00","type":"anonymous"},"fees":[],"id":"0fe46b11-7049-4cf1-b10f-6bc45689ed93","message":"5% transaction fee collected by Brave Software International","network":"uphold","normalized":[{"amount":"0.01","commission":"0.00","currency":"USD","fee":"0.00","rate":"0.15007038770000000000","target":"origin"}],"order":null,"origin":{"CardId":"a93f3116-6bfb-46ae-aafe-a644ffa78437","amount":"0.05","base":"0.05","commission":"0.00","currency":"BAT","description":"geeta sarvadnya","fee":"0.00","isMember":true,"node":{"id":"a93f3116-6bfb-46ae-aafe-a644ffa78437","type":"card","user":{"id":"d830ec11-4f12-4d23-b7c8-fee31f9a249e"}},"rate":"1.00","sources":[{"amount":"0.05","id":"796842de-c4b3-4b05-9e37-91330cdf0ed4"}],"type":"card"},"params":{"currency":"BAT","pair":"BATBAT","progress":"1","rate":"1.00","ttl":3599997,"type":"internal"},"priority":"normal","reference":null,"status":"completed","type":"transfer"} ```
Uphold connected state_custodian mismatches_PASSED - Connect to Uphold custodian and open a publisher that is verified only with bitFlyer custodian e.g `wikipedia.org` and ensured that click on `Contribute` button opens up the panel `This creator currently only accepts contributions via the following methods:` message along with `bitFlyer` custodian option ![Image](https://github.com/user-attachments/assets/481cfd85-3951-4476-b65e-9e0d6cbb980d) - Connect to Uphold custodian and open a publisher which is verified with Gemini and Web 3 e.g github.com/miyayes, and ensured that click on `Contribute` button directly redirects to creator staging env with old contribution amount UI - This is expected as per https://github.com/brave/brave-browser/issues/41295#issuecomment-2457046189 ![Image](https://github.com/user-attachments/assets/64acd009-be95-4e45-99cd-5b0d5c993821) - Connect to Uphold custodian and open a publisher which is verified with bitFlyer and Web 3 e.g alexvincentmusic.com, and ensured that click on `Contribute` button directly redirects to creator staging env with old contribution amount UI - This is expected as per https://github.com/brave/brave-browser/issues/41295#issuecomment-2457046189
Gemini connected state_one-time and recurring Tip_QA Block due to environment issues **Note**: Tips were not processing due to network error, discussed with Gemini team, they have done some changes, we verified the issue again but were unable to login to Gemini accounts. Please find the following threads for more info: https://bravesoftware.slack.com/archives/CNH9Q6REV/p1730810037940789 https://bravesoftware.slack.com/archives/CNH9Q6REV/p1731092296143089?thread_ts=1721233592.471079&cid=CNH9Q6REV 1. Clean profile 1.72.x and enable #brave-rewards-new-rewards-ui via brave://flags 2. Enable rewards and connect to a Gemini custodian 3. Open a Gemini verified publisher e.g https://github.com/miyayes 4. Open contribution banner and ensured that publisher is verified with web3 and Gemini 5. Select Gemini and click on `Contribute` button 6. Confirmed that the contribution selection popup is displayed with list of contribution amounts 7. Select default contribution amount or enter custom contribution amount 8. Click recurring tip checkbox and click on send tip button 9. Confirmed that tip sent message is shown 10. Confirmed that one-time tip is sent and recurring tip is set 11. Confirmed that wallet balance is reduced after sending one time tip 12. Confirmed that recurring tip added is listed under event logs via brave://rewards-internals 14. Confirmed that tip sent are shown under brave://rewards-internals page 15. Confirmed that recurring tip set is displayed under `Recurring Contributions` panel on brave://rewards page 16. Confirmed that `Next contribution` date is displayed in the `Recurring Contributions` panel 17. Close the browser and forward the sys date to the date displayed in the recurring contribution panel 18. Confirmed that recurring tip is processed and wallet balance is reduced 19. Confirmed that recurring tip processed shown on the brave://rewards-internals page Example | Example | Example | Example | Example | Example | Example | Example | Example | Example ----------|-----------|-----------|----------|-----------|----------|-----------|---------|--------|-------- ![Image](https://github.com/user-attachments/assets/c5fa584e-01d2-46c2-8e46-095543566e63) | ![Image](https://github.com/user-attachments/assets/16e9193c-0fd6-4576-9bf9-b850301c06bd) | ![Image](https://github.com/user-attachments/assets/9f6ed02d-acdd-419b-9514-b82548ad34e6) | ![Image](https://github.com/user-attachments/assets/1dc4bf12-b140-4a17-9335-869b783b8ef2) | ![Image](https://github.com/user-attachments/assets/b497a616-a54e-4f0b-8ebb-8b57a95ba271) | ![Image](https://github.com/user-attachments/assets/9cf6c3d4-0e10-4e1d-bd2b-42b5cc0f0628) |
Gemini connected state_custodian mismatches_PASSED - Connect to Gemini custodian and open a publisher that is verified with Gemini custodian e.g `github.com/miyayes` and ensured that `Choose the method you want to use to contribute to Brave Software:` message with `Gemini` and `Web 3` custodian options are presented to the user. (As the creator is verified with both `Gemini` and `Web 3` custodians) ![Image](https://github.com/user-attachments/assets/653a507f-fe81-45c0-a541-7e22a55d348f) - Connect to Gemini custodian and open a publisher that is only verified with bitFlyer custodian e.g `wikipedia.org` and ensured that `This creator currently only accepts contributions via the following methods:` message with `bitFlyer` custodian option presented to the user. ![Image](https://github.com/user-attachments/assets/6fb23239-0393-498a-871e-636e7c7b83ab) - Connect to Gemini custodian and open a publisher that is only verified with uphold custodian e.g `laurenwags.github.io` and ensured that `This creator currently only accepts contributions via the following methods:` message with `Uphold` custodian option presented to the user. ![Image](https://github.com/user-attachments/assets/47f3d487-ee72-4f90-855a-623ce3c67351)
bitFlyer connected state_one-time and recurring Tip_PASSED 1. Clean profile 1.72.x and enable #brave-rewards-new-rewards-ui via brave://flags 2. Enable rewards and connect to a bitFlyer custodian 3. Open a bitFlyer verified publisher e.g alexvincentmusic 4. Open contribution banner and ensured that publisher is verified with web3 and bitFlyer 5. Select bitflyer and click on `Contribute` button 6. Confirmed that the contribution selection popup is displayed with list of contribution amounts 7. Select default contribution amount or enter custom contribution amount 8. Click recurring tip checkbox and click on send tip button 9. Confirmed that tip sent message is shown 10. Confirmed that one-time tip is sent and recurring tip is set 11. Confirmed that wallet balance is reduced after sending one time tip 12. Confirmed that recurring tip added is listed under event logs via brave://rewards-internals 14. Confirmed that tip sent are shown under brave://rewards-internals page 15. Confirmed that recurring tip set is displayed under `Recurring Contributions` panel on brave://rewards page 16. Confirmed that `Next contribution` date is displayed in the `Recurring Contributions` panel 17. Close the browser and forward the sys date to the date displayed in the recurring contribution panel 18. Confirmed that recurring tip is processed and wallet balance is reduced 19. Confirmed that recurring tip processed shown on the brave://rewards-internals page Example | Example | Example | Example | Example | Example | Example | Example | Example | Example ----------|-----------|-----------|----------|-----------|----------|-----------|---------|--------|-------- ![Image](https://github.com/user-attachments/assets/8ce5e178-7fc7-46d0-8300-4d19ca41bad2) | ![Image](https://github.com/user-attachments/assets/88a91c38-412c-4915-ac30-eb192b3dbaf9) | ![Image](https://github.com/user-attachments/assets/7cd0a0dd-f2a2-400e-8353-a5b8ef2f6af7) | ![Image](https://github.com/user-attachments/assets/b9f81985-1c59-43c1-bcdd-ceac91290709) | ![Image](https://github.com/user-attachments/assets/3e2be50f-7d20-404d-bf81-f1ff047f0053) | ![Image](https://github.com/user-attachments/assets/4c80387f-05cc-48e1-8eed-6036f02c7f08) | ![Image](https://github.com/user-attachments/assets/2495af2d-829e-4fee-a265-1cb49d09b8af) | ![Image](https://github.com/user-attachments/assets/afdf6cad-82fd-47a3-8469-1c639262deca) | ![Image](https://github.com/user-attachments/assets/d1cf3d4d-08cb-44d2-bd21-c80da8be620c) | ![Image](https://github.com/user-attachments/assets/ddaf74a0-f4b3-45ab-8cba-3e75673cc195)
bitFlyer_connected state_custodian mismatches_PASSED 1. Connect to bitFlyer custodian and open a publisher that is only verified with bitFlyer custodian e.g `wikipedia.org` and click on the `Contribute` button and ensured that contribution amount new UI is shown ![Image](https://github.com/user-attachments/assets/70dedf41-e59b-43d6-8811-f0ec0a12ab76) 2. Connect to bitFlyer custodian and open a publisher that is verified with `Gemini` and `Web 3` e.g github.com/miyayes, click on the `Contribute` button redirects to creators staging evn with old contribution amount options instead of `This creator currently only accepts contributions via the following methods:` message with `Gemini` and `Web 3` custodian options. - This is expected as per https://github.com/brave/brave-browser/issues/41295#issuecomment-2457046189 3. Connect bitFlyer custodian and open a publisher that is verified with `bitFlyer` and `Web 3` e.g alexvincentmusic.com, click on the `Contribute` button and ensured that `This creator currently only accepts contributions via the following methods:` message with `bitFlyer ` and `Web 3` custodian option presented to the user as expected. ![Image](https://github.com/user-attachments/assets/9017ce86-1d0e-438b-9b3a-d9fdeaf47918) 4. Connect to bitFlyer custodian and open a publisher that is only verified with uphold custodian e.g `laurenwags.github.io` and click on the `Contribute` button and ensured that `This creator currently only accepts contributions via the following methods:` message with `Uphold` custodian option presented to the user as expected ![Image](https://github.com/user-attachments/assets/31860fb1-665f-4df7-9d81-3e15e5814e45)
ZebPay_connected state_Blocked_QA Block due to environment issues **Note**: Unable to login ZebPay sandbox accounts due to environment issue, please see the thread for more info https://bravesoftware.slack.com/archives/C04H4PJFMPG/p1728579215913519
Solana_connected state_PASSED
Connect Solana custodian_PASSED 1. Clean profile 1.73.x. 2. Enable the Rewards 3.0 flag: #brave-rewards-new-rewards-ui (Show the new Rewards UI). 3. Relaunch as needed. 4. Enable Rewards. 5. Get Rewards Payment ID from rewards-internals 6. Whitelist the payment id 7. After whitelisted, restart the browser and see if invitation notice UI appears in NTP Rewards Widget and Rewards Panel 8. Self custody notification is shown on the BR panel as well as on brave://rewards settings page 9. Click on the notification bubble on the BR panel 10. On rewards panel, press the "Connect account" button. 11. Confirm that brave://rewards/connect page is opened with self custody `Brave-wallet` Solana wallet 12. Verify that connect account screen is displayed with the correct options. 13. Select the `Brave -wallet` custodial provider and complete the brave wallet linking flow 14. Ensure that user is in the connected state after Solana linking flow is completed. 15. The rewards balance (in BAT) is displayed only on the NTP, wallet balance is shown on the BR panel and rewards settings page as expected 16. Confirmed that `Payout account` card is shown on the brave://rewards page and BR panel 17. Confirmed that account balance and payout account name is displayed correctly on the `Payout account` card on the brave://rewards page and BR panel 18. Confirmed that payout account dropdown items `{Custodian} wallet `Connected`` and `Go to my account` are displayed as expected on the brave://rewards page and BR panel Example | Example | Example | Example | Example | Example | Example | Example ----------|-----------|-----------|-----------|-----------|----------|-----------|-------- ![Image](https://github.com/user-attachments/assets/b98b9275-8112-45e3-9b06-aa76da5df3be) | ![Image](https://github.com/user-attachments/assets/721ae260-efe5-4814-b376-869f9788de41) | ![Image](https://github.com/user-attachments/assets/17e7b76b-3ffc-42bc-bf65-9dfa22e74feb) | ![Image](https://github.com/user-attachments/assets/da3be9b4-7cab-4ff2-a629-748f976d0a7c) | ![Image](https://github.com/user-attachments/assets/dcc9cd3b-aa8e-4484-853b-48373bf6aa55) | ![Image](https://github.com/user-attachments/assets/41117118-36cf-46ea-88ca-3b53123ad5ee) | ![Image](https://github.com/user-attachments/assets/c345bfe3-85fb-46ee-9323-b23d51076ed2) | ![Image](https://github.com/user-attachments/assets/abe6fcae-89e3-4f22-8f10-938bff6bb987)
Solana_connected state_verify web 3 contribution banner_PASSED **Note**: Tipping for web 3 on chain contribution is out of scope as per https://github.com/brave/brave-browser/issues/41295#issuecomment-2468839686 1. Continuation of case above 2. Open a verified web 3 publisher e.g github.com/miyayes 3. Click on the BR panel 4. Click on `Contribute` button 5. Publisher staging contribution panel is displayed with old contribution UI (This is expected as per the https://github.com/brave/brave-browser/issues/41295#issuecomment-2465024267) Step 2 | Step 4 | Step 5 --------|--------|------- ![Image](https://github.com/user-attachments/assets/0767991e-2128-4291-8759-037ec9b80a79) | ![Image](https://github.com/user-attachments/assets/0cff813a-4704-406d-869b-7e07c6682d8d) | ![Image](https://github.com/user-attachments/assets/34cd837f-d123-4d8a-a03d-d16ee57e437a)
Solana custodian mismatch message_PASSED
1. When I open uphold only verified publisher laurenwags.github.io and open BR panel and click on `Contribute` button I see the custodian mismatch message as expected below: Example | Example ----------|-------- ![Image](https://github.com/user-attachments/assets/87326958-b277-46c7-a289-c035e3b5a155) | ![Image](https://github.com/user-attachments/assets/a8a056fc-33ff-4caf-bb35-6a1b5fab903c) 2. When I open bitFlyer only verified publisher wikipedia.org and open BR panel and click on `Contribute` button I see the custodian mismatch message as expected below: Example | Example ----------|-------- ![Image](https://github.com/user-attachments/assets/d00bfa66-ac46-47c9-a4f0-8cce66cac02b) | ![Image](https://github.com/user-attachments/assets/87dbc004-d8da-4f5e-a9d1-92c54495db96) 3. When I open a publisher which is verified with Web 3 and Gemini e.g github.com/miyayes and tap on the BR panel and click on the `Contribute` button opens up the publisher staging contribution banner. This is expected as per https://github.com/brave/brave-browser/issues/41295#issuecomment-2465024267 Example | Example ----------|--------- ![Image](https://github.com/user-attachments/assets/87404fd5-df80-4443-8122-0ea215c963b5) | ![Image](https://github.com/user-attachments/assets/ab843a7f-194b-42bd-bc5e-65eb5ddb93fa) 4. When I open a publisher which is verified with Web 3 and bitFlyer e.g alexvincentmusic.com and tap on the BR panel and click on the `Contribute` button opens up the publisher staging contribution banner. This is expected as per https://github.com/brave/brave-browser/issues/41295#issuecomment-2465024267 Example | Example ----------|--------- ![Image](https://github.com/user-attachments/assets/099bdd1d-947b-45d1-9025-dbe5e9f108ad) | ![Image](https://github.com/user-attachments/assets/d28fc781-2cc6-4c60-9780-8045326d9e88)

GeetaSarvadnya commented 3 weeks ago

@zenparsing: When I connect to Gemini custodian and open a uphold publisher on 1.72.x without #brave-rewards-new-rewards-ui flag enabled, I am getting Can't send your contribution, This creator is unable to receive contributions from Gemini. message on the tipping banner, but with #brave-rewards-new-rewards-ui flag enabled I am seeing the following message on the contribution banner looks like this is the custodian mismatch message on 1.72.x rewards 3.0 with flag enabled. Can you review the same and let me know whether this is expected custodian mismatch message on rewards 3.0 with new rewards ui flag enable?. Thanks!

Image

GeetaSarvadnya commented 3 weeks ago

@zenparsing: When user is connected to Gemini and open alexvincentmusic.com (creator is verified with both bitFlyer and Web3), click on Contribute button directly redirects to creators staging env, the message This creator currently only accepts contributions via the following method . The web 3 option is NOT shown contribution panel after clicking on Contribute button. Also, the old contribution amount UI is shown. The contribution amount new UI is not applicable for web 3 creators contribution banner?

Same issue with case below:

cc: @Miyayes @LaurenWags

Example Example new contribution amount UI
Image Image Image
GeetaSarvadnya commented 3 weeks ago

@Miyayes @zenparsing: One time tip and recurring tips are not processing for Gemini publisher. I have connected to Gemini custodian and setup recurring tip and sent a one time tip to a verified Gemini publisher and waited for enough time (3 to 4 hours) but still one-time tip did not go through. I have set sys date ahead and waited for recurring tip process as well but no luck.

@zenparsing: let me know if you would like to have a look at the logs.

cc: @LaurenWags

zenparsing commented 3 weeks ago

@GeetaSarvadnya The screenshots look like the expected behavior according to the designs. @Miyayes do you agree?

I'm current testing Gemini staging transactions, and will post results on Slack.

GeetaSarvadnya commented 3 weeks ago

@zenparsing: I am verifying tipping via Solana custodian I need clarification on the questions for the following steps 5, 8 and 9.

Please let me know if steps are not clear.

  1. Connect to Solana account (steps are mentioned in Connect Solana custodian case via https://github.com/brave/brave-browser/issues/41295#issuecomment-2431783785
  2. Open a verified web 3 publisher e.g github.com/miyayes
  3. Click on the BR panel
  4. Click on Contribute button
  5. Publisher staging contribution panel is displayed with old contribution UI Q1. Click on Contribute button should display contribution panel with Web 3 custodian option or it should redirect to publisher staging banner directly? Q2. Publisher staging banner doesn't have the contribution amount new UI. Is this expected? Q3. To tip a web 3 publisher github.com/miyayes what network we supposed to select from the dropdown? I have funded Solana Mainnet from 1Passwod and connected the same wallet to the rewards which has the actual BAT hence I have not done tipping so far. Q4. SPL-BAT(Wormhole) network has 29+BAT can QA use this for tipping?
Step 2 Step 4 Step 5
Image Image Image
  1. When I open uphold only verified publisher laurenwags.github.io and open BR panel and click on Contribute button I see the custodian mismatch message as expected below:
Example Example
Image Image
  1. When I open bitFlyer only verified publisher wikipedia.org and open BR panel and click on Contribute button I see the custodian mismatch message as expected below:
Example Example
Image Image
  1. When I open a publisher which is verified with Web 3 and Gemini e.g github.com/miyayes and tap on the BR panel and click on the Contribute button opens up the publisher staging contribution banner. Q. Is this expected?
Example Example
Image Image
  1. When I open a publisher which is verified with Web 3 and bitFlyer e.g alexvincentmusic.com and tap on the BR panel and click on the Contribute button opens up the publisher staging contribution banner. Q. Is this expected?
Example Example
Image Image

cc: @Miyayes @LaurenWags

zenparsing commented 2 weeks ago

@GeetaSarvadnya Everything looks expected to me.

GeetaSarvadnya commented 2 weeks ago

Thanks for the clarifications @zenparsing!

@Miyayes: Can you provide clarifications on the above https://github.com/brave/brave-browser/issues/41295#issuecomment-2465024267? (Points 5.3 and 5.4). Thanks!

cc: @LaurenWags

LaurenWags commented 2 weeks ago

@GeetaSarvadnya afaik Dapp is separate from browser process so I wouldn't worry about it (it has generally been outside the scope of our testing), but we can see what @Miyayes says 👍🏻

Miyayes commented 2 weeks ago

For testing Web3 contributions, as long as you can load the correct contribution webpage (dApp) for the creator, that is enough. For this, we do not need to test actually making an on-chain Web3 contribution. @GeetaSarvadnya @LaurenWags

GeetaSarvadnya commented 2 weeks ago

Thanks @Miyayes !