[Follow up to #39886] `Private Tab` is opened using the `New Tab` button via `Brave Shortcuts` widget - Githubissues

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.

https://brave.com

Mozilla Public License 2.0

17.73k stars 2.31k forks source link

[Follow up to #39886] `Private Tab` is opened using the `New Tab` button via `Brave Shortcuts` widget #41307

Open hffvld opened 2 weeks ago

hffvld commented 2 weeks ago

Description

Follow-up to #39886.

Steps to reproduce

Launch Brave
Add Brave Shortcuts widget to the home screen
Tap Private Tab > Confirm that Private tab is opened
Return to the home screen, and keep Brave opened in the background
Tap New Tab > Observe that another Private tab is opened

Actual result

Private Tab is opened using the New Tab button via Brave Shortcuts widget.

https://github.com/user-attachments/assets/9c7ce83f-f6ac-4a7e-a15b-5c2d339f6d4e

Expected result

If using the New Tab button via the Brave Shortcuts widget, the Standard Tab must be opened.

Reproduces how often

Easily reproduced

Brave version

Brave build: 1.70 (119) BraveCore: 1.70.119 (129.0.6668.70)

Device/iOS version

iPhone 14 / iOS 17.7
iPad Mni (6th gen) / iPadOS 18

Affected browser versions

[X] latest AppStore
[X] latest TestFlight
[X] previous TestFlight

Reproducibility

[ ] with Brave Shields disabled
[ ] in the latest version of mobile Safari

Miscellaneous information

No response

kylehickinson commented 2 weeks ago

This is technically expected behaviour, "new tab" usually refers to a new tab in your current configuration, whereas "new private tab" refers to specifically opening a private session. The problem is we don't necessarily want to kick the user out of private browsing mode since the act of doing so would wipe their private tabs. Lets discuss in triage how we want to tackle this