brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.83k stars 2.33k forks source link

Leo Setting Title and Reset and clear Leo data text colour is different #41380

Open srirambv opened 1 month ago

srirambv commented 1 month ago

Description

Title and info text colour is different for Leo settings

Steps to reproduce

  1. Open Settings
  2. Select Leo
  3. Setting Title and Reset and clear Leo data text colour is different

Actual result

image

Expected result

Should be same colour as per Nala design system

Reproduces how often

Easily reproduced

Brave version

All

Device

Channel information

Reproducibility

Miscellaneous information

cc: @aguscruiz @deeppandya @Uni-verse @hffvld

aguscruiz commented 1 month ago

This is expected, because "Reset Leo data" is a destructive action and should be Red.

What needs to be implemented is replacing all the orange bits to blurple, like on the designs. This is a general issue for everything under settings.

image

https://www.figma.com/design/MNwi0uwXNhkAbPiJ86G4vm/%E2%9C%A8-Leo?node-id=2878-4813&t=NxoSpkEnaR3e6zH5-1

deeppandya commented 1 month ago

Yeah I agree. we need to change the same at many different places. I will create an issue for settings changes with screenshots.