Changing model requires a manual refresh for Leo to respond - Githubissues

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.

https://brave.com

Mozilla Public License 2.0

17.71k stars 2.31k forks source link

Changing model requires a manual refresh for Leo to respond #41381

Open srirambv opened 1 week ago

srirambv commented 1 week ago

Description

Changing model requires a manual refresh for Leo to respond

Steps to reproduce

Setup a dummy BYOM
Set it as default
Open Leo and ask a question
Shows network error
Switch to Free model/Premium model
Doesn't auto-retires, error message remains on screen
Manually Retry, Leo responds when manually changing model

Actual result

https://github.com/user-attachments/assets/53c53c19-351b-4c43-9114-9c1cd6098293

Expected result

Maybe manually changing model should automatically dismiss the error and continue responding

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave	1.71.102 Chromium: 129.0.6668.70 (Official Build) beta (64-bit)
Revision	d901535b1091c5f39eb2b5426b8fa8e7f3c5edf0
OS	Windows 11 Version 23H2 (Build 22631.4169)

Channel information

[X] release (stable)
[X] beta
[X] nightly

Reproducibility

[ ] with Brave Shields disabled
[ ] with Brave Rewards disabled
[ ] in the latest version of Chrome

Miscellaneous information

cc: @mattmcalister @rebron

mattmcalister commented 16 hours ago

this is the expected behavior, although I think you're suggesting a refinement to the failure case. can you explain more what you think it should do?