brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.69k stars 2.31k forks source link

Sync delete icon/color isn't from Nala #41526

Open MadhaviSeelam opened 3 days ago

MadhaviSeelam commented 3 days ago

Description

After deleting Sync account, the warning message that was shown has an icon/color that is not from Nala

Steps to reproduce

  1. Install 1.71.110
  2. Launch Brave
  3. Visit wikipedia.org
  4. Enable Sync on Profile 1
  5. Join sync on Profile 2
  6. Click Delete Sync account on Profile 2
  7. Return to Profile 1
  8. Stay on the page for few seconds to trigger This Brave Sync account was deleted.... message

Actual result

Sync delete icon/color is not from Nala

example example example
Image Image Image

Another instance:

Image

Expected result

Nala color and icon should show in the Sync warning message

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave 1.71.110 Chromium: 129.0.6668.100 (Official Build) beta (64-bit)
Revision 46cd0b1af7127687895fcaceff93dd80e29e6f2b
OS Windows 11 Version 23H2 (Build 22631.4317)

Channel information

Reproducibility

Miscellaneous information

@rebron @aguscruiz cc: @brave/qa-team

aguscruiz commented 3 days ago

We should use our warning-circle-outline in semantic/icon/default color

Quick mock here

Image