brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.88k stars 2.34k forks source link

"IPFSEnabled" Group Policy Documentation is No Longer Relevant #41529

Open DesertBear opened 1 month ago

DesertBear commented 1 month ago

Description

The documentation for IPFSEnabled Group Policy setting is no longer relevant, as local node and protocol support for IPFS was deprecated in Brave as of 22 August 2024 (Brave version 1.69.153).

Brave IPFS notice here: https://brave.com/blog/ipfs-support/ (https://github.com/brave/brave-browser/issues/37735)

Brave Group Policy documentation page here: https://support.brave.com/hc/en-us/articles/360039248271-Group-Policy

Steps to reproduce

Not applicable.

Actual result

If IPFSEnabled is set to 0 (Disabled), it will display an error on the brave://policy page, as it's no longer a valid Group Policy setting.

Screenshot: Image

Expected result

The IPFSEnabled setting should either be removed from the Group Policy documentation page, or a note added to indicate that this Group Policy setting is now deprecated.

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave:     1.70.123 Chromium: 129.0.6668.89 (Official Build) (64-bit) 
Revision:  7c1bbf03546a64d969d010808e4f5c99fdf343bb
OS:        Windows 11 Version 23H2 (Build 22631.4317)

Channel information

Reproducibility

Miscellaneous information

No response

mihaiplesa commented 1 week ago

@bsclifton is this good to remove?