search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.9k stars 2.34k forks source link

Once the publisher is removed from the AC table, the same publisher can't be re-added to AC table #41542

Open GeetaSarvadnya opened 1 month ago

GeetaSarvadnya commented 1 month ago

Description

Found while testing https://github.com/brave/brave-browser/issues/40563

Once the publisher is removed from the AC table, the same publisher can't be re-added to AC table

Steps to reproduce

  1. Clean profile 1.71.104
  2. Open brave://flags and enable the flag #brave-rewards-new-rewards-ui
  3. Enable brave rewards
  4. Confirmed that Connect account button is shown on all the 3 places, brave://rewrads, BR panel and NTP
  5. Click on Connect account button from any one of the 3 places
  6. Choose a custodian and connect to a custodian
  7. Confirm that custodian is connected and wallet balance is shown as expected
  8. Observe that Auto contribute default amount is 0.0 (the default needs to be changed to 1 BAT)
  9. Add few verified publisher to AC table (laurenwags.github.io and wikipedia.org)
  10. Make sure publishers are added to AC table
  11. Remove publishers and try to re-add them by visiting the publisher websites

Actual result

Once the publisher is removed from the AC table, the same publisher can't be re-added to AC table

Expected result

publishers should be re-added to AC table

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave 1.71.104 Chromium: 129.0.6668.89 (Official Build) beta (64-bit)
Revision 3da42496f366e4dc607c58cfdd95ce3f5064c171
OS Windows 10 Version 22H2 (Build 19045.5011)

Channel information

Reproducibility

Miscellaneous information

cc: @Miyayes @zenparsing @brave/qa-team

GeetaSarvadnya commented 1 month ago

This issue is reproducible on the latest beta build 1.72.77 also.

Brave | 1.72.77 Chromium: 130.0.6723.31 (Official Build) beta (64-bit)
-- | --
Revision | 497d0405200256950cdb3bfc52cfd0745277c18b
OS | Windows 10 Version 22H2 (Build 19045.5011)

cc: @Miyayes @zenparsing @LaurenWags

zenparsing commented 1 month ago

@Miyayes There might not be a way in the 3.0 designs to "un-exclude" a publisher from AC (in the current panel, I think there's a toggle).