brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.75k stars 2.32k forks source link

Upgrade from C130 -> C131 on macOS via 1.73.x - Nightly (Checking C131) #41841

Open LaurenWags opened 18 hours ago

LaurenWags commented 18 hours ago

As per process, QA runs through the following cases to ensure that the major chromium bump that's about to get merged into master doesn't regress the Nightly channel. Once the major chromium bump is merged into master, QA will run through a full manual pass on Windows & Android.

Startup & Components

Note: Always double check brave://components to make sure there's no errors/missing version numbers

Upgrade

LaurenWags commented 17 hours ago

Tests above verified with

Brave   1.73.39 Chromium: 131.0.6778.14 (Official Build) nightly (arm64) 
Revision    6efd8010cd2636a33b10422509349592bcbce006
OS  macOS Version 15.1 (Build 24B82)
GeetaSarvadnya commented 9 hours ago

Upgrade checks (using arm64 .dmg):

Brave | 1.73.39 Chromium: 131.0.6778.14 (Official Build) nightly (arm64)
-- | --
Revision | 6efd8010cd2636a33b10422509349592bcbce006
OS | macOS Version 12.5 (Build 21G72)

Note, need to be on internal VPN to do the below upgrade checks.

C131 --> C131 on-demand upgrade check - PASSED(with update error, not verified delta updates via fiddler) 1. Install `C131` PR build(arm64 builds available via https://bravesoftware.slack.com/archives/CU5UXM3EC/p1729707902812909?thread_ts=1729707419.818579&cid=CU5UXM3EC) 2. Launch via terminal as follows: `/Applications/Brave\ Browser\ Nightly.app/Contents/MacOS/Brave\ Browser\ Nightly --args --enable-logging=stderr --update-feed-url=https://updates.brave.com/sparkle/Brave-Browser/nothanks/appcast.xml` (this is so you don't pick up any newer Nightly versions that have already been uploaded to sparkle) 3. Watch logs, confirm no update found (can also visit `brave://settings/help` but close this tab prior to closing the browser) ![Image](https://github.com/user-attachments/assets/6f7496d5-40ab-4b08-9a06-35952b4c1f09) ``` [1892:259:1024/143130.640374:INFO:sparkle_glue.mm(399)] brave update: did abort with error: An error occurred in retrieving update information. Please try again later. ``` 5. Close `Brave` 6. Note, if you want to check deltas, at this point open something like Fiddler Everywhere before continuing. 7. Relaunch with `/Applications/Brave\ Browser\ Nightly.app/Contents/MacOS/Brave\ Browser\ Nightly --args --enable-logging=stderr --update-feed-url=https://updates-panel.brave.com/sparkle/Brave-Browser/nightly-arm64/appcast.xml` 8. Navigate to `brave://settings/help` and ensured that an update has been found/being applied ``` [2963:259:1024/150139.552314:INFO:sparkle_glue.mm(327)] brave update: did finish loading appcast [2963:259:1024/150139.553891:INFO:sparkle_glue.mm(333)] brave update: did find valid update with AppcastItem(Date: Wed, 23 Oct 2024 22:51:26 +0000, Version: 1.73.40.0) [2963:259:1024/150139.556200:INFO:sparkle_glue.mm(354)] brave update: willDownloadUpdate with AppcastItem(Date: Wed, 23 Oct 2024 22:51:26 +0000, Version: 1.73.40.0) [2963:259:1024/151321.968020:INFO:sparkle_glue.mm(390)] brave update: will install update on quit with AppcastItem(Date: Wed, 23 Oct 2024 22:51:26 +0000, Version: 1.73.40.0) [2963:259:1024/151454.487849:INFO:sparkle_glue.mm(380)] brave update: will install update with AppcastItem(Date: Wed, 23 Oct 2024 22:51:26 +0000, Version: 1.73.40.0) ``` 9. Confirm you are prompted to "Relaunch" to get update (note, if you click "Relaunch" button you will relaunch and could potentially pick up a newer Nightly that is on the previous Chromium version. Closing and then relaunching via the terminal will not update you again) ![Image](https://github.com/user-attachments/assets/d672c5b5-f709-4122-8861-ebc9c89431ef) Once relaunched, ensured the correct version was installed as per the following: **`Example`** | **`Example`** ----------------|---------------- ![Image](https://github.com/user-attachments/assets/6bfd1161-ceb4-4280-b7ae-bd11b7970757) | ![Image](https://github.com/user-attachments/assets/756b7369-3f1b-4ef6-a7f2-51b7335f128a) Confirmed deltas: **`Example`** | **`Example`** ----------------|----------------
C130 --> C131 on-demand upgrade check - PASSED(with update error) 1. Install `C130` build via https://github.com/brave/brave-browser/releases/tag/v1.73.39 2. Launch via terminal as follows: `/Applications/Brave\ Browser\ Nightly.app/Contents/MacOS/Brave\ Browser\ Nightly --args --enable-logging=stderr --update-feed-url=https://updates.brave.com/sparkle/Brave-Browser/nothanks/appcast.xml` (this is so you don't pick up any newer Nightly versions that have already been uploaded to sparkle) 3. Watch logs, confirm no update found (can also visit `brave://settings/help` but close this tab prior to closing the browser) ![Image](https://github.com/user-attachments/assets/aa60a9c6-d845-48ca-99e9-9ceea4114d79) ``` [1177:259:1024/133213.840042:INFO:sparkle_glue.mm(399)] brave update: did abort with error: An error occurred in retrieving update information. Please try again later. ``` 4. Close `Brave` 5. Relaunch with `/Applications/Brave\ Browser\ Nightly.app/Contents/MacOS/Brave\ Browser\ Nightly --args --enable-logging=stderr --update-feed-url=https://updates-panel.brave.com/sparkle/Brave-Browser/nightly-arm64/appcast.xml` 6. Navigate to `brave://settings/help` and ensured that an update has been found/being applied ``` [1289:259:1024/133749.603234:INFO:sparkle_glue.mm(327)] brave update: did finish loading appcast [1289:259:1024/133749.606200:INFO:sparkle_glue.mm(333)] brave update: did find valid update with AppcastItem(Date: Wed, 23 Oct 2024 22:51:26 +0000, Version: 1.73.40.0) [1289:259:1024/133749.607685:INFO:sparkle_glue.mm(354)] brave update: willDownloadUpdate with AppcastItem(Date: Wed, 23 Oct 2024 22:51:26 +0000, Version: 1.73.40.0) [1289:259:1024/133905.252197:INFO:sparkle_glue.mm(354)] brave update: willDownloadUpdate with AppcastItem(Date: Wed, 23 Oct 2024 22:51:26 +0000, Version: 1.73.40.0) [1289:259:1024/134700.679274:INFO:sparkle_glue.mm(390)] brave update: will install update on quit with AppcastItem(Date: Wed, 23 Oct 2024 22:51:26 +0000, Version: 1.73.40.0) ``` 7. Confirm you are prompted to "Relaunch" to get update (see note in first case about this button) ![Image](https://github.com/user-attachments/assets/5cd5625f-0ef8-48bf-9a89-3224ada02c73) Once relaunched, ensured the correct version was installed as per the following: **`Example`** | **`Example`** ----------------|---------------- ![Image](https://github.com/user-attachments/assets/23ff4587-30fb-4d78-a242-76fad89d4c5d) | ![Image](https://github.com/user-attachments/assets/9f20c9d7-27cb-46d1-9023-fca87e8fbf59)
C131 --> C131 background upgrade check - 1. Install `C130` PR build (arm64 builds available via https://bravesoftware.slack.com/archives/CU5UXM3EC/p1727798586109619?thread_ts=1727798559.900959&cid=CU5UXM3EC) 2. Launch via terminal as follows: `/Applications/Brave\ Browser\ Nightly.app/Contents/MacOS/Brave\ Browser\ Nightly --args --enable-logging=stderr --update-feed-url=https://updates.brave.com/sparkle/Brave-Browser/nothanks/appcast.xml` (this is so you don't pick up any newer Nightly versions that have already been uploaded to sparkle) 3. Watch logs, confirm no update found (can also visit `brave://settings/help` but be sure to close this tab prior to closing the browser) Screenshot 2024-10-03 at 7 36 27 PM ``` [2843:259:1003/193624.342999:INFO:sparkle_glue.mm(346)] brave update: did not find update ``` 4. Close browser 5. Delete the following: - `com.brave.Browser.nightly` folder from `~/Library/Caches` - `com.brave.Browser.nightly.plist` file from `~/Library/Preferences` - Alternatively you can probably advance your computer clock ~4 hours, I am fairly certain deleting at least one of the above files removes the timer check for background updates. 6. Restart your computer if you deleted files (if you just advanced computer clock this step isn't necessary) 7. Note, if you want to check deltas, at this point open something like Fiddler Everywhere before continuing. 8. After computer restart, Relaunch with `/Applications/Brave\ Browser\ Nightly.app/Contents/MacOS/Brave\ Browser\ Nightly --args --enable-logging=stderr --update-feed-url=https://updates-panel.brave.com/sparkle/Brave-Browser/nightly-arm64/appcast.xml` 9. DO NOT navigate to `brave://settings/help` 10. Watch the logs and see that an update is found (be sure you have all of the below before proceeding) ``` [925:259:1003/195700.150966:INFO:sparkle_glue.mm(327)] brave update: did finish loading appcast [925:259:1003/195700.152179:INFO:sparkle_glue.mm(333)] brave update: did find valid update with AppcastItem(Date: Tue, 01 Oct 2024 16:02:26 +0000, Version: 1.72.51.0) [925:259:1003/195700.152609:INFO:sparkle_glue.mm(354)] brave update: willDownloadUpdate with AppcastItem(Date: Tue, 01 Oct 2024 16:02:26 +0000, Version: 1.72.51.0) [925:259:1003/195723.130767:INFO:sparkle_glue.mm(390)] brave update: will install update on quit with AppcastItem(Date: Tue, 01 Oct 2024 16:02:26 +0000, Version: 1.72.51.0) ``` 11. Close and restart the browser via terminal with same command as step 8 12. Check version is updated under `brave://version` Screenshot 2024-10-03 at 8 05 28 PM 13. Confirmed deltas: Example | Example --- | --- Screenshot 2024-10-03 at 8 07 09 PM | Screenshot 2024-10-03 at 8 07 46 PM
C130 --> C131 background upgrade check - INPROGRESS 1. Install `C130` build via https://github.com/brave/brave-browser/releases/tag/v1.73.38 2. Launch via terminal as follows: `/Applications/Brave\ Browser\ Nightly.app/Contents/MacOS/Brave\ Browser\ Nightly --args --enable-logging=stderr --update-feed-url=https://updates.brave.com/sparkle/Brave-Browser/nothanks/appcast.xml` (this is so you don't pick up any newer Nightly versions that have already been uploaded to sparkle) 3. Watch logs, confirm no update found (can also visit `brave://settings/help` but be sure to close this tab prior to closing the browser) 5. Close browser 6. Delete the following: - `com.brave.Browser.nightly` folder from `~/Library/Caches` - `com.brave.Browser.nightly.plist` file from `~/Library/Preferences` - Alternatively you can probably advance your computer clock ~4 hours, I am fairly certain deleting at least one of the above files removes the timer check for background updates. 7. Restart your computer if you deleted files (if you just advanced computer clock this step isn't necessary) 8. After computer restart, Relaunch with `/Applications/Brave\ Browser\ Nightly.app/Contents/MacOS/Brave\ Browser\ Nightly --args --enable-logging=stderr --update-feed-url=https://updates-panel.brave.com/sparkle/Brave-Browser/nightly-arm64/appcast.xml` 10. DO NOT navigate to `brave://settings/help` 11. Watch the logs and see that an update is found (be sure you have all of the below before proceeding) ``` [660:259:1003/203348.212002:INFO:sparkle_glue.mm(327)] brave update: did finish loading appcast [660:259:1003/203348.214014:INFO:sparkle_glue.mm(333)] brave update: did find valid update with AppcastItem(Date: Tue, 01 Oct 2024 16:02:26 +0000, Version: 1.72.51.0) [660:259:1003/203348.214873:INFO:sparkle_glue.mm(354)] brave update: willDownloadUpdate with AppcastItem(Date: Tue, 01 Oct 2024 16:02:26 +0000, Version: 1.72.51.0) [660:259:1003/203434.257303:INFO:sparkle_glue.mm(354)] brave update: willDownloadUpdate with AppcastItem(Date: Tue, 01 Oct 2024 16:02:26 +0000, Version: 1.72.51.0) [660:259:1003/204005.988968:INFO:sparkle_glue.mm(390)] brave update: will install update on quit with AppcastItem(Date: Tue, 01 Oct 2024 16:02:26 +0000, Version: 1.72.51.0) ``` 12. Close and restart the browser via terminal with same command as step 8 13. Check version is updated under `brave://version` Screenshot 2024-10-03 at 8 42 17 PM