brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
18k stars 2.36k forks source link

[split-view] Dragging right tab of a tiled pair to new browser leads to blank the left tab #41852

Open philong6297 opened 1 month ago

philong6297 commented 1 month ago

Description

There is an issue when dragging a tiled pair to new browser. Its only happens when we are trying to drag the RIGHT tab of the pair. When trying to debug, I got DCHECK. Tested on several versions of Brave also

Steps to reproduce

  1. Make sure “BraveSplitView” (brave://flags/#brave-split-view) feature is enabled
  2. Prepare 2 browser windows A and B
  3. In browser window A, create a split view
  4. MAKE SURE to click on the RIGHT tab of this tiled view to gain focus
  5. Drag the RIGHT tab to browser B, it will also drag the tiled pair
  6. Observe the this tiled pair in browser B

Actual result

the LEFT tab is blanked https://github.com/user-attachments/assets/4017fce1-66b2-4f25-8da8-9b7bda586d8d

Expected result

the LEFT tab is not blanked

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave 1.73.39 Chromium: 130.0.6723.70 (Official Build) nightly (64-bit) Revision 6efd8010cd2636a33b10422509349592bcbce006 OS Windows 11 Version 23H2 (Build 22631.4317)

Channel information

Reproducibility

Miscellaneous information

Here is the crash dump in revision: v1.70.126 Built with debug got an DCHECK dbc91766-8e1d-4a46-975a-0a898a8ba3e3.dmp

philong6297 commented 1 month ago

Same crash dump (DCHECK) on v1.71.118 0c09863b-27bb-452f-9045-2445d4706d10.dmp

hqtuan99 commented 4 weeks ago

i have also experienced this issue, looks like a real bug

sonseven5997 commented 4 weeks ago

It is reproducible on Windows 11. Brave Nightly 1.73.67

ndtu1511 commented 3 weeks ago

+1. I have used tab dragging a lot, and I always have to reload the tab on the left.