brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.96k stars 2.35k forks source link

Radio buttons & dropdown menu selections should use Nala colors #42172

Open MadhaviSeelam opened 2 weeks ago

MadhaviSeelam commented 2 weeks ago

Description

Radio buttons & dropdown menu selections should use Nala colors

Steps to reproduce

  1. Install 1.73.x
  2. launch Brave
  3. open brave://settings/importData
  4. open dropdown menu
  5. open brave://settings/search >> Change

Actual result

Dropdown menu does not show nala color when hover over an selection Radio button does not show nala color

Expected result

Drop down menu selections & Radio buttons should show Nala colors

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave | 1.73.86 Chromium: 131.0.6778.39 (Official Build) (64-bit)
-- | --
Revision | 52163bcf4e40f27ddb76ffa79c90a8833084a9bd
OS | Windows 11 Version 23H2 (Build 22631.4391)

Channel information

Reproducibility

Miscellaneous information

@aguscruiz @rebron @fallaciousreasoning

cc: @brave/qa-team

DarkLordGeo commented 1 week ago

Hello @MadhaviSeelam , thank you for noticing and reporting this bug! I'd like to work on this issue. Could you please assign it to me? Let me know if there are any specific guidelines or considerations I should follow while working on it.

fallaciousreasoning commented 1 week ago

Go for it @DarkLordGeo - we generally follow Chromium's style guide.

DarkLordGeo commented 1 week ago

Hi, I noticed that I’ve been assigned an issue to work on, but I’m unable to access the repository's source code. It seems like I don’t have the necessary permissions. Could you please confirm if I should have access and, if so, grant the required permissions? Thanks!

fallaciousreasoning commented 1 week ago

Ah, the source code is completely public, its just in a different repo: https://github.com/brave/brave-core/

DarkLordGeo commented 1 week ago

Okay, thank you very much.