search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.94k stars 2.35k forks source link

[ads] Add SmartNTT numerical condition matcher defaults #42321

Closed tmancey closed 6 days ago

LaurenWags commented 3 days ago

Requires 1.73.91 or higher for verification 👍🏻

btlechowski commented 2 days ago

Verified with

Brave 1.73.91 Chromium: 131.0.6778.85 (Official Build) (64-bit)
Revision 35427fa72a008a7e861fa9828e07a0ba2cd46ebd
OS Linux

matcher exists

matcher: ``` "conditionMatchers": [{ "prefPath": "tab_stats.window_count_max", "condition": "[R=]:1" } ], ``` Verified ad was served ![Image](https://github.com/user-attachments/assets/9490a138-24aa-4d9f-9c0c-2142e1867e58)

matcher does not exist - [R]

matcher ``` "conditionMatchers": [{ "prefPath": "tab_stats.window_count_maxFAIL", "condition": "[R=]:0" } ], ``` ![Image](https://github.com/user-attachments/assets/ea71fff5-c482-4d20-95ed-fa6c98e9d618)
btlechowski commented 2 days ago

Verification passed on Brave v1.73.91 on Lenovo TB-8506FS (Android 11.0)

matcher exists

matcher: ``` "conditionMatchers": [{ "prefPath": "tab_stats.window_count_max", "condition": "[R=]:1" } ], ``` Verified ad was served ![Image](https://github.com/user-attachments/assets/43b6fac2-3276-4c4c-b4e7-2f168dd56c23)

matcher does not exist - [R]

matcher ``` "conditionMatchers": [{ "prefPath": "tab_stats.window_count_maxFAIL", "condition": "[R=]:0" } ], ``` ![Image](https://github.com/user-attachments/assets/8e79b3c2-9a76-490a-9d2f-10dd44179a35)