During the course of cr132, we had to add patches/chrome-browser-ui-webui-webui_embedding_context.cc.patch to mark a particular TabInterface pointer as DanglingUntriaged. This is because our sidebar pinning service detaches (but does not delete) tabs and caches their WebContents under certain circumstances. This has the unwanted side effect of creating a dangling pointer in the upstream code that manages the embedded tab
interfaces. We should address the underlying problem with our pinning service and eliminate this patch.
Description
During the course of cr132, we had to add
patches/chrome-browser-ui-webui-webui_embedding_context.cc.patchto mark a particularTabInterfacepointer asDanglingUntriaged. This is because our sidebar pinning service detaches (but does not delete) tabs and caches theirWebContentsunder certain circumstances. This has the unwanted side effect of creating a dangling pointer in the upstream code that manages the embedded tab interfaces. We should address the underlying problem with our pinning service and eliminate this patch.The upstream change that exposed this issue was https://source.chromium.org/chromium/chromium/src/+/bf1f8e50ede83c982c28e7e4254bad871b0c6bf7