search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.94k stars 2.35k forks source link

Opening a Playlist item in a private tab opens it in regular mode the first time #42357

Closed kylehickinson closed 2 days ago

kylehickinson commented 3 days ago

Description

In the new Playlist UI if try to open an item in a private tab via the long press menu, the first time you do this the tab is opened in regular mode despite the correct private flag being passed in when creating the Tab

Steps to reproduce

  1. Prefix: Have an item in Playlist
  2. Open Playlist and long press on an item and tap "Open in Private Tab"

Actual result

The tab is opened in regular mode anyways, but only the first time you do it.

Expected result

Should open in private mode

Reproduces how often

Easily reproduced

Brave version

1.71+

Device/iOS version

N/A

Affected browser versions

Reproducibility

Miscellaneous information

No response

kjozwiak commented 2 days ago

The above requires 1.73.91 or higher for 1.73.x verification 👍

hffvld commented 20 hours ago

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 / iOS 17.7.1
Brave build: 1.73 (91)
BraveCore: 1.73.91 (131.0.6778.85)

STEPS:

  1. Follow the STR/TP from https://github.com/brave/brave-browser/issues/42357#issue-2669751695
  2. Verify

ACTUAL RESULTS:

https://github.com/user-attachments/assets/d0041f80-308b-4c49-b44a-7496888cee52