brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.95k stars 2.35k forks source link

Make sure Sparkle and Omaha 4 never update Brave at the same time #42365

Open mherrmann opened 6 days ago

mherrmann commented 6 days ago

We are in the process of migrating Brave's auto-update mechanism on macOS from the Sparkle update framework to Omaha 4 (a.k.a. "Chromium Updater").

The rollout of the new implementation will proceed gradually. We are controlling with a feature flag which percentage of users should use Omaha 4 vs. Sparkle.

This means that, until the transition to Omaha 4 is complete, Brave will include both Sparkle and Omaha 4.

The goal of this issue is to prevent Sparkle and Omaha 4 from trying to update Brave at the same time. As of this writing, the implementation does not do this. Once the user has been switched to Omaha 4, Omaha 4 forevermore checks for updates in the background. If the feature flag gets switched off to use the Sparkle implementation again, then both Sparkle and Omaha 4 will check for updates. This should be prevented.