search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.94k stars 2.35k forks source link

Crash inside BraveActivity related to quick search #42380

Closed SergeyZhukovsky closed 2 days ago

SergeyZhukovsky commented 2 days ago

I see it on nightly 1.75.18, but that code exists in beta channel as well. We need to uplift it to beta. There are no STR, most likely that happens when the main activity is destroyed or finishing. Just make sure quick search engines is visible for verification.

Exception android.view.WindowManager$BadTokenException:
  at android.view.ViewRootImpl.setView (ViewRootImpl.java:1823)
  at android.view.WindowManagerGlobal.addView (WindowManagerGlobal.java:600)
  at android.view.WindowManagerImpl.addView (WindowManagerImpl.java:150)
  at org.chromium.chrome.browser.app.BraveActivity.showQuickActionSearchEnginesView (BraveActivity.java:2559)
  at org.chromium.chrome.browser.app.BraveActivity.onKeyboardOpened (BraveActivity.java:2598)
  at org.chromium.chrome.browser.util.KeyboardVisibilityHelper$1.onGlobalLayout (KeyboardVisibilityHelper.java:40)
  at android.view.ViewTreeObserver.dispatchOnGlobalLayout (ViewTreeObserver.java:1165)
  at android.view.ViewRootImpl.performTraversals (ViewRootImpl.java:4658)
  at android.view.ViewRootImpl.doTraversal (ViewRootImpl.java:3345)
  at android.view.ViewRootImpl$TraversalRunnable.run (ViewRootImpl.java:11437)
  at android.view.Choreographer$CallbackRecord.run (Choreographer.java:1690)
  at android.view.Choreographer$CallbackRecord.run (Choreographer.java:1699)
  at android.view.Choreographer.doCallbacks (Choreographer.java:1154)
  at android.view.Choreographer.doFrame (Choreographer.java:1080)
  at android.view.Choreographer$FrameDisplayEventReceiver.run (Choreographer.java:1647)
  at android.os.Handler.handleCallback (Handler.java:958)
  at android.os.Handler.dispatchMessage (Handler.java:99)
  at android.os.Looper.loopOnce (Looper.java:230)
  at android.os.Looper.loop (Looper.java:319)
  at android.app.ActivityThread.main (ActivityThread.java:9063)
  at java.lang.reflect.Method.invoke
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:588)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1103)