search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.94k stars 2.35k forks source link

Per-site farbling in Workers follow up #42427

Open goodov opened 22 hours ago

goodov commented 22 hours ago

Follow up for https://github.com/brave/brave-browser/issues/28904

Sometimes the farbling data is not filled for the worker to use.

https://share.backtrace.io/api/share/fJjuE6decKFSnZCe5WkTF2

[ 00 ] crash_reporter::DumpWithoutCrashing() ( crashpad.cc:267 )
[ 01 ] base::debug::DumpWithoutCrashing(base::Location const&, base::TimeDelta) ( dump_without_crashing.cc:108 )
[ 02 ] WorkerContentSettingsClient_BraveImpl::GetBraveShieldsSettings(content_settings::mojom::ContentSettingsType) ( worker_content_settings_client.cc:81 )
[ 03 ] brave::BraveSessionCache::From(blink::ExecutionContext&) ( brave_session_cache.cc:236 )
[ 04 ] brave::GetBraveFarblingLevelFor(blink::ExecutionContext*, content_settings::mojom::ContentSettingsType, brave_shields::mojom::FarblingLevel) ( brave_session_cache.cc:157 )
[ 05 ] brave::AllowFingerprinting(blink::ExecutionContext*, content_settings::mojom::ContentSettingsType) ( brave_session_cache.cc:165 )
[ 06 ] blink::NavigatorBase::userAgent() const ( navigator_base.cc:71 )
[ 07 ] blink::(anonymous namespace)::v8_worker_navigator::UserAgentAttributeGetCallback(v8::FunctionCallbackInfo<v8::Value> const&) ( v8_worker_navigator.cc:472 )
...

Origin: https://acrobat.adobe.com/. Worker URL: https://acrobat.adobe.com/dc-rendition-provider/AJS/build/acrobatProxy_we.58d85e1af147ae738317.js.

Most likely this is similar to https://github.com/brave/brave-browser/issues/41889

goodov commented 18 hours ago

Reproduced by installing https://chromewebstore.google.com/detail/google-docs-offline/ghbmnnjooekpmoecnnnilnnbdlolhkhi and opening a document on https://docs.google.com with offline mode enabled