brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.98k stars 2.35k forks source link

No internet error page is landed and classified as `2xx` #42574

Open btlechowski opened 3 days ago

btlechowski commented 3 days ago

Description

Some error pages are classified as 2xx in landed confirmation request. Probably most encountered one is No internet

Steps to reproduce

  1. Enable rewards
  2. View an ad
  3. Turn off internet
  4. Click the ad
  5. Wait for it to land

Actual result

The error page is landed The error page is classified as 2xx in the confirmation

Image

Confirmation

[30288:30288:1128/013009.451093:VERBOSE1:redeem_reward_confirmation.cc(84)] Redeem reward confirmation
[30288:30288:1128/013009.454076:VERBOSE1:redeem_reward_confirmation.cc(99)] Create reward confirmation
[30288:30288:1128/013009.454116:VERBOSE6:redeem_reward_confirmation.cc(103)] URL Request:
  URL: https://anonymous.ads.bravesoftware.com/v3/confirmation/34d06918-cd73-4e17-84f8-b1c06e93082b/eyJzaWduYXR1cmUiOiIwVGlJOFNuNng4OGxUVmx5SVcxQnQ3OVY3ZmFqdlV2QW9sb3JteUpVclhVdFc1bURXcG12NnVVbDVoaDA1VitWVWpudFVmTEllMW9pa3lJbjBuazhSUT09IiwidCI6InF5RHZEZTc0V1l3Y2JhOUJVbTJDaGo3MmJXYk1ZbUhzTXZaMTBxTVVvVVliSG9LanVEak5CQUdBeWpxbWFwZXM2UGFiMFFBbWViNy9vVlFiYWpkVVpBPT0ifQ==
  Content: {"blindedPaymentTokens":["xKWiaOqZlrkP0GTvf4GCOrjjPykghz7hVf0WpJj5QQg="],"buildChannel":"beta","catalog":[{"id":"8fdb249064646ae0d63c53a6ed9f0f0747b46da9"}],"createdAtTimestamp":"2024-11-28T00:00:00.000Z","creativeInstanceId":"e4958d00-e35c-4134-a408-1fbcf274d5ae","httpResponseStatus":"2xx","platform":"linux","publicKey":"hLaC3RQw5++hx8zaT+47CA8r8cOlAm+ygeky/ci6T1s=","rotatingHash":"ioE5IDfLIygyzmrlYQLPzjkAKF+UMHgh43CE8CRnFzY=","segment":"untargeted","studies":[],"systemTimestamp":"2024-11-28T00:00:00.000Z","transactionId":"34d06918-cd73-4e17-84f8-b1c06e93082b","type":"landed","versionNumber":"131.0.6778.85"}

Expected result

The error page is not landed

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave 1.74.13 Chromium: 131.0.6778.85 (Official Build) beta (64-bit)
Revision 3cb237ea4b804e01c49a0a6d56f84b3c395a1d31
OS Linux

cc @tmancey @aseren @iambrianfung

btlechowski commented 3 days ago

There are other error pages with the same behavior:

Image Image Image