search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
18k stars 2.36k forks source link

Follow Up [to PR 26189] - Taskbar tray icon is not shown active state when VPN is connected #42635

Open MadhaviSeelam opened 1 day ago

MadhaviSeelam commented 1 day ago

Description

Found while testing https://github.com/brave/brave-core/pull/26189. After enabling VPN via Brave VPN card widget, taskbar tray icon is still shown in disconnected state and green checkmark is not shown. However, if VPN is in 1can't connect to server1 error state, taskbar tray icon shown red warning icon is shown

Steps to reproduce

  1. Install 1.75.55
  2. launch Brave
  3. log in VPN as an existing user (account.bravesoftware.com)
  4. disable VPN
  5. disconnect WiFi
  6. enable VPN via Brave VPN card widget in the NTP
  7. VPN icon in the toolbar and taskbar tray icon is shown red warning icon
  8. reconnect WiFi

Actual result

taskbar tray icon is not shown green checkmark and is disconnected state

https://github.com/user-attachments/assets/fbdb2541-9bdc-4354-b0e3-54cc75c2586e

Expected result

Taskbar VPN tray icon should show green icon and should be in connected state

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave 1.75.55 Chromium: 131.0.6778.85 (Official Build) nightly (64-bit)
Revision 3cc3ba11608e3bbbf9e053bdd032ec05e2a4db7f
OS Windows 11 Version 23H2 (Build 22631.4460)

Channel information

Reproducibility

Miscellaneous information

@simonhong @rebron cc: @brave/qa-team

simonhong commented 22 hours ago

@MadhaviSeelam Can you check that tray icon is nightly's? I tested on my Win11 with latest 1.75.69 and tray icon show proper icon. If that tray icon is from another channel(such as stable), it doesn't react other channel's connect state. We have an issie https://github.com/brave/brave-browser/issues/36327 for this issue.

MadhaviSeelam commented 1 hour ago

@MadhaviSeelam Can you check that tray icon is nightly's? I tested on my Win11 with latest 1.75.69 and tray icon show proper icon. If that tray icon is from another channel(such as stable), it doesn't react other channel's connect state. We have an issie #36327 for this issue.

@simonhong - No there is no release channel. I've uninstalled and removed any existing VPN processes. It's just not showing connected state but it does error state and disconnected state.