search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.54k stars 2.27k forks source link

Download checks for SafeBrowsing should go through Tor. #4290

Open jumde opened 5 years ago

jumde commented 5 years ago

We are disabling SafeBrowsing in Tor, since download checks are not going through Tor. Re-enable SafeBrowsing once the issue is addressed.

diracdeltas commented 5 years ago

note this is blocked on https://github.com/brave/brave-browser/issues/4341 (making sure the sb download implementation is sufficiently private)

LaurenWags commented 1 month ago

I'm seeing a message to enable Safe Browsing when downloading from a Tor window, will that go away once this is issue is fixed?

Screenshot 2024-08-16 at 4 28 40 PM

Occurs with both 1.69.x (RC) and 1.68.x, so doesn't seem to be a new thing.

fmarier commented 1 month ago

I'm seeing a message to enable Safe Browsing when downloading from a Tor window, will that go away once this is issue is fixed?

Maybe, but I think we should suppress that warning in the meantime and so that would be a meaningful issue to file.

LaurenWags commented 4 weeks ago

thanks @fmarier - logged https://github.com/brave/brave-browser/issues/40529 for suppressing the warning