Users should be able to scroll FDQNs in scripts detail view

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.

https://brave.com

Mozilla Public License 2.0

17.62k stars 2.29k forks source link

Users should be able to scroll FDQNs in scripts detail view #4574

Open cezaraugusto opened 5 years ago

cezaraugusto commented 5 years ago

Task split of https://github.com/brave/brave-browser/issues/2996

When looking at the scripts detail view, we should enable horizontal scrolling so that someone can see the full FQDN.

If it's longer than the content area, the additional text to the left of the registered domain (ETLD+1) is initially truncated as an ellipses. In this new design, we do not show the path or "https://" at all. Only the full FQDN or (...)(registered domain) is shown.

cezaraugusto commented 5 years ago

needs https://github.com/brave/brave-core/pull/2485

kjozwiak commented 5 years ago

Removed 0.67.x - Dev as this issue hasn't been closed/completed and still needs to land in nightly. @cezaraugusto once the PR for this issue lands in nightly, let's add all needed labels and move the issue into the appropriate milestone at that point 👍

tildelowengrimm commented 5 years ago

So on reflection, we should probably use this hierarchy:

If scheme and host fit in view, start with that showing.
Else if ETLD+1 fits in view, start with that showing.
Else start with ETLD in view.

Which I think more or less means right-aligning by the right edge of the ETLD?