search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.84k stars 2.33k forks source link

Have a "hold to actually close" keyboard shortcut for pinned tabs #4963

Open bsclifton opened 5 years ago

bsclifton commented 5 years ago

Description

Currently, pinned tabs can be closed with Ctrl+W / Cmd+W, and we've clarified this is the intended behavior.

A Chrome user recently suggested that we could have a "Hold X to close", similar to the Chrome/Chromium default behavior for Ctrl+Q/Cmd+Q for quit. It would look something like this: image

Steps to Reproduce

  1. Fresh profile
  2. Visit a site
  3. Right click tab, pick Pin Tab
  4. Go into pinned tab
  5. Hit Ctrl+W or Cmd+W

Actual result:

Pinned tab closes ☹️

Expected result:

User should have to hold shortcut to close

Reproduces how often:

100%

Brave version (brave://version info)

Brave 0.68.56 Chromium: 75.0.3770.90 (Official Build) nightly(64-bit)
Revision a6dcaf7e3ec6f70a194cc25e8149475c6590e025-refs/branch-heads/3770@{#1003}
OS Mac OS X
rebron commented 5 years ago

https://github.com/brave/brave-browser/issues/4988#issue-458162978 Approach to solve inadvertently closing pinned tabs via ignoring CMD + W pref, might be a good way to go to instead of a warning.

rebron commented 5 years ago

cc: @rossmoody

eljuno commented 4 years ago

+1 from Community https://community.brave.com/t/possibly-quick-ux-improvement-for-pinned-tabs/99549?u=eljuno

ibwoo commented 4 years ago

+1 from me - a great idea that would be very helpful!

yuujay commented 4 years ago

+1. It gets little annoying when a pinned tab gets closed accidentally. Would be a very helpful UX improvement.

iQuery-001 commented 4 years ago

+1 from me yes please

yigitkonur commented 4 years ago

+1

radiosilence commented 4 years ago

Much prefer the preference option. Often pinned tabs are closed when you spam/hold Cmd+W so having a message would probably be ineffective. What exactly is the point of pinning of they are so easy to close?

Someone suggested restoring the tab, but if you're like me and have a mix open on SoundCloud or whatever, it doesn't restore the playback.

dvcrn commented 3 years ago

I like the idea of having a setting to disable ever closing pinned tabs, similar to how safari is doing it. You can still right-click and then hit "close", but pinned tabs should be pinned until they are explicitly unpinned.

Hitting CMD-W on a pinned tab, if that tab is the last tab, should just close the browser window and leave the tab as is.

thebatvic commented 3 years ago

+1 from me. It's already in WIP or it is still not take yet?

gustavotrott commented 1 year ago

I created an extension as a workaround to prevent pinned tabs from being closed accidentally:

https://github.com/gustavotrott/brave-lock-pinned-tabs

Feel free to use if it can help you guys to tackle this issue!

ricardoprato commented 1 week ago

+1