brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.8k stars 2.33k forks source link

Add social blocking toggle for YouTube embeds #4986

Open tildelowengrimm opened 5 years ago

tildelowengrimm commented 5 years ago

Along with the other social media blocking features, add an off-by-default option to block YouTube embeds.

ryanbr commented 5 years ago

I'd expect people submitting false positives, i.e forgetting this was enabled and then complaining issues of youtube issues.

ryanbr commented 5 years ago

One would also argue, why not other embedded video sources also? or are we specifically picking on youtube? anyway, my thoughts :)

fmarier commented 5 years ago

I added YouTube embeds on my test page: https://fmarier.github.io/brave-testing/social-widgets.html

tildelowengrimm commented 5 years ago

@ryanbr Your point about other embeds is well-taken. We'd like to make it easy to control whatever cross-site activity you'd like to limit. But you're far more likely to stumble over a YouTube embed than any other, so it makes sense to build that control first.

fmarier commented 5 years ago

The new Firefox "Social Tracking Protection" feature is now enabled by default in Nightly:

Screenshot from 2019-08-13 13-53-17

and blocks Facebook, LinkedIn, Twitter and YouTube.

ryanbr commented 5 years ago

Something like this:

[*]  Ads
     [ ] First party ads  (https://easylist.to/easylist/easylist.txt)

[*] Tracking              (https://easylist.to/easylist/easyprivacy.txt)
    [ ] First party Tracking
    [ ] Coin mining
    [ ] 3rd-party Font Tracking 

[*] Social Filters        (https://easylist-downloads.adblockplus.org/fanboy-social.txt)
    [ ] Strict blocking of social domains

[*] Web Annoyances        (https://easylist-downloads.adblockplus.org/fanboy-annoyance.txt)

[*] Cookie Filters        (https://fanboy.co.nz/fanboy-cookiemonster.txt)

We support all of these lists in Easylist / Easylist authors.

fmarier commented 4 years ago

This will likely be a similar PR to https://github.com/brave/brave-core/pull/3784.

iefremov commented 4 years ago

+1 for covering other video sources along with YouTube - this can possibly fix https://github.com/brave/adblock-lists/pull/275