brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.55k stars 2.28k forks source link

WebTorrent: Should not show "Autoplay was blocked" #5359

Open feross opened 5 years ago

feross commented 5 years ago

Description

The WebTorrent extension is provided by the Brave browser, so it's kind of silly for the browser to display a notification that autoplay has been blocked.

Steps to Reproduce

  1. Go to https://webtorrent.io/free-torrents
  2. Click on Big Buck Bunny (torrent file)
  3. Start download
  4. Right click on "Big Buck Bunny.mp4" and "Open Link in New Tab" (to workaround #3966)
  5. The browser shows a notification about blocking autoplay.

Actual result:

Screen Shot 2019-07-23 at 3 49 02 PM

Expected result:

Either we should:

  1. Successfully autoplay the video, or
  2. Not attempt autoplay if the browser is going to block it, or
  3. Start autoplaying with the audio muted (this will not be blocked).

Does anyone on the Design team have feedback on which choice is best? I lean toward option 1, as that's what we did in the past (until it stopped working with the Chrome Autoplay policy changes)

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Version 0.66.101 Chromium: 75.0.3770.142 (Official Build) (64-bit)

Version/Channel Information:

yrliou commented 5 years ago

Talked to @feross before that the fix was incomplete since we could still reproduce it, so reopen this issue and remove its milestone for now.

feross commented 5 years ago

@yrliou Sounds good. Thanks for reopening this.

rebron commented 4 years ago

@yrliou This issue should no longer be valid due to #8408