brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.68k stars 2.31k forks source link

Block Scripts by Origin (first party / third party) #538

Open tildelowengrimm opened 6 years ago

tildelowengrimm commented 6 years ago

We should provide a Shields UX which makes it easy to select which scripts to enable or block. In particular, we should allow users to decide whether they want to block all scripts on a page, or only scripts from third parties.

Replaces brave/browser-laptop#11617

bbondy commented 6 years ago

I think we already have this, implemented by @yrliou. I think we need to tweak the UX eventually but probably not before the main September milestone.

tildelowengrimm commented 6 years ago

I don't see it in the test builds. Is it located somewhere non-obvious?

bbondy commented 6 years ago

maybe not so obvious but you can scroll on the shields panel down

bsclifton commented 5 years ago

Closing as this is implemented 😄

tildelowengrimm commented 5 years ago

I think that what's implemented right now (in both old-style and new-style panels) is the ability to block scripts and re-enable specific scripts. I don't see the ability to pick block all scripts|block 3rd party scripts|don't block scripts. Maybe I'm just totally missing it, but I'm going to re-open this until I actually see this. Can y'all confirm @yrliou @cezaraugusto?