brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.58k stars 2.28k forks source link

Cryptowallets should not be allowed to work on Tor Windows #5723

Closed srirambv closed 5 years ago

srirambv commented 5 years ago

Description

Cryptowallets should not be allowed to work on Tor Windows

Steps to Reproduce

  1. Install Dev/Nightly build
  2. Create a crypto wallet in normal window
  3. Open Tor window, type in brave://wallet, opens wallet creation page and you are able to create a second wallet on tor windows

Actual result:

image

Expected result:

Should not allow creating a wallet on Tor window similar to Private/Guest window

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.70.68 Chromium: 76.0.3809.100 (Official Build) dev (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Linux

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

cc: @bbondy

GeetaSarvadnya commented 4 years ago

Verification passed on

Brave 0.70.109 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Verification passed on

Brave 0.70.109 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Ubuntu 18.04 LTS

Verified passed with

Brave 0.70.110 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.13.6 (Build 17G5019)