brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.92k stars 2.34k forks source link

Remove `Dashboard Settings` tool tip for each stats #6084

Open GeetaSarvadnya opened 5 years ago

GeetaSarvadnya commented 5 years ago

Description

Remove Dashboard Settings tool tip for each stats

Steps to Reproduce

  1. Open brave 0.70.97
  2. Open NTP click on the Dashboard settings icon
  3. Mouseover each stats in the dashboard setting popup
  4. Dashboard Settings tooltip is shown for each stats

Actual result:

Mouseover on each stats shows Dashboard Settings tooltip

image (1)

image

Expected result:

Remove Dashboard Settings tooltip for each stats

Reproduces how often:

Always

Brave version (brave://version info)

Brave 0.70.97 Chromium: 77.0.3865.65 (Official Build) beta (64-bit)
Revision 87a331a3169cab563505fb44011058b904011ba1-refs/branch-heads/3865@{#726}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

@brave/legacy_qa @karenkliu

btlechowski commented 4 years ago

Still reproducible

Brave 1.13.82 Chromium: 85.0.4183.83 (Official Build) (64-bit)
Revision 94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
OS Ubuntu 18.04 LTS

image

otomist commented 2 years ago

I'm going to get started on this. Just to be sure we want this totally removed? Or should the tooltip say something different? @rebron

ForkInSpace commented 2 years ago

@GeetaSarvadnya if this is still relevant, I'm happy to create a PR for this one.

ryanstutes commented 1 year ago

@GeetaSarvadnya I think the desired behavior should be as follows:

I'm going to open a PR for these. If we don't want both of them, happy to revert the 2nd half.

AlejandroBlanco2001 commented 9 months ago

Hey @GeetaSarvadnya @btlechowski , I was seeing that the issue had a PR but it was closed, and I would like to know if it is still relevant and I can take it?

My only question is, only the tooltip should be removed only from the options, in the rest of the modal it should remain right?

Sriramkashyapks commented 8 months ago

please assign this issue to me