search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.67k stars 2.31k forks source link

add support for wayland on linux #6212

Open LastLightSith opened 5 years ago

kylew01 commented 5 years ago

I second that! I love using Brave on Linux, but with fractional scaling everything is blurry.

fmarier commented 4 years ago

There is work upstream to make Wayland on Linux a fully-supported platform: https://groups.google.com/a/chromium.org/d/topic/chromium-dev/-B8JhTojOtM/discussion

pswu11 commented 4 years ago

I also just started to use Brave and it's amazing. But without wayland support it looks very blurry. It would be perfect to have web3.0 browser with native wayland support. Thank you!

Isselbaecher commented 4 years ago

I support this feature request! :)

fuzunspm commented 4 years ago

Please support wayland!

tsujp commented 4 years ago

+1 not supporting wayland means I am going back to Chromium.

EDIT: I gun goofed up

yavorski commented 4 years ago

@tsujp I don't think chrome or chromium supports wayland yet. The issue in the chromium repo is still open https://bugs.chromium.org/p/chromium/issues/detail?id=578890 Anyway you can go back and forward to whatever you want :)

tsujp commented 4 years ago

@yavorski I stand corrected, you are right the Chromium build from extra is indeed using XWayland (used xeyes to check). My mistake there.

Might play around with that and Brave then :)

LastLightSith commented 4 years ago

@tsujp if u are using arch or manjaro, try chromium-ozone from AUR or prebuilt binary from chaotic-aur repo. Its quite usable

tsujp commented 4 years ago

@SmitTheTux solid recommendation chromium-ozone is running even better; so smooth.

rohitghali commented 4 years ago

+1 for this. I use full wayland, and I love brave. I want to use it in wayland too.

eljejer commented 4 years ago

+1 for this. I use full wayland, and I love brave. I want to use it in wayland too.

Ella-0 commented 4 years ago

+1 for this. I use full wayland, and I love brave. I want to use it in wayland too.

DrSh4dow commented 4 years ago

+1 this is most likely a needed feature

Ella-0 commented 4 years ago

Yeah especially as upstream chromium is getting more and more support for it.

fourstepper commented 3 years ago

Did anyone try the dev/nightlies for the Wayland support?

kcalvelli commented 3 years ago

Did anyone try the dev/nightlies for the Wayland support?

I've been running Nightly (1.18.37) in a Wayland session on Plasma 5.20 today and seems to be working okay so far. Using Exec=/usr/bin/brave-browser-nightly --enable-features=UseOzonePlatform --ozone-platform=wayland in my desktop file to launch. PWAs are a little weird, as they get a system title bar and don't use the GTK theme (so get two sets of close buttons). Brave Together works, but cannot share screen or app window (only browser tab).

Ella-0 commented 3 years ago

I've been trying out the nightly too and it seams to work really well. As for the screen recording issues @kcalvelli mentioned. I don't think this is a Brave issue and more likely that pipewire hasn't been setup in the correct way which is very easy to do. It took me ages to get pipewire working properly with sway. I'm able to get all pipewire application windows and the desktop using xdg-desktop-portal-wlr

fourstepper commented 3 years ago

I am on GNOME, Wayland seems to work on the new release but the window each window is not being propagated to the panel, so I cannot switch apps with my keyboard shortcuts

NullSense commented 3 years ago

@Ella-0 I have pipewire set up to work on chromium and firefox, but it doesn't seem to work with the latest nightly and wayland enabled.

fourstepper commented 3 years ago

@NullSense what is the indication that pipewire doesn't work for you? What version are you on?

NullSense commented 3 years ago

@fourstepper 

❯ pacman -Qs pipewire
local/libpipewire02 0.2.7-1
local/pipewire 0.3.15-2

Update: screen sharing seems to only work on firefox, but not on chromium or brave (the pipewire flag is enabled).

fourstepper commented 3 years ago

Are you talking about screen sharing of the whole desktop, window or tabs?

NullSense commented 3 years ago

Are you talking about screen sharing of the whole desktop, window or tabs?

The whole desktop, windows don't work, only sharing tabs works.

fourstepper commented 3 years ago

I can reproduce that as well

NullSense commented 3 years ago

I can reproduce that as well

https://wiki.archlinux.org/index.php/PipeWire#WebRTC_screen_sharing According to the Arch wiki, it should be easy to enable like this, but I never got it working.

fourstepper commented 3 years ago

Didn't read the Arch wiki before, but enabling the flag worked for me on GNOME, Fedora in Jitsi Meet

image

NullSense commented 3 years ago

Didn't read the Arch wiki, but enabling the flag worked for me on GNOME in Jitsi Meet

image

Strange, I got it to work if I run these commands:

❯ systemctl --user stop pipewire.service pipewire.socket xdg-desktop-portal.service xdg-desktop-portal-wlr.service
env PIPEWIRE_DEBUG=3 pipewire
/usr/libexec/xdg-desktop-portal-wlr -l DEBUG
/usr/libexec/xdg-desktop-portal --verbose -r

EDIT: worked by restarting the services.

NullSense commented 3 years ago

As another finding: I noticed speed reader does not work on my machine (wayland mode as well), can anyone reproduce?

yavorski commented 3 years ago

Chromium version 87 supports native Wayland with the following flags:

--enable-features=UseOzonePlatform --ozone-platform=wayland
why-not-try-calmer commented 3 years ago

It's not very difficult to launch Brave on on a full wayland session. I am using KDE Plasma 5.21:

$  GDK_BACKEND=wayland (or fish: set GDK_BACKEND x11)
$  brave-browser

Of course it would be much nicer to have native support.

sith-on-mars commented 3 years ago

On my OpenSUSE Tumbleweed, the screen sharing doesn't work. I clicked the button, but nothing happened. I have enabled WebRTC screen sharing and launched Brave with the following command: brave-browser --enable-features=UseOzonePlatform --ozone-platform=wayland. The screen sharing works on Chromium however.

Ella-0 commented 3 years ago

Is chromium running with Wayland?

sith-on-mars commented 3 years ago

Is chromium running with Wayland?

Yes I use Wayland on my OpenSUSE Tumbleweed. I launched Brave with the command brave-browser --enable-features=UseOzonePlatform --ozone-platform=wayland.

WhyNotHugo commented 3 years ago

Is chromium running with Wayland?

It "runs" as of a few stable releases, however, many things are broken.

As of v89 (still no stable release for it), screen sharing works. AFAIK, that's the last feature that's not working on Wayland but working on other platforms.

I think you still need these flags though:

$ cat .config/chromium-flags.conf
--enable-features=UseOzonePlatform --ozone-platform=wayland
borges-filipe commented 3 years ago

I launched Brave with:

brave --enable-features=UseOzonePlatform --ozone-platform=wayland

The mouse cursor becomes tiny but everything else looks crisp even with fractional scaling turned on. I am on Manjaro Gnome using Wayland.

Any way to fix the cursor?

microo8 commented 3 years ago

It works, you can add these flags in .config/brave-flags.conf. No Xwayland is running :) but some sites don't work. eg playing a youtube video :(

maarteNNNN commented 3 years ago

I did brave://flags, searched for wayland and enabled the WebRTC PipeWire support and it worked using Ubuntu 21.04. image

cloudlena commented 3 years ago

I launched Brave with:

brave --enable-features=UseOzonePlatform --ozone-platform=wayland

The mouse cursor becomes tiny but everything else looks crisp even with fractional scaling turned on. I am on Manjaro Gnome using Wayland.

Any way to fix the cursor?

Interesting... For me, the cursor gets huge... But I have scaling set to 2.0.

WhyNotHugo commented 3 years ago

The way fractional scaling works is by rendering larger and then downscaling. E.g.: a 1.5x scaling actually scales to 3x and then downscales that by 50%.

I can't image why 2x scaling would render it larger, but fractional scaling renders it smaller. Unless you're using fractional scaling < 1?

ahydronous commented 3 years ago

@microo8

It works, you can add these flags in .config/brave-flags.conf. No Xwayland is running :) but some sites don't work. eg playing a youtube video :(

Don't say random stuff without testing. I just tried this on Fedora 34 and it did absolutely nothing. I am assuming because you are using Arch, and Arch has a special wrapper for the brave package (see https://github.com/brave/brave-browser/issues/2300)

mielouk commented 2 years ago

This is a key feature for a browser to be used on any distro used in the foreseeable future.

Please support Wayland :crystal_ball:

schmensch commented 2 years ago

Pleeease add this. I think upstream chromium is working on a simple toggle in chrome://flags to toggle Wayland via Ozone.

bound-variable commented 2 years ago

I did brave://flags, searched for wayland and enabled the WebRTC PipeWire support and it worked using Ubuntu 21.04. image

What's this for? I tried it on Arch, and it didn't help loading the browser.

schmensch commented 2 years ago

@Pound-Hash that's not for running Brave Wayland-Native, you can do that with brave --enable-features=UseOzonePlatform --ozone-platform=wayland.

WebRTC PipeWire support is required for screen-sharing on Wayland. It's independent from Ozone.

hugosxm commented 2 years ago

Hi, juste to let you know but on sway, the claim captcha is not working, i have to log off, log on to xfce, claim my bat then come back to sway. Not a big problem but worth noting. Also i would be happy to not use xwayland anymore ^^

fmarier commented 2 years ago

@hugosxm also see https://github.com/brave/brave-browser/issues/20428 for the CAPTCHA issues on Linux

enrico223 commented 2 years ago

I did brave://flags, searched for wayland and enabled the WebRTC PipeWire support and it worked using Ubuntu 21.04. image

I'm on fedora 35, you can also choose Wayland from the "preferred Ozone platform" just to be sure. It works.

DaWe35 commented 1 year ago

I did brave://flags, searched for wayland and enabled the WebRTC PipeWire support and it worked using Ubuntu 21.04. image

OMG this worked, why Brave is unable to detect Wayland automatically?

why-not-try-calmer commented 1 year ago

I did brave://flags, searched for wayland and enabled the WebRTC PipeWire support and it worked using Ubuntu 21.04. image

OMG this worked, why Brave is unable to detect Wayland automatically?

It's the same as with all other Chromium-based browsers.

On that, I think that this thread has outlived its purpose. Brave does fully support Wayland on Linux using the right flags.