brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17k stars 2.21k forks source link

[Desktop] Provide option to "always" open files with system default or provide "do not ask again" option #6291

Open Brave-Matt opened 4 years ago

Brave-Matt commented 4 years ago

Description

As it is now, users can disable Webtorrent in settings and after doing this, the browser will prompt the user after clicking/downloading on a magnet link or torrent file, asking whether or not you'd like to use [System default torrent client] to open the file.

image

However, with this method, users are prompted every time they attempt to download a torrent/magnet file. This can be cumbersome and there should be a way to tell the browser to always default to the users preferred torrent client.

Consideration and Suggestion When adding this feature, there should also be a way to reverse the decision so that users can choose different clients if necessary.

I would suggest adding a couple checkboxes to the UI for the simplest implementation (plz excuse the hasty shop job): ask

And in Settings --> Extensions: wt

cc @yrliou @rebron

bencefalo commented 4 years ago

It would be great if when this is fixed its fixed for other apps and not just torrent... like zoom.us and webex. You are prompted every time to open zoom when browser from a zoom meeting

Epictetos commented 4 years ago

Yes please, we shouldn't have to click yes or no every single time we download a torrent.

kartsims commented 4 years ago

Weirdly, one of my Brave sessions (as in "signed-in as another user") provides this feature. When I click a torrent, it directly opens it with my default app.

I don't know how to apply this option to the other session, but it should be possible.

Brave-Matt commented 4 years ago

I have a user reporting the same situation, but its related to different external apps (in this users case, Roblox). I think it's worth extending this particular option to include any/all external apps. https://www.reddit.com/r/brave_browser/comments/ecvgjb/this_makes_me_wanna_switch_back_to_chrome/

Brave-Matt commented 4 years ago

Another +1 from a user opening MS Excel files: https://www.reddit.com/r/brave_browser/comments/es8vkt/is_there_any_way_of_avoiding_this_prompt_every/

Brave-Matt commented 4 years ago

+1 from Reddit: https://www.reddit.com/r/brave_browser/comments/eswbcb/can_not_get_brave_to_use_torrent_client/

Sntl09 commented 4 years ago

Yeah, sorry but this is where Brave lost me and i've uninstalled. It seemed like a great browser but the torrenting issue is a deal breaker for me. +1 to sort this

eloquentvogon commented 4 years ago

I use Zoom multiple times a day and I too need a "Don't ask again" option

Brave-Matt commented 4 years ago

Very similar +1: https://community.brave.com/t/i-need-help-with-a-thing/107346

Brave-Matt commented 4 years ago

Another similar +1: https://www.reddit.com/r/brave_browser/comments/f3d78s/how_can_i_stop_brave_from_still_asking_if_it/

Brave-Matt commented 4 years ago

+1 from Community: https://community.brave.com/t/remember-my-choice-when-websites-want-to-open-applications/114589

michelle911 commented 4 years ago

+1, I too am forced to use another browser that allows this functionality, but like Brave better - please fix!

pratyushtewari commented 4 years ago

With more apps using the web url mechanism to open the desktop apps, e.g. Zoom, hangouts, download manager, email app, etc please consider "always allow" or "remember this app" feature.

Brave-Matt commented 4 years ago

+1 from Reddit: https://www.reddit.com/r/brave_browser/comments/g09f6a/how_do_i_get_brave_to_stop_asking_for_permission/

eljuno commented 4 years ago

+1 from Community

https://community.brave.com/t/configure-brave-to-use-transmission-for-magnet-links/120235?u=eljuno

benwoodward commented 4 years ago

+1

I have this issue with "Add to Things 3"

image

Xan-Kun commented 4 years ago

+1 No Skype for Business = No Brave Sadly

ramonsmits commented 4 years ago

Zoom, Torrents, Git, etc. it all is SO annoying that I can't just select "Don't ask again for this domain".

ramonsmits commented 4 years ago

Also, can the title and labeling be adjusted? Its not only for Torrents but for all applications.

ramonsmits commented 4 years ago

Title suggestion

Feature Request: Support ExternalProtocolDialogShowAlwaysOpenCheckbox similarly as Edge and Chrome

https://cloud.google.com/docs/chrome-enterprise/policies/?policy=ExternalProtocolDialogShowAlwaysOpenCheckbox

For now, I'm saying goodbye to Brave and hello Chrome until this policy is supported.

bsclifton commented 4 years ago

@ramonsmits the group policy should be supported 100% - you can try via registry. More info at https://support.brave.com/hc/en-us/articles/360039248271-Group-Policy

We don't have proper group policy templates (ADM/ADMX) files available yet though... but you might check out https://github.com/Prowler2/Brave-Browser-GPO-Policy

ramonsmits commented 4 years ago

@bsclifton Thanks for mentioning, searching via Google didn't contain these pages. THis is because they do not mention ExternalProtocolDialogShowAlwaysOpenCheckbox. Based on your comment the following registry file should allow to restore the checkbox again.

Windows Registry Editor Version 5.00

[HKEY_CURRENT_USER\Software\Policies\BraveSoftware\Brave]
"ExternalProtocolDialogShowAlwaysOpenCheckbox"=dword:41000000
markstuart commented 4 years ago

So, you can get this to work on Linux right now... following the info from @bsclifton and @ramonsmits as well as this: https://www.chromium.org/administrators/linux-quick-start I got to this:

sudo mkdir -p /etc/chromium/policies/managed
sudo chmod -w /etc/chromium/policies/managed
sudo touch /etc/chromium/policies/managed/managed_policies.json

Edit the file using whatever you like (I used nano), and insert this json:

{
  "ExternalProtocolDialogShowAlwaysOpenCheckbox": true
}

Go to brave://policy in the Brave address bar, and you should see this policy displaying. Then if you click on a Zoom link or whatever, you should get the checkbox, and not get asked next time.

I guess Brave will possibly stop sharing the config directory with chromium at some point? This may be a short term fix.

My setup: OS: Ubuntu 18.04.4 LTS Brave: Version 1.8.86 Chromium: 81.0.4044.129 (Official Build) (64-bit)

belminf commented 4 years ago

Linux one-liner that worked for me:

sudo mkdir -p /etc/chromium/policies/managed && echo '{"ExternalProtocolDialogShowAlwaysOpenCheckbox": true}' | sudo tee /etc/chromium/policies/managed/protocol_open.json

No need to restart. Just needed to select the checkbox the first time opening a protocol. For e.g., for magnet links:

image

dasforsyth commented 4 years ago

@bsclifton Thanks for mentioning, searching via Google didn't contain these pages. THis is because they do not mention ExternalProtocolDialogShowAlwaysOpenCheckbox. Based on your comment the following registry file should allow to restore the checkbox again.

Windows Registry Editor Version 5.00

[HKEY_CURRENT_USER\Software\Policies\BraveSoftware\Brave]
"ExternalProtocolDialogShowAlwaysOpenCheckbox"=dword:41000000

I found the above didn't work for me, but the below did:


[HKEY_LOCAL_MACHINE\SOFTWARE\Policies\BraveSoftware\Brave]
"ExternalProtocolDialogShowAlwaysOpenCheckbox"=dword:1
kmf commented 4 years ago

For MacOS defaults write com.brave.Browser ExternalProtocolDialogShowAlwaysOpenCheckbox -bool true

Xan-Kun commented 4 years ago

@dasforsyth I can confirm ;-) Works for me too! hooray

lilleyen commented 4 years ago

Linux one-liner that worked for me:

sudo mkdir -p /etc/chromium/policies/managed && echo '{"ExternalProtocolDialogShowAlwaysOpenCheckbox": true}' | sudo tee /etc/chromium/policies/managed/protocol_open.json

No need to restart. Just needed to select the checkbox the first time opening a protocol. For e.g., for magnet links:

image

This worked perfectly for me. Linux Mint 19.3 Thank you, thank you!!

Brave-Matt commented 4 years ago

We have a Windows user here who seems to have a found a solution to the issue as well: https://community.brave.com/t/unable-to-remove-confirmation-dialog-on-external-protocol-handler/120826

fharper commented 4 years ago

@kmf solution works for me on macOS, thanks. Note that you need to restart the browser.

BryanChung commented 4 years ago

As of now, I cannot find those Windows registry entries in my system. not sure why. I am on Brave V1.10.97 on Windows 10. Any idea why?

bsclifton commented 4 years ago

@BryanChung you'd have to create the registry structure for them to show up

As shared above, you can make a new file called brave.reg (or similar) and put the following in there:

[HKEY_LOCAL_MACHINE\SOFTWARE\Policies\BraveSoftware\Brave]
"ExternalProtocolDialogShowAlwaysOpenCheckbox"=dword:1

After saving that, you can double click the .reg file and it'll add the entry. Let us know if that solves the issue for you 😄

BryanChung commented 4 years ago

@BryanChung you'd have to create the registry structure for them to show up

As shared above, you can make a new file called brave.reg (or similar) and put the following in there:

[HKEY_LOCAL_MACHINE\SOFTWARE\Policies\BraveSoftware\Brave]
"ExternalProtocolDialogShowAlwaysOpenCheckbox"=dword:1

After saving that, you can double click the .reg file and it'll add the entry. Let us know if that solves the issue for you 😄

Oh! I needed to create one rather than finding it. Haha! Ok thanks!

apennismightier commented 4 years ago

@BryanChung you'd have to create the registry structure for them to show up As shared above, you can make a new file called brave.reg (or similar) and put the following in there:

[HKEY_LOCAL_MACHINE\SOFTWARE\Policies\BraveSoftware\Brave]
"ExternalProtocolDialogShowAlwaysOpenCheckbox"=dword:1

After saving that, you can double click the .reg file and it'll add the entry. Let us know if that solves the issue for you smile

Oh! I needed to create one rather than finding it. Haha! Ok thanks! @BryanChung @bsclifton

That directory doesn't exist in either the HKEY_LOCAL_MACHINE or the HKEY_CURRENT_USER for me. I'm on:

Version 1.10.97 Chromium: 83.0.4103.116 (Official Build) (64-bit) Windows 8.1

BryanChung commented 4 years ago

@BryanChung you'd have to create the registry structure for them to show up As shared above, you can make a new file called brave.reg (or similar) and put the following in there:

[HKEY_LOCAL_MACHINE\SOFTWARE\Policies\BraveSoftware\Brave]
"ExternalProtocolDialogShowAlwaysOpenCheckbox"=dword:1

After saving that, you can double click the .reg file and it'll add the entry. Let us know if that solves the issue for you smile

Oh! I needed to create one rather than finding it. Haha! Ok thanks! @BryanChung @bsclifton

That directory doesn't exist in either the HKEY_LOCAL_MACHINE or the HKEY_CURRENT_USER for me. I'm on:

Version 1.10.97 Chromium: 83.0.4103.116 (Official Build) (64-bit) Windows 8.1

Yeah we need to create the directory. :) You can use mine.

brave.zip

Don't blame me if it breaks. :P

xodotLBO commented 3 years ago

@BryanChung you'd have to create the registry structure for them to show up As shared above, you can make a new file called brave.reg (or similar) and put the following in there:

[HKEY_LOCAL_MACHINE\SOFTWARE\Policies\BraveSoftware\Brave]
"ExternalProtocolDialogShowAlwaysOpenCheckbox"=dword:1

After saving that, you can double click the .reg file and it'll add the entry. Let us know if that solves the issue for you smile

Oh! I needed to create one rather than finding it. Haha! Ok thanks! @BryanChung @bsclifton

That directory doesn't exist in either the HKEY_LOCAL_MACHINE or the HKEY_CURRENT_USER for me. I'm on: Version 1.10.97 Chromium: 83.0.4103.116 (Official Build) (64-bit) Windows 8.1

Yeah we need to create the directory. :) You can use mine.

brave.zip

Don't blame me if it breaks. :P

Doesn't work for me.

Xan-Kun commented 3 years ago

That directory doesn't exist in either the HKEY_LOCAL_MACHINE or the HKEY_CURRENT_USER for me. I'm on:

Version 1.10.97 Chromium: 83.0.4103.116 (Official Build) (64-bit) Windows 8.1

@apennismightier Yeah, that's why it would have been so important for everybody to post their exact OS :-/ The paths are different, obviously.

Thanks for leading with a good example! :-)

Bargsteen commented 3 years ago

The current solution posted here only works on a per-site basis. It would be great if you could remove the prompt for a specific app for all sites. Context: I am using Org Capture in Emacs to save bookmarks to a file on disk. This is a reasonably common use case for Emacs users :)

aspiers commented 3 years ago

@Bargsteen I have posted a solution for exactly that here :-)

4evermaat commented 3 years ago

I don't understand why this is an "issue" that hasn't been resolved with brave

Snag_240e610d

A lot of brave versions have come out since this was first reported. Where is the checkbox that can store the user's preference? [I prefer to save the .torrent file]

Realistically, how hard is this to implement?

LanceHaverkamp commented 3 years ago

This also affects mailto, which is used by far more people than use torrents.

J-Wick4 commented 3 years ago

I can see this for the first time used for a 3rd party extension, but after that, it should never happen again.

jtoy commented 3 years ago

+1

cprance commented 2 years ago

+1

alik604 commented 2 years ago

id much rather use my qBittorrent which is linked to my VPN interface/adaptor. This is a liability, maybe even malware as it carries a risk of getting me a fine if I act carelessly.

Settings --> Extensions does not have webtorrent, its been moved to Settings - just use the search function. I was able to auto use my default client, qBittorrent. problem solved for me - on windows 10

Xan-Kun commented 2 years ago

Good bye Brave. This is as long as I was willing to wait.

aspiers commented 2 years ago

@Xan-Kun commented on July 1, 2022 3:03 PM:

Good bye Brave. This is as long as I was willing to wait.

What are you waiting for exactly? There are workarounds posted in this issue.

J-Wick4 commented 2 years ago

@Xan-Kun commented on July 1, 2022 3:03 PM:

Good bye Brave. This is as long as I was willing to wait.

What are you waiting for exactly? There are workarounds posted in this issue.

Certain extensions constantly request permission to open a 3rd party app for each domain. It's totally annoying and needs to be adjusted to allow global permissions for all domains after permission is granted the first time. Screen Shot 2022-07-02 at 6 05 19 PM

aspiers commented 2 years ago

The solution for that above has worked great for me for several months on Brave / Chrome / Chromium.

kerim commented 1 year ago

I'm having this problem as well (and don't really understand the solution linked above). Why can't I just permit opening an app across ALL websites once and never have to think about it again?