brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.68k stars 2.31k forks source link

i cant login Crypto Wallets #6442

Closed tharinduvindula closed 4 years ago

tharinduvindula commented 5 years ago

Description

Steps to Reproduce

  1. i can't log brave Crypto Wallet
  2. i can't Restore account
  3. i can't do anything in brave Crypto Wallet, only show that interface

Actual result:

Capture

Expected result:

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

srirambv commented 5 years ago

Can't reproduce the issue. Can you please add the browser details and check brave://components for Crypto Wallets version?

ivigamberdiev commented 5 years ago

I have same issue. My case: 1) I created wallet and wrote password 2) But accidentally closed the tab with wallet w/o entering a seed-phrase 3) When try login or restore nothing happening I checked Metamask for this bug, but in this test case it open tab with entering a seed-phrase. Looks like Brave specific bug.

Brave 0.69.135 Chromium: 77.0.3865.120 (Official Build) (64-bit)
Revision 416d6d8013e9adb6dd33b0c12e7614ff403d1a94-refs/branch-heads/3865@{#884}

Crypto Wallets - Version: 1.0.10

tharinduvindula commented 4 years ago

I type my correct password but it after log show dashboard and after few seconds it reroute to login page

srirambv commented 4 years ago

Multiple +1 from https://www.reddit.com/r/brave_browser/comments/djigbd/the_wallet_is_awful_please_fix/

arosboro commented 4 years ago

I tried importing my metamask 12 word mnemonic phrase, but got the response that 12 words was not long enough (16, or 24 I believe). I quit, came back to this. When I enter the password I remember, I get: MetamaskController - No HD Key Tree found

srirambv commented 4 years ago

Could you guys check what component version is in the browser? You can check the component version from brave://component. The current stable release is 1.0.11. Please click on Check for update if your browser is having an older version. Once updated restart the browser and check if you are able to login

arosboro commented 4 years ago

@srirambv I don't have a path at brave://component, but brave://version says:

Brave 0.69.135 Chromium: 77.0.3865.120 (Official Build) (64-bit)
Revision 416d6d8013e9adb6dd33b0c12e7614ff403d1a94-refs/branch-heads/3865@{#884}
arosboro commented 4 years ago

Nevermind, found it at brave://components. Crypto Wallets - Version: 1.0.11 Status - Up-to-date

I recall that the release with crypto wallets came out, I imported my metamask seed unsuccessfully, and then another update came out with the login issue.

tharinduvindula commented 4 years ago

my brave://wallet/ is not work for me but i can use meta mask

ivigamberdiev commented 4 years ago

This problem is actual, even after update to Brave Version 0.70.121. Pls reopen it.

srirambv commented 4 years ago

Reopening the issue as this needs investigation as to why the login is failing.

arosboro commented 4 years ago

Can someone from the team at least provide instruction on how to wipe the crypto wallets component data/seed and start from scratch?

Brave-Matt commented 4 years ago

+1 https://community.brave.com/t/cant-log-into-cryptowallet/90681

liberuum commented 4 years ago

Got the same issue after updating to the latest version Version 1.0.0 Chromium: 78.0.3904.97 (Official Build) (64-bit)

Brave-Matt commented 4 years ago

Another on from Community: https://community.brave.com/t/re-crypto-wallet-blank-page/85967/8

@srirambv what's the status on this?

computerpoet commented 4 years ago

I have same issue. My case:

  1. I created wallet and wrote password
  2. But accidentally closed the tab with wallet w/o entering a seed-phrase
  3. When try login or restore nothing happening I checked Metamask for this bug, but in this test case it open tab with entering a seed-phrase. Looks like Brave specific bug.

Brave 0.69.135 Chromium: 77.0.3865.120 (Official Build) (64-bit) Revision 416d6d8013e9adb6dd33b0c12e7614ff403d1a94-refs/branch-heads/3865@{#884} Crypto Wallets - Version: 1.0.10

Similar issue here, when creating the wallet, at the verification phase i could not choose the seed phrase as it was blank, closed the window, then can't even reset or reimport anything.

srirambv commented 4 years ago

Could someone having login issues try this

  1. Login with the correct password
  2. When it says its incorrect
  3. Close and relaunch the browser
  4. Try logging again with correct password and check if it works
aaron-hanson commented 4 years ago

Could someone having login issues try this

  1. Login with the correct password
  2. When it says its incorrect
  3. Close and relaunch the browser
  4. Try logging again with correct password and check if it works

Tried that, no luck. Also, is there some way to reset things completely to try and set up from scratch with a new password, so we can at least get around this?

srirambv commented 4 years ago

@aaron-hanson just to be sure the crypto wallet component is up to date right? Could you check the version in brave://components? The current released version is 1.0.13

is there some way to reset things completely

Should be done as part of #5741

aaron-hanson commented 4 years ago

@aaron-hanson just to be sure the crypto wallet component is up to date right? Could you check the version in brave://components? The current released version is 1.0.13

is there some way to reset things completely

Should be done as part of #5741

Yep, it showsCrypto Wallets - Version: 1.0.13

Brave-Matt commented 4 years ago

Another +1 from Reddit: https://www.reddit.com/r/brave_browser/comments/e5xj3y/why_there_isnt_technical_support_from_team_for/

Brave-Matt commented 4 years ago

Several reports on Reddit: https://community.brave.com/t/cypto-wallet-password-and-recovery/93629/10

arosboro commented 4 years ago

I have a reasonable workaround to this after reading the comments in that thread @Brave-Matt .

I am on a mac, but pc users may be able to find the brave application profile in the mentioned thread, it's in the Application Data folder I believe. The browser specific steps will work on either platform. In reproducing the bug, I found that it is either intermittently successful at importing metamask wallets (I got it second try, after using a different password), or it's related to the password you choose.

Make sure you do these steps before attempting to fix the crypto wallet issue

  1. Have sync enabled and verify that you can add a computer from your other device (It should show a 24 word secure phrase.
  2. Store/Print/Write down your brave rewards wallet words.

Here are the steps I took to successfully import my metamask wallet.

  1. Quit Brave Browser
  2. Rename ~/Library/Application Support/BraveSoftware to back it up (It's your application profile)
  3. Open Brave Browser
  4. Open Crypto wallets
  5. Select the option to restore your account/wallet with wallet seed phrase
  6. Type an entirely new passphrase that you have not used with metamask before
  7. Accounts load and tokens at your address are displayed correctly
  8. Restore Brave rewards wallet seed
  9. Connect to sync and get your bookmarks back

Here are the steps I took to reproduce the bug:

  1. Quit Brave Browser
  2. Rename ~/Library/Application Support/BraveSoftware to back it up (It's your application profile)
  3. Open Brave Browser
  4. Skip Introduction onboard tour
  5. Open crypto wallets and choose restore wallet option
  6. Restore 12 word metamask phrase from metamask chrome store extension
  7. Enter the same password as the chrome store extension for the passphrase
  8. Brave Crypto wallet ui spinner appears and does not respond
  9. Close and re-open the browser, come back to crypto wallet and this issue occurs. I can't log in/re-import seed phrase.
srirambv commented 4 years ago

Verification passed on

Brave 1.2.19 Chromium: 79.0.3945.56 (Official Build) beta (64-bit)
Revision 73cc6bf591f792b99f8fc7cdfb8addedbd084bf8-refs/branch-heads/3945@{#788}
OS Linux
Component 0.1.30

New Wallet

Import wallet

Brave 1.2.19 Chromium: 79.0.3945.56 (Official Build) beta (64-bit)
Revision 73cc6bf591f792b99f8fc7cdfb8addedbd084bf8-refs/branch-heads/3945@{#788}
OS Windows 10 OS Version 1803 (Build 17134.523)
Component 0.1.30

New Wallet

Import wallet

Brave 1.2.23 Chromium: 79.0.3945.70 (Official Build) beta (64-bit)
Revision 65868db27916cebde51fc2465c9b34761e6383e2-refs/branch-heads/3945@{#869}
OS macOS Version 10.15.1 (Build 19B88)
Component 0.1.30

New Wallet

Import wallet

Verification PASSED on macOS 10.15.1 x64 using the following build:

Brave 1.1.20 Chromium: 79.0.3945.74 (Official Build) (64-bit)
Revision 99b6d241cf84f7fa7434ae8a59f9e74eb1464280-refs/branch-heads/3945@{#888}
OS macOS Version 10.15.1 (Build 19B88)

New Wallet:

Import wallet:

aeikenberry commented 4 years ago

This is still happening for me. Entering the correct password flashes something is loading, and then takes me back to login, entering an incorrect password says "incorrect password".

I'm on Crypto Wallets - Version: 1.0.15

ryanml commented 4 years ago

@aeikenberry - can you navigate to brave://inspect#extensions and inspect Crypto Wallets, try to log in again, and let me know what you see in the console tab?

aeikenberry commented 4 years ago
Screen Shot 2020-01-19 at 10 24 44 AM

The Invalid asm.js warning comes up when you open the crypto wallets window. Screenshot is after entering the password, hitting Log In, seeing the flash of action, then back on Login screen with no error message.

aeikenberry commented 4 years ago

I think I somehow messed up my restore phrase stuff setting up this wallet. Is there a way to wipe the wallet and setup a new local one?

aeikenberry commented 4 years ago

When i click Restore account? nothing happens in the UI, this warning in the console:

MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 "update" listeners added. Use emitter.setMaxListeners() to increase limit.
aeikenberry commented 4 years ago

Removed the ApplicationSupport directory and started again, didn't have the same issue.

aeikenberry commented 4 years ago

I was able to reproduce the issue on Brave Beta.

  1. Create a new local wallet with a new password.
  2. On the backup pass screen, exit out of it without continuing.
  3. Go back to the wallet page, see the login page, new password doesn't work.
BadseyBurger commented 4 years ago

I am also having this problem. The workaround further up the thread doesn't work for me. Help please :)

foiba commented 4 years ago

Exact same problem for almost a month now. Nothing helps. I log in with password, screen flashes showing a dropdown for about .3s in upper right corner and immediately redirects to login. I tried typing a random password and that shows as incorrect password. So it definitely recognizes my actual password as correct. No workarounds help so far. Great browser, hoping for a patch or a workaround that works around!

denisediniz commented 4 years ago

Same here. Steps to reproduce the issue (everything up-to-date)

  1. Create a new local wallet with a new password;
  2. Close the tab of the seed phrase confirmation page;
  3. Go back to the crypto-wallets page: the password immediately redirects to login and there's no way to restore, remove or create a new account.

the seed phrase confirmation page doesn't scroll down in Win10 desktop.

ryanml commented 4 years ago

Thank you all for your reports, it’s helpful as I try to see exactly what’s going on. @BadseyBurger @foiba - can you confirm if you backed out of the seed confirmation page like @denisediniz and @aeikenberry ?

DruPlusDru commented 4 years ago

I am also having this same problem. The seed confirmation page froze up so I was unable to scroll the page and complete the assigned task. I closed out the window and am having the same issue as @denisediniz and @aeikenberry

s-ben commented 4 years ago

If it's any help, was locked out of MetaMask for a web3 site I was trying to access (Gitcoin), even after disabling Brave Crypto Wallets and restarting Brave. Restarted computer (OSX 10.14.6) and only then did MetaMask successfully connect.

dhniels commented 4 years ago

I'm having this problem as well. The seed confirmation screen only showed 4 words and I couldnt get past it so i closed the window and now i get the login screen. If i enter the wallet password I created, it flashes the wallet very briefly before going back to the same login screen. Can't get past this screen or do really anything at all now. Clicking "Restore Account" does nothing.

ryanml commented 4 years ago

@BadseyBurger @foiba @denisediniz @aeikenberry @DruPlusDru @s-ben @dhniels

Thank you all so much for your patience, I have identified a fix for this and posted it here: https://github.com/brave/ethereum-remote-client/pull/114

We have also fixed the scroll issue on the confirm seed phrase page. You'll now be able to see everything on certain viewports. The fix will also backfix your situations so login will work as expected, no resets needed. This fix is set go out by the end of this week.

Here is a video of the fix (sluggishness is due to testing on a debug build): https://ryanlane.se/img/login-fix.gif

ryanml commented 4 years ago

@BadseyBurger @foiba @denisediniz @aeikenberry @DruPlusDru @s-ben @dhniels - please see https://www.reddit.com/r/brave_browser/comments/f2uqsv/crypto_wallet_is_one_giant_bug/fhet7nf/ regarding the update. It would be great if you guys could check it out and attempt to log in.

foiba commented 4 years ago

@ryanml I tried refreshing the cryptowallet tab and opening a new one and it failed to work however i was able to log in when I restarted Brave. It doesn't show the BAT I've accumulated and been rewarded but that's something else. Thank you!

denisediniz commented 4 years ago

Thank you! The Restore account link redirects to the right page (the Restore page isn't scrollable yet). I can't login right now but just because I made the workaround to delete my local test wallet and I can't create a new wallet, so right now I can't test the login function. I'm going to follow the #7677 issue.

ryanml commented 4 years ago

@denisediniz Are you not able to submit the account restore form due to a scrolling issue? Can I see a screenshot of this? Do you have your restore phrase that you can use?

denisediniz commented 4 years ago

Unfortunately I don't have the restore phrase for the deleted wallet. I had removed my local testing wallet through the workaround of deleting the odb... folders within User Data to create another one. As I'll need to create another account to login, with new password and restore phrase, I'm watching the other issue. The Restore acc page isn't scrollable but it works well through tabbing into the fields. Ty =)

ryanml commented 4 years ago

@denisediniz Got it, I haven't heard any other reports of scrolling issues on the Restore page but I will file an issue for it. I'd like to help you get back and running on Crypto Wallets, can you email me at rlanese at brave.com so I can work with you? Thanks!

HikariWS commented 4 years ago

I'm having similar issue. I just installed Brave a few days ago, so everything's updated.

I installed MetaMask and went to connect my Trezor to it. It was a very easy process on Chrome, but on Brave I keep on loading message on https://connect.trezor.io/7/popup.html#loading

Same thing happens for chrome://wallet/ when I try to connect my Trezor.

Oddly, MEW works and is able to connect.

As it always worked on Chrome flawlessly, my bet is the issue is on Brave. I wanna move out of Chrome because it bypasses pihole and keeps showing banners, it's sad Brave isn't working with Trezor.