brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.92k stars 2.34k forks source link

Use Brave branded icons for Bookmarks manager #7312

Open srirambv opened 4 years ago

srirambv commented 4 years ago

Description

Match the icons added for Bookmarks Toolbar here: https://github.com/brave/brave-core/pull/10037

For more info, see https://www.figma.com/file/sS3l8tqUFxt54MEiBTalUI/?node-id=9%3A5824

Should look like this: image

Original issue description

Use Brave branded icons for history. More info here https://github.com/brave/brave-browser/issues/6013#issuecomment-564207456

Miscellaneous Information:

lukemulks commented 4 years ago

I suspect this is the correct issue to post this - I'm observing a folder icon in brave://bookmarks in the left panel that appears a bit out of place. Would expect to see an icon that matches the Bookmarks icon at the top of the Bookmarks page.

Screenshot from 2020-01-07 20-40-56

Brave | 1.4.50 Chromium: 79.0.3945.88 (Official Build) dev (64-bit)
-- | --
Revision | c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS | Linux

I'm on Fedora 31

rebron commented 4 years ago

cc: @karenkliu

karenkliu commented 4 years ago

This is our own bookmarks folder icon: icon-folder@1 5x

It replaces the Chrome bookmarks folder icon in the browser toolbar and on chrome://bookmarks/ example

Icon asset: bookmark folder icon.zip

Also, is this issue related to https://github.com/brave/brave-browser/issues/6013?

simonhong commented 4 years ago

@karenkliu, Below images are needed for bookmark folder.

Note - Upstream mac only uses closed image. Others are uses open/closed images. If we want to use closed for all cases, it's fine.

karenkliu commented 4 years ago

Hi @simonhong, here is the direct link to our bookmarks icon in Figma where you can export it as a PNG in all the needed sizes: https://www.figma.com/file/xWGBM3qWbu3RLuZqZGwynk/Icons?node-id=124%3A10713 DM me if you have trouble accessing it or exporting. Using a closed image for all cases is fine.

simonhong commented 4 years ago

This issue needs more changes and efforts than expected because upstream on window and linux don't use different images for folder open/closed. They use same yellow colored folder images for dark/light theme. However, we need to use different images for dark/light theme because our default folder icon looks dark in dark theme.