search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.99k stars 2.36k forks source link

[Android] Support Oreo autofill #7355

Open LaurenWags opened 6 years ago

LaurenWags commented 6 years ago

Requested via community and GitHub: Users would like Brave to support Oreo autofill. https://community.brave.com/t/support-for-andriod-oreo-autofill/14641 https://github.com/brave/browser-android-tabs/issues/560

tobia commented 6 years ago

This is needed for 1password integration in Android.

Please test it with 1password for Android, to make sure Brave is providing the right context.

puechtom commented 6 years ago

This feature is lacking. Since I'm using 1password, I can't use Brave on Android

tobia commented 6 years ago

@clarktom Don't be so drastic. Your can use the 1Password special keyboard, or good old copy and paste. If you have many fields to fill in, you can put 1Password in split screen so that it doesn't lock up after you copy every field.

But yes, autofill would be useful.

vvv Edit: why the downvotes? Anyways, it's working now.

MKahmen commented 6 years ago

Seems to be fixed / working in the latest android version! 👍

puechtom commented 6 years ago

Yes, I have also noticed it ! That's a good news 👍

johnbillion commented 6 years ago

With the latest Brave and the recently released 1Password 7 on Android, this appears to be working a treat!

screendriver commented 6 years ago

For me unfortunately not. I'm using Enpass and it works in Firefox Focus and the DuckDuckGo Browser but not in Brave :cry:

nooz commented 6 years ago

Autofill with Keepass2Android still not working as of v1.0.57

rob151515 commented 6 years ago

There seems to be an issue with the implementation of autofill.

I've been doing some testing with the Brave browser on a Pixel 2 using Android Pie and autofill seems to work the first time the browser is opened from a cold start (ie. swipe it away from recents, then open it again) - you get the autofill prompt on the page.

If I then hit the home button to minimise the browser, then go and open it straight back up, the autofill prompt no longer shows. I have to then kill the browser by swiping it away in recents then open it again to get it to work.

I have also tested DuckDuckGo & Chrome browsers on the same device and they are working fine so the problem seems to be limited to this browser.

Michi0301 commented 6 years ago

I use Engpass to store passwords. I can confirm that the auto fill option shows up in the Duckduckgo browser but not in Brave, so I would assume there is something missing in Brave.

beevvy commented 6 years ago

I can confirm that autofill doesn't work in Brave 1.0.61 with LastPass on a Pixel 2. It works just fine in Chrome 70.

leobel96 commented 6 years ago

It works in brave 1.0.61 with bitwarden as password manager and android 9.0

Brave-Matt commented 5 years ago

+1 from Community: https://community.brave.com/t/bitwarden-autofill-not-working-in-brave/39758/2

PlanetWilson commented 5 years ago

Autofill not working for me either on 1.0.72 and enpass on Android. Pity as it makes it pretty unusable for me. Works fine on Chrome.

PlanetWilson commented 5 years ago

So after more testing with Enpass I can get the system autofill notification to appear but not the one that should appear dropped down from the username field itself. If I do happen to go with the system autofill notification then Enpass asks what credentials I wish to pass to "Brave" rather than the URL I am visiting. i.e. it is like Brave is not passing the URL to the autofill service itself. (similar issue mentioned here https://discussion.enpass.io/index.php?/topic/5563-wrong-autofill-information-gets-added-automatically/&tab=comments#comment-11998 with a different browser)

Update: So I think I have been getting confused with the old accessibility way of doing Autofill (system notification) and the new Android Pie autofill where it should appear in browser. I was seeing the Accessibility mechanism, I have since turned this off. No matter what pass word manager I use (tried enpass and 1Password) I cannot get the in browser/Android Pie autofill to fire at all with Brave.

RichyHBM commented 5 years ago

This seems to be an issue with chromium, I have tried a number of chromium based browsers (kiwi, bromite, chromium) and autofill doesn't work in any of these.

In fact chrome doesn't work with lastpass, m.facebook.com doesn't offer me autofill to log in where as when using firefox focus it does show up

PlanetWilson commented 5 years ago

Enpass and 1Password work with Chrome and Firefox Focus, Duck Duck Go browser and Dolphin for me but not with Brave.

armstrys commented 5 years ago

Autofill still not working for me on Brave 1.0.77 and android 8.0.

Hope a fix is around the corner as it's my only (small) gripe with Brave! Thanks!

Rouzax commented 5 years ago

Also not working for me on: Brave 1.0.89 Android 9.0 Galaxy A8 1Password 7.1.3

sjdrc commented 5 years ago

Same issue on: Pixel 2 XL PQ2A.190405.003 Brave 1.0.89 Bitwarden 1.22.0

sjdrc commented 5 years ago

Interestingly, I am able to use BitWarden autofill from Brave webview tabs (at least in some circumstances). When I try to log into a slack account with google SSO enabled through the slack app, it opens a brave custom tab (has the brave logo in top right) and offers me the regular system autofill popup. Same thing does not get offered when trying to log into gmail through the Brave app.

Rouzax commented 5 years ago

Still autofill saving is not working: Brave 1.0.92 Android 9.0 Galaxy A8 1Password 7.1.4

If there is any need for logfiles let me know.

bdcarr commented 5 years ago

I don't see the autofill menu appear at all in Brave.

Brave 1.0.92 Keepass2Android 1.07-r1 Android 9.0 Galaxy A50 (SM-A505F/DS)

sys9kdr commented 5 years ago

I have same issue. Pop-up doesn't show.

Rouzax commented 5 years ago

Is there any update/confirmation on this?

ragregory42 commented 5 years ago

I have same issue. Autofill non-functional. Brave 1.0.99 Bitwarden Autofill Framework/Bitwarden v2.0.6 Android 8.0.0 LG V30

josephsteele commented 5 years ago

Same issue for me: Brave v1.0.99 Bitwarden v2.0.6 Android 9 Samsung S8

dunxd commented 5 years ago

I'm finding the autofill works very intermittently with the following: Brave v1.1.1 Bitwarden 2.1.0 Android 9 Motorola One

I frequently have to open Bitwarden, search, copy password and paste into Brave. Occaisionaly I get the pop-up under a login field - but more often than not I don't get it.

hoejmann commented 5 years ago

Have never been able to get the autofill option to appear. Google Pixel 2 1 Password 7.3 Brave 1.2 Android 9

ih8ms commented 5 years ago

Please see also:

https://community.brave.com/t/closed-enpass-choose-wrong-link-url/666 https://community.brave.com/t/android-enpass-autofill-not-working-wrong-url-handover/15542 https://community.brave.com/t/android-enpass-autofill-not-working-properly-due-to-wrong-url-handover/72243

thanks

RobinJ1995 commented 5 years ago

Android 9 on OnePlus 5T. Same issue. This is a blocker for me. Supporting password managers is a pretty basic requirements for a browser

Kallb123 commented 5 years ago

Android 9 with OnePlus 3. Agree with above. Password manager autofill is almost a requirement to browse the Web safely.

sys9kdr commented 5 years ago

AFAIK, Oreo autofill is not supported by Chrome, Opera and other chrome-based browsers on Android（Oreo~Pie）. FIrefox Preview supports Orea autofill.

I use legacy autofill with LastPass instead of Oreo autofill. It's not good but enough.

Rouzax commented 5 years ago

It seems to be getting worse and more and more sites will not work anymore with the autofill on Brave with 1Password. Also the legacy autofill is not showing up all the time.

dstronczak commented 5 years ago

Is there any time horizon when this could be fixed? This is a huge blocker.

Rouzax commented 5 years ago

Is there any time horizon when this could be fixed? This is a huge blocker.

Agreed, this together with the really spotty sync is starting to make me doubt my switch to Brave.

tjm00 commented 4 years ago

This would be a significant improvement.

DragoCubed commented 4 years ago

samsung internet recently added support for it but has a whitelist. it's proprietary though.

anthonypkeane commented 4 years ago

Can someone please check and verify if this still an issue? Thanks

Pantamis commented 4 years ago

Still an issue with the Brave version I updated today on Google Play Store. No UI displayed to fill passwords with Oreo autofill.

Could be linked to this maybe: https://github.com/android-password-store/Android-Password-Store/pull/921

If yes then it should be fixed soon in Chromium with this fix https://chromium-review.googlesource.com/c/chromium/src/+/2288852

Hope it helps...

mraonea commented 3 years ago

Firefox supports android password autofill

zhongkechen commented 2 years ago

A 5y bug - it's the only reason I'm not using brave yet

zhongkechen commented 2 years ago

Bromite supports autofill. Can their patch be ported to Brave?

hostops commented 2 years ago

@zhongkechen same here. I tried Brave 2 years ago, 1 year ago and now. And every time I decided that it is not mature yet because of this.

I would just like to use my password manager KeepassDX but I cannot because of this: https://github.com/brave/brave-browser/issues/26733

zhongkechen commented 2 years ago

@timchilds Can you prioritize this issue? Maybe P2?

esdnm commented 1 year ago

All my passwords are in Google's Password manager, allowing me to have passwords managed across my Android devices without needing to use external software.

Brave not supporting Android's Auto fill making using it a bit difficult, since in order to login I need to copy paste authentication informations.

Ferk commented 1 year ago

I'm able to use KeePassDX as a password manager via autofill, it does work after you configure KeePassDX to be the default Autofill service for Android in the Android settings and disable Brave's builtin password manager.

The issue is that very often the domain / URL of the page is not transmitted to the Autofill for its use as keyword, so it instead defaults to the identifier of the app, com.brave.browser.

This happens, particularly, when brave is opened from within another app, or when you open a website installed as a shortcut in the Android launcher.

This last instance is easy to reproduce:

  1. Open Brave app on Android
  2. Access github.com
  3. press the 3 dots menu and select "Add to Home screen"
  4. Accept to add an icon to your launcher to open the Github website
  5. Try to login (press first sign up, then sign in)
  6. Attempt to use the autofill in the login form
Seedthis commented 1 year ago

I don't use 1Password anymore but I know that since the release of v8 for Android, accessibility got removed, maybe it happened before that, I don't know. Bitwarden still has accessibility features but I'd prefer not to use that solution.

When I need autofill on a chromium fork I use Cromite (Bromite successor) with native autofill enabled (default). Works on a completely degoogled phone (no play services, no microg).

I would like to use Brave more on mobile as it is synced with a laptop I use but without autofill it's tedious especially since I don't keep cookies.

I just hope a solution like the one Bromite/Cromite uses gets implemented soon.

M00NJ commented 1 year ago

It's been over five years now, and this issue hasn't even been formerly addressed. I think it's safe to assume that this will never be fixed. How is autofill support only P4? It's a deal breaker...

lodart commented 1 year ago

It's been over five years now, and this issue hasn't even been formerly addressed. I think it's safe to assume that this will never be fixed. How is autofill support only P4? It's a deal breaker...

Other chromium-based already fixed this. It shouldn't be that hard ! It is also a deal breaker for me