search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.01k stars 2.22k forks source link

Update error/warning page communication and iconography & use Google Safe Browsing via proxy #7464

Open karenkliu opened 4 years ago

karenkliu commented 4 years ago

Description

As on desktop, we should use Google's Safe Browsing service to avoid phishing & malware.

Designs

Create responsive webpage designs that work for mobile & desktop widths.

Interstitial pages:

image

Page might charge you money:

image

Connection not private:

image

Phishing warning:

image

Malware warning:

image

Unwanted software warning:

image

Assets

Figma: https://www.figma.com/file/aJu3WGDztEWNZgwQTD9yx2/?node-id=0%3A49

Test Plan

  1. Navigate to https://testsafebrowsing.appspot.com
  2. Confirm all webpage warnings URLs display the safe browsing warning.

Notes

Given that these are webpages, the same design is used for all platforms. iOS: https://github.com/brave/brave-ios/issues/483

karenkliu commented 4 years ago

Cross-platform reference: Desktop: https://github.com/brave/brave-browser/issues/1149#event-2871439122 iOS: https://github.com/brave/brave-ios/issues/483

karenkliu commented 4 years ago

Updated designs to reflect that these should be full-screen HTML pages using our web UI.

bsclifton commented 3 years ago

Added missing Android label so we don't miss this 😄