search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.9k stars 2.34k forks source link

[Android] Allow screenshots on private tabs #7485

Open SergeyZhukovsky opened 6 years ago

SergeyZhukovsky commented 6 years ago

We need that feature under Settings->Privacy. It has to be off by default.

eljuno commented 6 years ago

+1s from community https://community.brave.com/t/screenshot-issue-in-incognito-mode/21006?u=eljuno

https://community.brave.com/t/option-to-support-screenshots-in-private-browsing/90314?u=eljuno

alexwykoff commented 6 years ago

+1 from me. Can't do screenshots for app store images without it.

tildelowengrimm commented 6 years ago

Wait, why should it not be possible to take screenshots of private tabs by default?

drwdal commented 6 years ago

The issue was android apps which have screen viewing/drawing scraping screen data, there's a context on Android UI that removes visibility for some elements which is used in streaming video and banking apps .

WuerfelDev commented 5 years ago

I came across this issue multiple times and I hope it's not too hard for anyone to make a toggle into the settings...

dlenkes commented 5 years ago

Please add this, it was extremely annoying in a few cases I was blocked by this. Thanks!

Timmy93 commented 5 years ago

Please remove this functionality

dlenkes commented 5 years ago

Please remove this functionality

Hi Timmy93, I am a bit confused: the functionality of taking snapshots of private tabs is currently missing. So what are you asking to be removed?

Timmy93 commented 5 years ago

@dlenkes: I mean: by default I expect that a smartphone can take a screenshot, so please remove the "Don't allow screenshot" functionality.

srirambv commented 5 years ago

This feature has been requested to be added as a flag but was marked as "Wont Fix" by the chromium team. Please refer to the issue https://bugs.chromium.org/p/chromium/issues/detail?id=920762.

@anthonypkeane @SergeyZhukovsky @bbondy @tomlowenthal not sure if we should deviate from default Chromium behaviour. I believe this feature was blocked to stop third party malicious apps from capturing private browsing activity without user knowledge. Don't think we should enable it. Several reports are there on Chromium bug tracker that users have been able to use a workaround to take screenshots on Chrome Incognito tabs which the chromium team has acknowledged that the Android team is aware and fixing it. So ideally we would end up in a situation where Android would block any workaround as well.

Timmy93 commented 5 years ago

@srirambv Thank you for your detailed answer. I see the problem but it's really a pity that to test some web app we need to use a secondary browser or a browser that allow screenshot in private mode like FF.

I really hope that you can reach a solution also if it is not as easy as a tick box in the setting menu. I don't know, maybe adding a flag to chrome://flags could help to mitigate the problem of third party malicious app.

srirambv commented 5 years ago

@Timmy93 Agree its a challenge but need to consider security aspect as well. You may want to give this a try for development purpose as suggested by the chromium staff

tildelowengrimm commented 5 years ago

I don't think we should remove the ability to take screenshots in private tabs just because there might be a malicious screen-capture.

dlenkes commented 5 years ago

I agree with @tomlowenthal: Giving an explicit setting to the user to en/disable screen capturing feels like a far more user friendly behaviour than just restricting the user.

If a malicious app can mess with the settings / flags, then we are already screwed in my view.

srirambv commented 4 years ago

+1 from @jonathansampson via https://github.com/brave/browser-android-tabs/issues/2501

FLAG_SECURE prevents screenshots of the application window (as well as broadcasting to a non-secure display). Sensibly, we use this flag for Private Tabs. That said, some users would like to take screenshots of private tabs. https://github.com/brave/browser-android-tabs/blob/45d76ff5280dc7125d47d9e6461f283c47cb6db1/chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoTabSnapshotController.java#L68-L84

We could, perhaps, offer the option to allow screenshots for the Private Browsing Session, clearing user-consent when the private tab closes (requiring them to consent again for the next tab).

drwdal commented 4 years ago

I need this feature in the mobile editions of Brave and having this feature would cause me to switch from my current main browser that allows this to mainly use Brave, other apps with security considerations allow user interactions to disable FLAG_SECURE and I think the majority of protections provided by FLAG_SECURE should be left as a choice to the user. I don't think consent needs to be given each time the Private Browsing Session so long as it is explained in a consent notification at first use.

wes-novack commented 4 years ago

I ran into this today. Use case scenario: I was using a private tab to browse Comcast Xfinity internet service offers in my area. I didn't want to be shown offers based on me being an existing customer, I wanted to see new customer offers. Found the offers, tried to screenshot for proof, was prohibited from doing so, and found my way to this issue.

Please make this a user toggle option.

PPearoo commented 2 years ago

+1 from me, don't allow it by default for user privacy but let people do it if they know what they're doing

TimTrayler commented 2 years ago

+1 from me but are there any news about this issue?

alcarraz commented 5 months ago

So, in order to protect the user from malicious apps, chromium force the user to enter pages they want to be private in non private mode just to be able to cast a video. I have a strong feeling that at least an experienced user should be able to override that. So it should be configurable by at least a flag. Or when you enter private mode, be notified that that flag is active.