Shields should be visible when Brave is used in PWA context

[bsclifton]

Problem description

Users have the ability to create a PWA for specific sites (ex: Twitter). They can pick: Hamburger menu => More tools => Create shortcut (if prompted when making the app, click "Create new window")

This allows a distinct icon to be pinned to taskbar / stored on OS as shortcut. When opened, it'll feel like a distinct app. When this is opened, it doesn't show the shields icon... but shields are being applied.

Actual result:

Shields icon (Lion icon) is not shown ☹️

Expected result:

Shields icon should show and (when clicked) panel should open... like it does in non-PWA context

The root cause (and proposed fix)

When moving the Shields and BAT icons to the omnibox / URL bar, the extension icons were moved into a BraveActionsContainer which is NOT shown for PWAs.

We could check if the rendering is inside of a PWA context and then not skip rendering of the Shields (and possibly the BAT) icons. In that case, they'd show up in the menu seen under Actual result, next to the other extension icons

Reproduces how often:

100%

Brave version (brave://version info)

Brave	1.5.27 Chromium: 79.0.3945.117 (Official Build) nightly (64-bit)
Revision	04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS	macOS Version 10.15.2 (Build 19C57)

[srirambv]

personal +1 on this.

[mikaelf]

Is there a way to view and change settings for shields before this bug has been fixed? I haven't found a workaround.

[srirambv]

+1 from @youssef20031 via #14886

Actual result:

Expected result:

[sbmueller]

Adding my vote here. Many PWAs don't work correctly if shields are up, and there is currently no way to disable them AFAIK.