Additional phase of Brave Ads regions

tmancey commented 4 years ago

Add the following regions to Brave Ads:

jwchong commented 4 years ago

Pls add Malaysia into the region list.

eljuno commented 4 years ago

@jwchong Malaysia is already supported (#6825) -- https://brave.com/transparency/

jsecretan commented 4 years ago

For privacy reasons, we should put the follow country codes together under a country code for Other "??":

AS AI AQ AG BQ BV IO CF TD CX CC KM CK GQ ER FK TF GL GW HM VA KI LR MH YT FM MS NR NU NF MP PW PN BL SH KN MF PM WS SM ST SX SB GS SS SJ TJ TL TK TM TC TV UM VU VG WF EH

GeetaSarvadnya commented 4 years ago

@jsecretan @tmancey Cannot verify the issue as catalog is empty for additional ad regions, for more details please refer https://bravesoftware.slack.com/archives/CJL3G0S95/p1588687877157000

LaurenWags commented 4 years ago

Test Plan:

follow plan outlined in https://github.com/brave/brave-core/pull/4427 for 2-3 new regions above. Each OS should check different regions. (confirmed plan with @jsecretan)
additionally, spot check previously added regions (using google doc list, message me if you need the list) to confirm they are still supported as expected.
"OTHER" country code (as noted in https://github.com/brave/brave-browser/issues/7817#issuecomment-603221160) is not set up on the server at this time, this is ok for right now.

LaurenWags commented 4 years ago

Verified passed using

Brave   1.9.70 Chromium: 81.0.4044.138 (Official Build) (64-bit)
Revision    8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS  macOS Version 10.14.6 (Build 18G3020)

Verified the following for new regions (Estonia, Moldova)
- Clean install of 1.9.x. Enable Rewards. Confirmed Ads are enabled by default. Confirmed able to view an ad.
- Installed 1.8.96. Enabled Rewards. Confirmed Ads are not available. Upgraded to 1.9.70. Confirmed notification displayed on BAT logo to alert user that ads are now available in their region. Confirmed Ads are not enabled by default on upgrade. Confirmed able to enable ads and view an ad.

Estonia on 1.8.96:

Estonia after upgrade to 1.9.x:

Confirming ad panel updates for Estonia when ads are enabled and an ad notification has been served:

Moldova on 1.8.96:

Moldova after upgrade to 1.9.x:

Confirming ad panel updates for Moldova when ads are enabled and an ad notification has been served:

Also per https://github.com/brave/brave-browser/issues/7817#issuecomment-630381585, spot checked previously enabled ad regions: US, Ireland, Russia and confirmed the following scenarios:
- Clean install of 1.9.x. Enable Rewards. Confirmed Ads are enabled by default.
- Installed 1.8.96. Enabled Rewards. Disabled Ads. Upgraded to 1.9.x. Confirmed Ads are still off after upgrade. No notification that ads are available.
- Installed 1.8.96. Enabled Rewards. Upgraded to 1.9.x. Confirmed Ads are still on after upgrade. No notification that ads are available.

Verification passed on

Brave | 1.9.71 Chromium: 81.0.4044.138 (Official Build) (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

Verified the following for new regions Iceland and Latvia
- Clean install of 1.9.x. Enable Rewards. Confirmed Ads are enabled by default. Confirmed able to view an ad.
- Installed 1.8.96. Enabled Rewards. Confirmed Ads are not available. Upgraded to 1.9.70. Confirmed notification displayed on BAT logo to alert user that ads are now available in their region. Confirmed Ads are not enabled by default on upgrade. Confirmed able to enable ads and view an ad.

Iceland 1.8.96:

Icelanda after upgrade to 1.9.71

Confirming ad panel updates for Iceland when ads are enabled and an ad notification has been served:

Clean install of 1.9.x. Enable Rewards. Confirmed Ads are enabled by default. Confirmed able to view an ad.
- Installed 1.8.96. Enabled Rewards. Confirmed Ads are not available. Upgraded to 1.9.70. Confirmed notification displayed on BAT logo to alert user that ads are now available in their region. Confirmed Ads are not enabled by default on upgrade. Confirmed able to enable ads and view an ad.

Latvia 1.8.96:

Latvia after upgrade to 1.9.71:

Confirming ad panel updates for Latvia when ads are enabled and an ad notification has been served:

Also per https://github.com/brave/brave-browser/issues/7817#issuecomment-630381585, spot checked previously enabled ad regions: US and India and confirmed the following scenarios:
- Clean install of 1.9.x. Enable Rewards. Confirmed Ads are enabled by default.
- Installed 1.8.96. Enabled Rewards. Disabled Ads. Upgraded to 1.9.x. Confirmed Ads are still off after upgrade. No notification that ads are available.
- Installed 1.8.96. Enabled Rewards. Upgraded to 1.9.x. Confirmed Ads are still on after upgrade. No notification that ads are available.

Verification passed on

Brave	1.9.71 Chromium: 81.0.4044.138 (Official Build) (64-bit)
Revision	8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS	Ubuntu 18.04 LTS

Verified ads are being enabled after upgrade Verified ads are enabled on clean install Verified ability to view an ad Verified the following regions:

Liechtenstein | LI in 1.8.x Liechtenstein | LI in 1.9.x

Norway | NO in 1.8.x Norway | NO in 1.9.x

Luxembourg | LU in 1.8.x Luxembourg | LU in 1.9.x

Also per #7817 (comment), spot checked previously enabled ad regions: US, Poland. Confirmed the following scenarios: Clean install of 1.9.x. Enable Rewards. Confirmed Ads are enabled by default. Installed 1.8.96. Enabled Rewards. Disabled Ads. Upgraded to 1.9.x. Confirmed Ads are still off after upgrade. No notification that ads are available. Installed 1.8.96. Enabled Rewards. Upgraded to 1.9.x. Confirmed Ads are still on after upgrade. No notification that ads are available.

brave / brave-browser

Additional phase of Brave Ads regions #7817