Redundancies in Command-Line Values

[jonathansampson]

Description

The Command-Line value in about:version often contains redundancies.

Steps to Reproduce

1. Navigate to about:version

Actual result:

Redundancies in Command-Line value.

1.3.115 (current stable) contains the following redundancies:

--disable-features= AllowPopupsDuringPageUnload, AudioServiceOutOfProcess, AutofillServerCommunication, LookalikeUrlNavigationSuggestionsUI, NotificationTriggers, SmsReceiver, VideoPlaybackQuality, WebXR, WebXrGamepadModule
--disable-features= AllowPopupsDuringPageUnload, AudioServiceOutOfProcess, AutofillServerCommunication, LookalikeUrlNavigationSuggestionsUI, NotificationTriggers, SmsReceiver, VideoPlaybackQuality, WebXR, WebXrGamepadModule
--disable-webrtc-apm-in-audio-service
--disable-webrtc-apm-in-audio-service
--enable-audio-service-sandbox
--enable-audio-service-sandbox
--enable-features= PasswordImport, SimplifyHttpsIndicator, WebUIDarkMode
--enable-features= PasswordImport, SimplifyHttpsIndicator, WebUIDarkMode

1.4.86 (current beta) contains no redundancies. 1.5.91 (current developer) contains no redundancies. 1.6.32 (current nightly) contains the following redundancies:

--enable-features= BraveNTPBrandedWallpaperName, DnsOverHttps, PasswordImport, SimplifyHttpsIndicator, WebUIDarkMode
--enable-features=                               DnsOverHttps, PasswordImport, SimplifyHttpsIndicator, WebUIDarkMode

Expected result:

No unnecessary redundancies.

Reproduces how often:

Always.

Brave version (brave://version info)

Brave	1.3.115 Chromium: 80.0.3987.87 (Official Build) (64-bit)
Revision	449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}

Version/Channel Information:

• Can you reproduce this issue with the current release? Yes
• Can you reproduce this issue with the beta channel? No
• Can you reproduce this issue with the dev channel? No
• Can you reproduce this issue with the nightly channel? Yes

[rebron]

@jonathansampson Can you try again with 1.7.92? Still an issue?

[jonathansampson]

@rebron I still see redundancies:

"C:\Program Files (x86)\BraveSoftware\Brave-Browser\Application\brave.exe"
  --profile-directory=Default
  --enable-dom-distiller
  --disable-domain-reliability
  --no-pings
  --extension-content-verification=enforce_strict
  --extensions-install-verification=enforce
  --sync-url=https://no-thanks.invalid
> --enable-features=PasswordImport,WebUIDarkMode,AutoupgradeMixedContent,PassiveMixedContentWarning,MixedContentSiteSetting,SimplifyHttpsIndicator,DnsOverHttps
  --disable-features=AutofillServerCommunication,LookalikeUrlNavigationSuggestionsUI,NotificationTriggers,AllowPopupsDuringPageUnload,AudioServiceOutOfProcess,SmsReceiver,VideoPlaybackQuality
  --flag-switches-begin
> --enable-features=PasswordImport,WebUIDarkMode,AutoupgradeMixedContent,PassiveMixedContentWarning,MixedContentSiteSetting,SimplifyHttpsIndicator,DnsOverHttps,BraveSync
  --flag-switches-end
  --enable-audio-service-sandbox
  --disable-webrtc-apm-in-audio-service

[darkdh]

It is tied to "relaunch" because it will inherit the args before relaunching STR:

1. Go to brave://flags/ and randomly change something and change back to trigger relaunch prompt

   

2. Click Relaunch button

3. After relaunch go to brave://version/