brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.7k stars 2.31k forks source link

muted websites are saved on private navigation session #8602

Closed starbassma closed 4 years ago

starbassma commented 4 years ago

Brave remember sounds settings inside private windows (mute/unmute)

Version

Version 1.4.96 Chromium: 80.0.3987.132 (Official Build) (64-bit)

Steps to Reproduce

  1. CTRL+SHIFT+N (open new private navigation window)
  2. CTRL+T (x2) open two tabs
  3. inside one of the tabs visit whatever website your want and mute it (right click on the tab and "mute website")
    1. close the muted tab (CTRL+W)
    2. open the same website again inside the other tab
    3. right click on that tab (you will see "Unmute site" instead of "Mute site") this is definitely not the expected behavior, this kind of information shouldn't be saved/revealed. Regards,
bsclifton commented 4 years ago

hi @starbassma

I tried a few scenarios and I'm not sure there is a problem. Here's what I did:

However, the changes made in a private window do not work like that:

Can you confirm this is the case for you too? There is no privacy leak happening. The private windows will inherit any site settings from your default profile, which is how the private tab can be muted when you muted regular tab

Hope this makes sense- thanks!