brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.57k stars 2.28k forks source link

CryptoWallet: Imported ETH private key; deleted wallet; still available in "Transfer Between my Accounts" #8823

Open heyJonBray opened 4 years ago

heyJonBray commented 4 years ago

Description

I was playing around with crypto wallet features to import 3rd party wallets from the private key. This worked great, all of my ERC20 token balances showed up fine. I removed the account from my Crypto Wallets, but when I open my Brave-created or MetaMask wallet and send funds, my third wallet is still shown.

Steps to Reproduce

  1. brave://wallet > Import Account > Private Key
  2. Enter private key for ETH wallet
  3. Remove connected wallet.
  4. Open any other wallet and select 'Send' > 'Transfer Between my Accounts'
  5. The deleted wallet is still shown there, although without the name it was given, just "Address 3".

Actual result:

A wallet which contained my private key is still showing up as a contact even after removing.

Expected result:

I don't want to see that wallet anymore after removing.

Reproduces how often:

Easily reproduced. Tried with Exodus and MyEtherWallet.

Brave version (brave://version info)

Brave 1.5.113 Chromium: 80.0.3987.149 (Official Build) (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS Windows 10 OS Version 1909 (Build 18363.720)

Other Additional Information:

lukemulks commented 4 years ago

+1

Am able to repro w/Hardware Wallet acct, Ledger Nano (Legacy)

Removed Hardware Wallet acct from account options.

Account still displays in "transfer betwen my accounts" list, with a generic name as the original author of the issue described above.

Would expect all traces of my hardware wallet to be removed when I manually remove the hardware wallet from my accts list.

Brave | 1.12.87 Chromium: 84.0.4147.89 (Official Build) dev (64-bit)
-- | --
Revision | 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS | Linux