search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.51k stars 2.26k forks source link

Video playback fails until adblock is toggled #902

Closed srirambv closed 3 years ago

srirambv commented 6 years ago

Issue ported over from https://github.com/brave/browser-laptop/issues/8521

Sites on which video playback fails with adblock

pes10k commented 5 years ago

I cannot recreate the following sites in the beta

srirambv commented 5 years ago

This is surprising. IMDB and ESPN is allowing playback without having to disable shields/toggle adblock. Was there anything changed on the adblock library?

Techguyprivate commented 5 years ago

brave Weird behaviour. I am sending you a gif ,please look at it.

  1. I have disabled script blocking in Brave default shield in chrome://setting.

  2. In chrome://setting , go to content setting ,then javascript toggle option showing disabled.

    3 .Also, there is no toggle button in all site content setting.

  3. I have to enable javascript on every site manually through the brave shield right of url bar.

  4. Then it showed of in javascript setting in chrome:// setting , content setting as allowed.

Same thing also in both brave dev and beta built on brave core ( not brave browser laptop built on muon,modifeid electron)

srirambv commented 5 years ago
dead-claudia commented 5 years ago

BTW, I'll note I do get PornHub playback (including PornHub Live) in Chrome + uMatrix with these rules, but with a few caveats:

* * * block
* * css allow
* * frame block
* * image allow
* 1st-party * allow
* 1st-party frame allow
pornhub.com naiadsystems.com script allow
pornhub.com naiadsystems.com xhr allow
pornhub.com phncdn.com frame allow
pornhub.com phncdn.com media allow
pornhub.com phncdn.com script allow
pornhub.com pornhublive.com frame allow
pornhub.com pornhublive.com script allow
pornhub.com rncdn3.com media allow
GeetaSarvadnya commented 5 years ago

1+https://community.brave.com/t/fox-news-videos-will-not-play/45910

ryanbr commented 5 years ago

Foxnews/Fox Business adblock annoyance:

@@||fncstatic.com/static/v/all/js/ads.js

Brave-Matt commented 5 years ago

User reporting fox news video play back issue: https://community.brave.com/t/on-the-fox-news-website-videos-arent-playing/69496

ryanbr commented 5 years ago

I thought foxnews this was fixed, okay this will need a bit to debug.

Brave-Matt commented 4 years ago

Another report of fox news videos not playing until sheilds are down/ads are allowed: https://community.brave.com/t/videos-dont-play-from-fox-news/81622/3

ryanbr commented 4 years ago

I've fixed abcnews, if someone can confirm?

Tested with https://abcnews.go.com/Entertainment/kim-kardashian-west-backlash-working-trump-choose-alice/story?id=65571704

And from the main page; https://abcnews.go.com/

Working on getting foxnews atm.

ryanbr commented 4 years ago

Foxnews and Foxbusiness should work now

bkarlan commented 4 years ago

Not working. I'm using Brave Version 1.11.101 Chromium: 84.0.4147.89 (Official Build) (64-bit)

antonok-edm commented 3 years ago

@ryanbr it looks to me like videos on foxbusiness articles are still broken

kenherbert commented 3 years ago

Issues with IMDB again (or still?). Videos try to play but immediately skip to next in the queue.

ryanbr commented 3 years ago

Checking Foxnews/Fox Business is now working.

Regarding the Imdb issue @thefallofbecause : https://github.com/brave/brave-browser/issues/13101

ryanbr commented 3 years ago

Before closing ticket. reviewed the following sites and sample links.

With default shield settings, the following sites were checked for video playback and confirmed:

https://www.imdb.com/video/vi3657416729?ref_=hm_hp_i_1&listId=ls053181649 Worked. https://www.espn.com/soccer/borussia-dortmund/story/4358642/bellingham-ready-to-succeed-haalandsancho-as-dortmunds-brightest-prospect Worked https://video.foxnews.com/v/6249541545001#sp=show-clips Worked https://www.foxbusiness.com/lifestyle/united-airlines-boeing-777-engine-pratt-whitney-resume-flying Worked https://www.pornhub.com/view_video.php?viewkey=xxxxxx Worked https://www.nytimes.com/video/us/politics/100000007721570/biden-george-floyd-verdict.html Worked https://abcnews.go.com/Health/video/volunteers-launch-websites-people-access-covid-19-vaccines-76342641 Worked.

Any other issues with various sites, we should just log a issue report per site. cc: @srirambv