search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.88k stars 2.34k forks source link

[Desktop] Do not show 0.0 BAT for monthly ad earnings in the Monthly Contribution Statements for verified wallets #9211

Closed Miyayes closed 3 years ago

Miyayes commented 4 years ago

If the Brave Rewards wallet is verified, then earnings for each month where the wallet is verified will display 0.0 BAT (since ads earnings are sent directly to the user's Uphold account, rather than being accounted for within the browser). Instead of displaying 0.0 BAT, the interface should display an informative message about this case or, e.g., link to the user's Uphold transactions page.

image

Displaying 0.0 BAT for "Earnings from Ads" may be confusing to users. For example, in the above screenshot, the user did have ad earnings for that month, but the statement still displays 0.0 BAT.

Possible Solution:

Make some conditional logic such that if the wallet is verified for some month, then replace "0.0 BAT" with a link to the user's Uphold account, or some other message.

Update: Hyperlink text == "View deposit history"

~Add correct accounting in the verified case.~

Version 1.7.92 Chromium: 80.0.3987.163 (Official Build) (64-bit) MacOS

LaurenWags commented 4 years ago

cc @mandar-brave @jenn-rhim also

cryptojennie commented 4 years ago

+1: https://www.reddit.com/r/BATProject/comments/hfwqyn/brave_wallet_is_showing_no_activity_00_bat_all_of/

cryptojennie commented 4 years ago

+1: https://www.reddit.com/r/brave_browser/comments/hm5fd6/bat_rewards_system_as_now_become_a_joke/fx4t6qm?utm_source=share&utm_medium=web2x

kasramp commented 4 years ago

I also have the same issue. Running Version 1.13.82 Chromium: 85.0.4183.83 (Official Build) (64-bit) on Linux Mint 19.3 Tricia. I also noticed a visual bug. If from the drop down I change the month it doesn't reflect and only the check mark is shown if I open the drop down, bug Notice how in the highlight it's showing September even when May is selected.

LaurenWags commented 4 years ago

@kasramp thanks for reporting, the bug with the drop down selection is being tracked with https://github.com/brave/brave-browser/issues/11613

Miyayes commented 3 years ago

0.0 BAT can be replaced with a link to a user's Uphold transaction history page (e.g. “See your earnings history on Uphold”). According to Uphold, it's currently not possible to filter by month, so a link to the general transaction page will do for now!

https://uphold.com/dashboard/cards/{card_id}/activity

Query parameters possible for pagination: e.g., ?page=2.

Miyayes commented 3 years ago

Confirmation by Uphold.

In the page there's no option to filter the activity by month. Still, you can download the Activity report and work the CSV file to filter by dates.

Stick with simple solution for now. Do not download and parse .csv:

jenn-rhim commented 3 years ago

The earning should be indicated here regardless of where the tokens are stored/managed, just as the total balance. This seems to have gotten off the rail somewhere.

Miyayes commented 3 years ago

@jenn-rhim Unfortunately, the issue (I was told by Nejc back in the day, and I think is probably still true) is that because they're direct deposits to Uphold, we don't have easy access to the accounting, so we can't fetch this information easily :(.

I think this would just be a temporary solution until we fix these issues from the bottom up (for instance, with pure virtual wallets).

Miyayes commented 3 years ago

This will be resolved properly (not with a stopgap solution) once this is implemented: https://github.com/brave/brave-browser/issues/15320

Edit see below.

Miyayes commented 3 years ago

I think we should just go with the stopgap solution for now as initially proposed (link out to the custodians' transaction page). It's an easier win and will end confusion in the immediate term. Waiting for https://github.com/brave/brave-browser/issues/15320 may take too long, and https://github.com/brave/brave-browser/issues/15320 might become obsolete anyway if/when we move away from direct deposits.

Miyayes commented 3 years ago

Going with View deposit history for the hyperlink text. cc: @zenparsing @codybanxs

Miyayes commented 3 years ago

+1 https://community.brave.com/t/faulty-monthly-statement/245787

Miyayes commented 3 years ago

+1 https://www.reddit.com/r/BATProject/comments/p0e75x/my_bat_rewards_are_significantly_less_than/

Miyayes commented 3 years ago

Related: https://github.com/brave/brave-browser/issues/18159

LaurenWags commented 3 years ago

Verified passed with

Brave | 1.32.78 Chromium: 95.0.4638.54 (Official Build) beta (x86_64)
-- | --
Revision | d31a821ec901f68d0d34ccdbaea45b4c86ce543e-refs/branch-heads/4638@{#871}
OS | macOS Version 11.6 (Build 20G165)

Verified test plan from https://github.com/brave/brave-core/pull/10152#issue-1001249303

Anon wallet Confirmed that there is not a `View deposit history` link next to `Earnings from Ads` on Monthly Statement: Anon wallet
Uphold wallet Confirmed that there is a `View deposit history` link next to `Earnings from Ads` on Monthly Statement. Confirmed that this link directs to `/dashboard/cards/:card-id/activity`, however it is redirected on the Uphold site to `/dashboard/transact`. Example | Example | Example ----- | ----- | ----- Uphold1 | Uphold2 | Uphold3
bitFlyer wallet Confirmed that there is a `View deposit history` link next to `Earnings from Ads` on Monthly Statement. Confirmed that this link directs to `/ja-jp/ex/tradehistory` as expected. Example | Example | Example ----- | ----- | ----- bF1 | bF2 | bF3
Gemini wallet Confirmed that there is a `View deposit history` link next to `Earnings from Ads` on Monthly Statement. Confirmed that this link directs to `/balances` as expected. Example | Example | Example ----- | ----- | ----- Gemini1 | Gemini2 | Gemini3