search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.47k stars 2.26k forks source link

[Android] Bookmark all tabs #9443

Open Poopooracoocoo opened 4 years ago

Poopooracoocoo commented 4 years ago

Description

Bookmark all tabs

Steps to reproduce

N/A feature request

Actual result

N/A feature request

Expected result

N/A feature request

Issue reproduces how often

N/A feature request

Issue happens on

Device details

Brave version

1.21.76

Website problems only

N/A feature request

Additional information

https://bugs.chromium.org/p/chromium/issues/detail?id=1026222

this would live in the menu of the tab switcher. to be clear, this is possible on Firefox based and Chromium based browsers on desktop from the title bar or by using the ctrl+shift+d shortcut. It bookmarks all tabs in a window to a folder with a dialog asking you where you want to make a folder and what you want to name it (but it's already filled out so you can just press enter if you'd like). Brave would be the first ever browser on Android to let you bookmark all of your tabs. Tab groups would just be a folder within the folder and retain their name. A big use case is private browsing. Users will be able to close all of their tabs with confidence before bookmarking them.

there could be a screen, a dialog or a snackbar. I personally think a dialog would be suitable. It could be like the download prompt.

I've been thinking about switching to Brave for a while now and this would really show me that you guys care :)

Poopooracoocoo commented 4 years ago

fyi this is possible on desktop chromium

jonathansampson commented 4 years ago

This is fairly common feedback from Android users. In addition to the ability to toss all opened-tabs into a bookmark folder, users also often request the ability to restore all bookmarks within a folder to opened tabs.

Poopooracoocoo commented 4 years ago

Hi there @jonathansampson. Just updated the issue description with everything that I think is relevant. Is there anything else that I should add? I scrolled through the Chromium issue and it's amazing how Google juggles the issue around but never does anything about it! When a user even mentioned that there are duplicate issues they didn't do anything.

DragoCubed commented 4 years ago

I've approached Bromite and Kiwi Browser about this and Bromite declined as it wasn't related to privacy and the latter sort of ignored it.

Poopooracoocoo commented 4 years ago

@srirambv anything you think might be useful for the issue?

bsclifton commented 4 years ago

@Poopooracoocoo definitely good details here, thanks! 😄

Poopooracoocoo commented 4 years ago

What are the chances of this being implemented any time soon? I'd like to switch to Brave. :)

DragoCubed commented 4 years ago

erm. any updates on this and importing/exporting bookmarks? @bsclifton edit: and why is it such a low priority issue? this is one of the few things keeping me from switching.

thatsofia commented 4 years ago

erm. any updates on this and importing/exporting bookmarks? @bsclifton edit: and why is it such a low priority issue? this is one of the few things keeping me from switching.

it's because they don't care. it's the same at vivaldi.

Poopooracoocoo commented 3 years ago

@bsclifton any updates on this? still not possible on brave for iOS either (but you can on safari)

thatsofia commented 3 years ago

@bbondy @bsclifton Reckon we can see this sometime soon?

bsclifton commented 3 years ago

@thatsofia this is labeled P5 unfortunately, so this isn't something that we're planning to work on. Pull requests welcome for community members that wanted to grab this. The priority may change - but for now, it's low ☹️

thatsofia commented 3 years ago

That's unfortunate. The code is there for desktop and as we know, Chromium shares a lot of code between desktop and Android, but there's no way to do it on Android :( this is so important to me coming from Safari and iPhones.

Poopooracoocoo commented 3 years ago

Bromite now has this! https://github.com/bromite/bromite/blob/master/build/patches/Add-menu-item-to-bookmark-all-tabs.patch

Before Brave even thought about this seriously. See https://github.com/wchen342/ungoogled-chromium-android/issues/26 for some reasoning.

@bsclifton Could Bromite's patch be integrated into Brave for Android? I think you guys or maybe the people at Vivaldi said that patches can't be integrated directly, but what about just using it as a reference?

Poopooracoocoo commented 3 years ago

@bsclifton @srirambv any updates on this?

erahhal commented 2 years ago

Is it really the case that there is still no way to sync, bookmark, or otherwise export open tabs on Android? It looks like there's an toggle to turn on "open tabs" sync but it doesn't work. If I have to spend the next 3 hours manually going through open tabs then I'm not going to install Brave again once I'm done - no way I'd dig myself into that hole again.

sbutler-gh commented 2 years ago

Any updates on this?

distbit0 commented 2 years ago

Would be awesome to have this feature, especially for all tabs in a group rather than all tabs in all groups. I often want to send links I have collected in a group to someone, which is very difficult at the moment as each one needs to be copied individually.

Chrome android used to support the ability to copy links in a group, but it seems this feature has been removed.

Would be awesome to have it back! :)

TheZitroX commented 2 years ago

Hello. I also would like to see this. My problem is, that i collected 56 Pornhub-links. Ive got a new phone; how should i transpher all the tabs: one by one? No. Pls add this feature😅

Update: there are two Groups. One with 54 Tabs and one with 14. I don't want to dig through all one by one.

1MachineElf commented 2 years ago

How is this not a feature in 2022?

TheZitroX commented 2 years ago

How is this not a feature in 2022?

I dont know. They should implement this or stuck in in the 20th century

amanasci commented 2 years ago

So I managed to sync the tabs. Kinda a hack, maybe if it's very important you can try this.

Use ADB to capture the URL of all tabs from one device, then again use ADB to open tabs with those URLs on the other device.

sbutler-gh commented 2 years ago

Use ADB to capture the URL of all tabs from one device, then again use ADB to open tabs with those URLs on the other device.

Can you offer any instruction/guidance for how to (1) capture the URL of all tabs from mobile device, and then (b) use ADB to open tabs with those URLs on mac desktop?

I have ADB set up, I'd just love some guidance on those two actions specifically.

Poopooracoocoo commented 2 years ago

does https://android.stackexchange.com/questions/56635/how-can-i-export-the-list-of-open-chrome-tabs/199496#199496 help?

sbutler-gh commented 2 years ago

Use ADB to capture the URL of all tabs from one device, then again use ADB to open tabs with those URLs on the other device.

Can you offer any instruction/guidance for how to (1) capture the URL of all tabs from mobile device, and then (b) use ADB to open tabs with those URLs on mac desktop?

I have ADB set up, I'd just love some guidance on those two actions specifically.

Got it! So here's how I did it:

  1. Install Android Debug Bridge on Android and desktop using this guide and enable USB debugging on Android device.

  2. Connect Android to desktop via USB, and enable "File Transfer (MTP)" connection setting on Android

  3. Open Brave app on Android

  4. Open Brave browser on desktop. Open a new tab on desktop, and enter brave://inspect/#devices in the address bar (or chrome://inspect/#devices) and hit enter. This will load a DevTools page. (At this point, you may get a notification on your Android requesting access permissions. Accept the permissions on your Android.)

  5. After a few seconds, in the brave://inspect/#devices tab on your desktop, you should see a list of all the tabs from your mobile device (website title + URL) appear on the page! You may want to wait a few seconds, to allow information from certain tabs to continue loading.

At that point, you have the information on your desktop. I just copied the whole page and pasted it into a text file, but there may be other things you can do with it once you have it in brave://inspect/#devices

Source for solution: https://superuser.com/a/1707446

Thank you @amanasci for the original nod to this approach, and @Poopooracoocoo for the input as well!

1MachineElf commented 2 years ago

Following the links @sbutler-gh provided I was able to get a list of all 17,022 open tabs from Brave on my Android phone.

It would sure be nice if there was an easier way to manage all of these.

kverbyob commented 1 year ago

The solution of @sbutler-gh works fine for URL's up to 100 characters. This solution does not have this limit and worked nicely for me, but may not work for much longer.

# First enable USB debugging on phone and connect via USB
# Then install android developer tools

# Verify device is connected and permissions granted
./adb devices -l

# Connect to Chrome Android's legacy debugging API
./adb forward tcp:9222 localabstract:chrome_devtools_remote

# Visit http://localhost:9222 to verify, then
curl http://localhost:9222/json/list > mobile-tabs.json
TheFireBlast commented 9 months ago

This issue can already be closed as you can do this by going to Tabs>...>Select tabs ...>Select all Bookmark tabs