search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
18k stars 2.36k forks source link

Brave freezes or hangs on launch when there are a large number of `Cookies and other site data` #9481

Closed bsclifton closed 4 years ago

bsclifton commented 4 years ago

Description

We have several reports from users on all Desktop OSes having a hang or complete freeze of the program when launching. After investigation, this appears to be due to a large number of entries under brave://settings/content/all

Clearing Cookies and other site data will resolve the issue until the user builds up a large number of sites again. @iefremov has characterized the problem (see https://github.com/brave/brave-browser/issues/9481#issuecomment-660111245) and we're working on a fix

Test plan

  1. QA to contact @bsclifton for minimal reproducible profile
  2. Put profile into place
  3. Launch version of Brave without this fix
  4. Confirm it takes a while to load
  5. Launch version of Brave with this fix
  6. Confirm it loads instantly

Original issue description

Below is the text from when we were diagnosing this issue. There were multiple problems in play and some of those were split out into separate issues. The text is being kept for posterity

GitHub issues

Newly updated Brave freezes after launch - Windows 10 #9372

Brave Beta hangs on start after update #9162

System randomly freezing #9294

Possibly related issues

Community issues

Recommended user troubleshooting steps

Things that can help us narrow it down

Steps that some people have used to fix the problem

We're working on a fix now - stay tuned.

Following these steps will lead to data loss. Please consider backing up your profile before attempting! If you're not sure how to do that, please ask here

Fixes that have already been released

Known problems (not being addressed)

bsclifton commented 4 years ago

For folks that are experiencing lock-ups because of the publisher list being downloaded (for Brave Rewards), there are some great fixes coming in 1.8. One of those fixes a bug where this list continues to be downloaded even after flipping rewards to off https://github.com/brave/brave-core/pull/5356

We'll have a release candidate available soon which I'll try to share when it completes

bsclifton commented 4 years ago

For anyone tracking this who would like to try the 1.8 release candidate, please download and try out https://github.com/brave/brave-browser/releases/tag/v1.8.84 and let us know if this improves behavior ๐Ÿ˜„

riccardoangius commented 4 years ago

Thank you. Clean install is still crashing on my side though.

Uploaded Crash Report ID 10280000-64a1-5604-0000-000000000000 (Local Context: 2caabdb7-d67a-4bb5-9da8-4c0c5bd35194) Crash report captured on Monday, 27 April 2020 at 13:29:56, uploaded on Monday, 27 April 2020 at 13:33:21

โ•ฐโ”€$ "/Applications/Brave Browser.app/Contents/MacOS/Brave Browser" 130 โ†ต [771:775:0427/132940.577124:ERROR:browser_switcher_service.cc(238)] XXX Init() [771:70147:0427/132941.529922:ERROR:rewards_service_impl.cc(243)] Failed to read file: /Users/ric/Library/Application Support/BraveSoftware/Brave-Browser/Default/rewards_service/confirmations.json [781:775:0427/132941.580832:ERROR:confirmations_impl.cc(770)] Failed to load confirmations state, resetting to default values [771:26883:0427/132941.997449:ERROR:rewards_service_impl.cc(192)] Failed to read file: /Users/ric/Library/Application Support/BraveSoftware/Brave-Browser/Default/ledger_state [781:775:0427/132941.997833:ERROR:ledger_impl.cc(113)] Failed to initialize wallet [771:775:0427/132953.873775:ERROR:CONSOLE(0)] "Unchecked runtime.lastError: Cannot access contents of url "chrome://newtab/". Extension manifest must request permission to access this host.", source: chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/_generated_background_page.html (0) [0427/132956.629002:WARNING:process_memory_mac.cc(93)] mach_vm_read(0x7ffee7e27000, 0x2000): (os/kern) invalid address (1) [0427/132956.789760:WARNING:system_snapshot_mac.cc(42)] sysctlbyname kern.nx: No such file or directory (2) [0427/132957.004757:WARNING:crash_report_exception_handler.cc(239)] UniversalExceptionRaise: (os/kern) failure (5) [813:775:0427/132957.038559:ERROR:child_thread_impl.cc(222)] Invalid PlatformChannel receive right [1] 771 illegal hardware instruction "/Applications/Brave Browser.app/Contents/MacOS/Brave Browser"

EDIT: also tried the suggested flags, to no avail.

onmyouji commented 4 years ago

Same here on Windows 10, it still freezes.

brave.exe_200427_193816.zip

Xyncgas commented 4 years ago

YES

Xyncgas commented 4 years ago

how did the update get to stable by the way

bsclifton commented 4 years ago

@riccardoangius for your issue, when was the last time Brave worked for you? Do you know the version you had?

Looking at the call stack, it's a bit hard to tell. But I am seeing some USB/bluetooth keyboard problems. Can you please try turning off your bluetooth keyboard and then launching Brave (mouse-only).

The errors I'm seeing are saying you're missing the entitlement (Catalina thing) for this keyboard to allow bluetooth control. This might be something that needs to be added in System Preferences

bsclifton commented 4 years ago

how did the update get to stable by the way

This never came up in any of our testing - even now, there are crash reports... but there aren't many clues. Without a solid way to reproduce, it's very difficult to find the root cause โ˜น๏ธ

@Xyncgas did the release candidate work for you?

riccardoangius commented 4 years ago

@bsclifton thank you.

I have no BT keyboard, so I looked around a bit and stumbled upon this.

Looked around and indeed I hadn't enabled Accessibility Keyboard (as in the linked thread) but Typing feedback was on and turning it off solved it all for me.

I was checking the UX for an accessible app I was developing and completely forgot about it ๐Ÿคฆ๐Ÿปโ€โ™‚๏ธ

bsclifton commented 4 years ago

@riccardoangius this is great! Thanks for finding ๐Ÿ˜„ I believe we captured the above issue (accessibility keyboard) with https://github.com/brave/brave-browser/issues/7546 but haven't solved it yet

macOS users please do try turning this off, if that is an option for you. For those who need it, a fix should be coming in Chromium 83 which we're working through now (Chromium 82 was skipped by Chrome team). Expected to be released May 19th

onmyouji commented 4 years ago

Btw, is there any way to block/disable Brave automatic update?

I tested downgrading to Release Channel v1.7.92 and everything is working fine. But when I went to Help-About and try to update again, the same issue happened.

bsclifton commented 4 years ago

@onmyouji yes - I believe as a manual work-around you can install 1.7.92 and then find the BraveUpdate.exe. I believe this is in c:\Program Files (x86)\BraveSoftware\Brave-Browser. Use task manager to kill this process (I think you can also right click process and find it in task manager) and then you can rename this as BraveUpdate.exe.old or similar. It shouldn't re-launch

Having it work with 1.7.92 seems like it's a problem with the Chromium 81 upgrade we did. Thanks for helping us troubleshoot this ๐Ÿ˜„

GitOutWest commented 4 years ago

Iโ€™ll also mention that [Google] Chrome doesnโ€™t have this problem. So I don't think it's Chromium 81.x all by itself. Chrome: 81.0.4044.113 (Official Build) (64-bit), and now 81.0.4044.122 (Official Build) (64-bit).

Xyncgas commented 4 years ago

Although not crashing it freezes during start up for a few seconds

intelligentpotato commented 4 years ago

Just checked out the RC2, the issue is still there.

euclaise commented 4 years ago

From #9162

Thanks for confirming @the-sushi. Do you have to force kill Brave? or does it eventually crash?

I have to force kill it, else it just hangs.

bsclifton commented 4 years ago

@intelligentpotato what OS are you on?

As a troubleshooting step, for the more tech savvy folks - you can help us determine if the hanging is a profile-specific problem:

Quit all instances of Brave and then rename the folder. You can relaunch and you'll have a brand new profile. I'm curious if the problem still happens then (try visiting a few websites). If not, we know the bug is related to something about the user profile

After testing, you can go back to the folder you renamed, remove the new one which got created, and rename the folder back to the old name.

If you're not sure what I'm talking about in this post, please don't attempt the above steps ๐Ÿ˜„

GitOutWest commented 4 years ago

I think several people, including myself, have demonstrated that there's a profile-related issue in play. I had previously tried switching profiles by creating a new one, quitting Brave, then launching into the new one -- no hang.

I just tried your method, renaming the C:\Users\MyUserID\AppData\Local\BraveSoftware\Brave-Browser\User Data directory and then launching Brave into a new profile. Again, no hang. Previously under my default profile I had manually disabled all extensions (others also used --disable-extensions) but still got the (3-min) hang on launch.

Using your rename\UD method, I just tried with two extension (Acrobat & a password manager), and then quickly tried changing a few settings to set up Brave the way I like it (Download folder, home page, DNT enabled, turn off Brave Rewards button, etc.). After quitting & relaunching Brave, I never got a hang.

Whatever's going on, it doesn't seem to be a corrupted profile but rather something about a specific profile setting (lack of Brave Rewards, no Crypto Wallet, non-use of Tor, etc.).

talisto commented 4 years ago

On MacOS 10.14.6, I updated to the Brave 1.8.84 RC but was still getting the lag on startup. However, I went into Settings > Additional Settings > Reset Settings > "Restore settings to their original defaults", which seems to have resolved it for me. So it's definitely profile-related. Using that reset method is much less destructive than torching the whole profile (it keeps bookmarks, history, extension settings, etc), so that's nice!

bsclifton commented 4 years ago

@GitOutWest thanks for taking the time to test that ๐Ÿ˜„ It's definitely appreciated as there are a few different types of issues happening to folks. Can you try the latest 1.8 release candidate? This is very likely what we're going to release soon: https://github.com/brave/brave-browser/releases/tag/v1.8.86

This 1.8 release does specifically fix a bug where the Brave Rewards publishers list was being downloaded/installed even if you have rewards disabled. It also includes some optimizations for when rewards IS enabled and that list is downloaded. Basically, when that list is downloaded, a bunch of records are dropped and inserted in SQLite, which I believe is the freeze that a number of folks are reporting

There's definitely also a hardware related issue- where disabling HW acceleration solves some users. This might be something we see but Chrome doesn't see because Chrome is fetching the field trial values from finch server. We set the flag values at build time and don't reach out- so there's a potential that we have different driver workarounds / exclusion lists than Chrome

All of that said, there are still another two unknown issues: both freezing and crashing is happening to users who have never enabled Rewards... some on a brand new profile. I have several crash dumps and unfortunately, there isn't enough information to narrow the problem down. Having more crash reports and knowing more about the environment (which OS, does it work in Chrome, comparing brave://gpu to chrome://gpu, etc) will help

Some macOS users were resolved by disabling the virtual keyboard ๐Ÿ˜„ Bigtime thanks to @riccardoangius for confirming that works

@talisto let us know how that works! If doing the profile reset does fix you, then you've helped narrow down the problem for a lot of folks ๐Ÿ˜„ Thanks for trying and sharing that troubleshooting step

GitOutWest commented 4 years ago

@bsclifton Sorry, I'm going to need a tiny bit of help with that.

When I go to https://github.com/brave/brave-browser/releases/tag/v1.8.86, download the BraveBrowserSetup.exe or BraveBrowserSetup32.exe file (named on my PC BraveBrowserSetup_v1.8.86_RC3.exe, or BraveBrowserSetup32_v1.8.86_RC3.exe to make sure I keep things straight) and run either one, it does an install. But when I launch Brave from my start menu ("C:\Program Files (x86)\BraveSoftware\Brave-Browser\Application\brave.exe") I'm still seeing Version 1.7.98 Chromium: 81.0.4044.113 (Official Build) (64-bit) in the help, and brave.exe dated 4/19. That's after the 3-min wait until I can do anything.

Is there a different installer I'm supposed to be using from within /v1.8.86? I'm not seeing evidence of another copy of Brave being installed somewhere else (e.g. "C:\Program Files\ or another C:\Program Files (x86)\BraveSoftware tree).

onmyouji commented 4 years ago

@bsclifton Sorry, I'm going to need a tiny bit of help with that.

When I go to https://github.com/brave/brave-browser/releases/tag/v1.8.86, download the BraveBrowserSetup.exe or BraveBrowserSetup32.exe file (named on my PC BraveBrowserSetup_v1.8.86_RC3.exe, or BraveBrowserSetup32_v1.8.86_RC3.exe to make sure I keep things straight) and run either one, it does an install. But when I launch Brave from my start menu ("C:\Program Files (x86)\BraveSoftware\Brave-Browser\Application\brave.exe") I'm still seeing Version 1.7.98 Chromium: 81.0.4044.113 (Official Build) (64-bit) in the help, and brave.exe dated 4/19. That's after the 3-min wait until I can do anything.

Is there a different installer I'm supposed to be using from within /v1.8.86? I'm not seeing evidence of another copy of Brave being installed somewhere else (e.g. "C:\Program Files\ or another C:\Program Files (x86)\BraveSoftware tree).

You should download BraveBrowserStandaloneSetup.exe, that's the right one.

bsclifton commented 4 years ago

@bsclifton Sorry, I'm going to need a tiny bit of help with that. When I go to https://github.com/brave/brave-browser/releases/tag/v1.8.86, download the BraveBrowserSetup.exe or BraveBrowserSetup32.exe file (named on my PC BraveBrowserSetup_v1.8.86_RC3.exe, or BraveBrowserSetup32_v1.8.86_RC3.exe to make sure I keep things straight) and run either one, it does an install. But when I launch Brave from my start menu ("C:\Program Files (x86)\BraveSoftware\Brave-Browser\Application\brave.exe") I'm still seeing Version 1.7.98 Chromium: 81.0.4044.113 (Official Build) (64-bit) in the help, and brave.exe dated 4/19. That's after the 3-min wait until I can do anything. Is there a different installer I'm supposed to be using from within /v1.8.86? I'm not seeing evidence of another copy of Brave being installed somewhere else (e.g. "C:\Program Files\ or another C:\Program Files (x86)\BraveSoftware tree).

You should download BraveBrowserStandaloneSetup.exe, that's the right one.

This is the right one to download for Windows ๐Ÿ˜„

GitOutWest commented 4 years ago

OK, thanks. That's better. Now showing "Version 1.8.86 Chromium: 81.0.4044.129 (Official Build) (64-bit)" for Brave after I launch it. Unfortunately still with the 3-minute hang :-(

As a side note, before the upgrade (so I was still using 1.7.98 Chromium: 81.0.4044.113 (Official Build) (64-bit) at that time), I ran, one at a time, with each of these directives set in the start menu launch shortcut. And saw no extensions for the appropriate one, so I was doing it right. Still a 3-min freeze before Brave give me control after launch.

"C:\Program Files (x86)\BraveSoftware\Brave-Browser\Application\brave.exe" --disable-brave-sync (to ensure itโ€™s not related to Brave sync) --disable-extensions (to ensure itโ€™s not from an extension) --disable-gpu (in case driver is having a problem)

bsclifton commented 4 years ago

@GitOutWest the command should look like this:

"C:\Program Files (x86)\BraveSoftware\Brave-Browser\Application\brave.exe" --disable-brave-sync --disable-extensions --disable-gpu

Also curious- do you have Rewards enabled?

onmyouji commented 4 years ago

Just tried v1.8.86 RC3, it still freezes on launch. No problem if using brand new profile, it only freezes when I'm using my old profile.

brave.exe_200429_121845.dmp.zip

GitOutWest commented 4 years ago

That's what it did look like. I was just trying to save space, but I guess that backfired...

And no, I don't have Rewards enabled.

I tried each of those one at time, with my 3-min freeze of Brave each time on launch. As I noted, I saw the missing extensions (e.g. no icons in Brave) in the case of the "--disable-extensions" option. So I'll assume that the other two did their thing also.

"C:\Program Files (x86)\BraveSoftware\Brave-Browser\Application\brave.exe" --disable-brave-sync

"C:\Program Files (x86)\BraveSoftware\Brave-Browser\Application\brave.exe" --disable-extensions

"C:\Program Files (x86)\BraveSoftware\Brave-Browser\Application\brave.exe" --disable-gpu

@GitOutWest the command should look like this:

"C:\Program Files (x86)\BraveSoftware\Brave-Browser\Application\brave.exe" --disable-brave-sync --disable-extensions --disable-gpu

Also curious- do you have Rewards enabled?

GitOutWest commented 4 years ago

With the same log output (v1.8.86 RC3 or 1.7.98), if run from a CLI or if added to the Start shortcut and dumped into the chrome_debug.log.

[C:\Program Files (x86)\BraveSoftware\Brave-Browser\Application]brave.exe --args --log-level=2 --enable-logging=stderr

[C:\Program Files (x86)\BraveSoftware\Brave-Browser\Application][19948:4848:0428/224945.376:ERROR:browser_switcher_service.cc(238)] XXX Init() [28532:28680:0428/224945.389:INFO:confirmations_impl.cc(53)] Initializing confirmations [28532:28680:0428/224945.390:INFO:confirmations_impl.cc(756)] Loading confirmations state [28532:28680:0428/224946.698:INFO:confirmations_impl.cc(775)] Successfully loaded confirmations state [28532:28680:0428/224946.699:INFO:confirmations_impl.cc(736)] Saving confirmations state [28532:28680:0428/224946.699:INFO:confirmations_impl.cc(736)] Saving confirmations state [28532:28680:0428/224946.699:INFO:confirmations_impl.cc(736)] Saving confirmations state [28532:28680:0428/224946.720:INFO:confirmations_impl.cc(752)] Successfully saved confirmations state [28532:28680:0428/224946.726:INFO:confirmations_impl.cc(752)] Successfully saved confirmations state [28532:28680:0428/224946.731:INFO:confirmations_impl.cc(752)] Successfully saved confirmations state [19948:25144:0428/224946.745:ERROR:rewards_service_impl.cc(192)] Failed to read file:

After 3-min freeze on launch, I can then use Brave. A few more outputs after that below:

[19948:4848:0428/225334.713:ERROR:CONSOLE(1)] "[Shields]: Can't request shields panel data. Error: No tab url specified", source: chrome-extension://mnojpmjdmbbfmejpflffifhffcmidif d/out/brave_extension_background.bundle.js (1) [19948:4848:0428/225334.713:ERROR:CONSOLE(1)] "[Shields]: Can't request shields panel data. Error: No tab url specified", source: chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/out/brave_extension_background.bundle.js (1) [19948:4848:0428/225425.731:ERROR:CONSOLE(1)] "[Shields]: Can't request shields panel data. Error: No tab url specified", source: chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/out/brave_extension_background.bundle.js (1) [19948:4848:0428/225425.731:ERROR:CONSOLE(1)] "[Shields]: Can't request shields panel data. Error: No tab url specified", source: chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/out/brave_extension_background.bundle.js (1) [19948:4848:0428/225431.586:ERROR:CONSOLE(1)] "[Shields]: Can't request shields panel data. Error: No tab url specified", source: chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/out/brave_extension_background.bundle.js (1) [19948:4848:0428/225431.586:ERROR:CONSOLE(1)] "[Shields]: Can't request shields panel data. Error: No tab url specified", source: chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/out/brave_extension_background.bundle.js (1)

bsclifton commented 4 years ago

Thanks for the above @GitOutWest - going to share with some folks. The confirmations state logs are suspicious, especially with rewards off

cc: @tmancey

bsclifton commented 4 years ago

@onmyouji can you also try launching via command line with similar args to @GitOutWest to see if you are getting log output mentioning confirmations?

Basically:

cd "C:\Program Files (x86)\BraveSoftware\Brave-Browser\Application"
brave.exe --args --log-level=2 --enable-logging=stderr
onmyouji commented 4 years ago

Yes, I'm also getting confirmation states. I can email you the full logs if you need it. Not sure if it's safe sharing it here because I saw there's payment id there.

Image 1

bsclifton commented 4 years ago

@onmyouji no need to share - this is great information ๐Ÿ˜„ I've shared with fellow devs - this is helping narrow down the problem quite a bit

@onmyouji @GitOutWest there is something you both can try...

  1. Open the folder %userprofile%\AppData\Local\BraveSoftware\
  2. Make a copy of the Brave-Browser folder and name the copy Brave-Browser-Nightly
  3. Install and try our Nightly channel at https://brave.com/download-nightly/

Once downloaded installed (it's safe to use both stable Brave and Nightly ๐Ÿ˜„) you can launch Nightly and it will load the copied profile. There are at least 2 fixes for related issues - I'm curious if these will help

Thanks again for being available to help test and share the result - your help is super appreciated ๐Ÿ˜„

tmancey commented 4 years ago

@onmyouji I am more than happy to jump on a screen share to diagnose the issue, please let me know if this works for you and we can arrange a time, thanks

onmyouji commented 4 years ago

@tmancey Thanks, but I prefer to do it through here or the community forum. I'm currently doing something else, don't want to have to be on screen the entire time.

Should probably check with @GitOutWest if it's okay for him/her.

@bsclifton The Nightly still has the same issue.

Image 2

tmancey commented 4 years ago

@onmyouji Sure thanks. I understand you will want to remove your payment id from the log however are there any other lines in the log below what is on the above screenshot as this may help us identify the issue. Thanks

GitOutWest commented 4 years ago

Copied Brave-Browser folder => Brave-Browser-Nightly Installed and running Purple-Brave. Still see my 3-min freeze on launch.

[C:\Program Files (x86)\BraveSoftware\Brave-Browser-Nightly\Application]brave.exe --args --log-level=2 --enable-logging=stderr

[C:\Program Files (x86)\BraveSoftware\Brave-Browser-Nightly\Application][6704:29500:0429/075142.916:ERROR:browser_switcher_service.cc(238)] XXX Init() [10780:15004:0429/075142.933:INFO:confirmations_impl.cc(57)] Initializing confirmations [10780:15004:0429/075142.933:INFO:confirmations_impl.cc(760)] Loading confirmations state [10780:15004:0429/075144.337:INFO:confirmations_impl.cc(779)] Successfully loaded confirmations state [10780:15004:0429/075144.337:INFO:confirmations_impl.cc(740)] Saving confirmations state [10780:15004:0429/075144.338:INFO:confirmations_impl.cc(740)] Saving confirmations state [10780:15004:0429/075144.338:INFO:confirmations_impl.cc(740)] Saving confirmations state [10780:15004:0429/075144.366:INFO:confirmations_impl.cc(756)] Successfully saved confirmations state [10780:15004:0429/075144.374:INFO:confirmations_impl.cc(756)] Successfully saved confirmations state [10780:15004:0429/075144.381:INFO:confirmations_impl.cc(756)] Successfully saved confirmations state [6704:5400:0429/075144.389:ERROR:rewards_service_impl.cc(187)] Failed to read file: C:\Users\andrew\AppData\Local\BraveSoftware\Brave-Browser-Nightly\User Data\Default\ledger_state [10780:15004:0429/075144.400:ERROR:ledger_impl.cc(113)] Failed to initialize wallet TCC: (Sys) Access is denied. "\.\pipe\chrome.nativeMessaging.out.6d0b69e0a095fc54" [6704:29500:0429/075600.370:ERROR:CONSOLE(4)] "Polymer is already defined.", source: chrome://settings/crisper.js (4)

Note: TCC = Take Command Console window. Program launches from that console window via CLI, but doesn't launch from a normal Windows CMD or Windows PowerShell window (normal or admin).

Version 1.10.19 Chromium: 81.0.4044.129 (Official Build) nightly (64-bit)

bruce30262 commented 4 years ago

Hey guys, would like to post about my case, hope it'll help identifying the issue.

ENV

Detail

I installed the brave browser with "BraveBrowserStandaloneSetup.exe" ( v1.8.86 )

Then I launched the browser with 

brave.exe --args --log-level=2 --enable-logging=stderr

Here's the ouput:

PS C:\Program Files (x86)\BraveSoftware\Brave-Browser\Application> [20928:19828:0430/012932.226:ERROR:browser_switcher_service.cc(238)] XXX Init()
[1544:21496:0430/012932.262:INFO:confirmations_impl.cc(53)] Initializing confirmations
[1544:21496:0430/012932.262:INFO:confirmations_impl.cc(756)] Loading confirmations state
[1544:21496:0430/012932.626:INFO:confirmations_impl.cc(775)] Successfully loaded confirmations state
[1544:21496:0430/012932.627:INFO:confirmations_impl.cc(736)] Saving confirmations state
[1544:21496:0430/012932.629:INFO:confirmations_impl.cc(736)] Saving confirmations state
[1544:21496:0430/012932.629:INFO:confirmations_impl.cc(736)] Saving confirmations state
[1544:21496:0430/012932.658:INFO:confirmations_impl.cc(752)] Successfully saved confirmations state
[1544:21496:0430/012932.700:INFO:confirmations_impl.cc(752)] Successfully saved confirmations state
[1544:21496:0430/012932.708:INFO:confirmations_impl.cc(752)] Successfully saved confirmations state
[20928:10948:0430/012932.712:ERROR:rewards_service_impl.cc(192)] Failed to read file: C:\Users\Bruce Chen\AppData\Local\BraveSoftware\Brave-Browser\User Data\Default\ledger_state
[1544:21496:0430/012932.716:ERROR:ledger_impl.cc(113)] Failed to initialize wallet
[20928:19828:0430/012944.386:ERROR:os_crypt_win.cc(92)] Failed to decrypt: ๅƒๆ•ธ้Œฏ่ชคใ€‚ (0x57)
[20928:19828:0430/012944.386:ERROR:binance_service.cc(305)] Could not decrypt and save Binance token info.
[20928:19828:0430/012946.408:ERROR:device_event_log_impl.cc(162)] [01:29:46.407] Bluetooth: bluetooth_adapter_winrt.cc:1055 Getting Default Adapter failed.
[20928:19828:0430/012958.725:ERROR:CONSOLE(1)] "[object Object]", source: chrome-extension://odbfpeeihdkbihmopkbjmoonfanlbfcl/background.js (1)
[20928:19828:0430/012959.685:ERROR:CONSOLE(1)] "[object Object]", source: chrome-extension://odbfpeeihdkbihmopkbjmoonfanlbfcl/background.js (1)

"ๅƒๆ•ธ้Œฏ่ชค" can be translated to "Wrong parameters/arguments"

The browser didn't crash though, however for the first few seconds it hangs and the task manager shows that the CPU usage was pretty high. After about 15 seconds everything went back to normal, the browser start working again.

Hope this help !

GitOutWest commented 4 years ago

I've never had Brave crash, just hang for a while on launch **.

On my home system (high end mobo & CPU, very good graphics card, 32G DDR4, DisplayPort monitor, etc.) with v1.8.86 RC3 or 1.7.98, the hang lasts for about 3-min while using 10% of my CPU.

On my work laptop (older slower model, 16G DDRx, not fancy graphics but using DP) running 1.7.98, the hang lasts about 50-sec while using > 40% of the CPU. So speed (CPU & GPU) doesn't seem to be the deciding factor.

* a couple of times during the hang I've managed to drop the hamburger and launch the Brave Task Manager by "feel" -- all I see is menu outlines for the burger menu then More Tools menu, so I kind of guessed where I needed to hover to launch the TM. I got lucky a couple times, but the TM was just a white window that didn't show me anything. When Brave started responding and filled in the TM window, I briefly saw "Browser" sucking a high amount before falling to just a few % (normal). So it didn't look* like it was the GPU Process or an extension.

onmyouji commented 4 years ago

@tmancey Here's the complete log

chrome_debug.log

Brave: 1.10.19 Chromium: 81.0.4044.129ย (Official Build)ย nightlyย (64-bit) Revision: 3d71af9f5704a40b85806f4d08925db24605ba25-refs/branch-heads/4044@{#979} OS: Windowsย 10 OS Version 1809 (Build 17763.1158)

euclaise commented 4 years ago

on macOS, rename the folder ~/Library/Application Settings/BraveSoftware/ out of the way. You can rename to just add .old at the end

@bsclifton It's Application Support, not Application Settings, but yes this fixes the hanging, so it does appear to be profile-related.

lgeorge commented 4 years ago

Running OS X 10.14.6 (18G4032) on MBP with Brave 1.7.98 Chromium: 81.0.4044.113. Brave has been taking about 20 seconds to become responsive after launch. I tried 1.8.84 & still saw a lag. Hadn't tried the CL options yet, but just now restored settings to their defaults per the post from @talisto and it worked. What a relief! Amazing how much difference 20 seconds is when we're used to instant :)

bruce30262 commented 4 years ago

"Reset Settings" indeed fix the hanging problem, no more high CPU usage while launching the browser ! All I can tell the difference between before/after reset the settings is that the cookies are gone, and the browser extensions are all disabled ( re-enabling those extensions did not hang the browser, everything seems to be fine ). The other settings seems to remain unchanged.

So the problem might have something to do with the cookies ? I've been using Brave for quite a while ( almost 2 years I guess ) and haven't clear those cookies since the beginning. Maybe it has something to do with those large amount of cookies ๐Ÿช

onmyouji commented 4 years ago

Yup, can confirm that "Reset settings" fixed the problem. And as @talisto mentioned, you still keep things like bookmarks, history, extension settings, etc. Thanks for sharing.

fancycookin commented 4 years ago

Reset Settings also worked for me. Browser no longer freezes on launch.

Version 1.8.86 Chromium: 81.0.4044.129 (Official Build) (64-bit) OS: Windows 10 Pro Version 1909 (OS build: 18363.815)

Scott-5Litre commented 4 years ago

I too can confirm that "Reset Settings" indeed fixed the hanging problem. Just reset minutes ago and all is back to normal. TY Tech's ^5

GitOutWest commented 4 years ago

"Reset Settings" also worked for me. Brave now launches very quickly on my "3-min to unfreeze after launch" system. I did have to re-set a few settings per my prefs, enable some extensions, and log back into a bunch of site. I also upgraded my 2nd system (Brave 1.7.98 => 1.8.86), still seeing a 50-sec hang, so I then did the "Reset Settings" and manual re-sets. That system is now OK also.

I don't regard the "Reset Settings" as a real "fix" since it doesn't address the underlying cause that caused Brave to start freezing after a normal upgrade -- "Problems that mysteriously go away mysteriously come back..." Hopefully all the info and logs we've been providing have given the Brave developers some idea of the root cause.

Brave Version 1.8.86 Chromium: 81.0.4044.129 (Official Build) (64-bit)

bsclifton commented 4 years ago

Hopefully all the info and logs we've been providing have given the Brave developers some idea of the root cause.

This is DEFINITELY true - we've identified a few key things and are working on fixes. Thanks everybody for your patience. We don't have a "smoking gun" per-se, but a lot of great things were identified. This wouldn't have been possible without all the good troubleshooting steps shared here by you all ๐Ÿ˜„

Xyncgas commented 4 years ago

it's freezing now whenever opening a tab, instead of opening the browser, can someone shares how to disable updates in brave? I can update it when the bug is fix. ty.

Xyncgas commented 4 years ago

I love brave. But the browser is acting up. And I gotta work but not wanting to use chrome but I really wanna control when I can update it or it would just be like those companies that forces every changes and techs that they see should apply to people. it would be no different than the DRM which is your enemy, it would be no different than microsoft forcing update and changing the things in your computer even when it's a bug.

Xyncgas commented 4 years ago

I mean I can complain doing it for the people that are not, kinda kidding, I really mean like one of the biggest appeal of the brave browser is to saving time from all those ads right. every ads the browser is blocking and ad block is blocking you see where I am going, it's usually milliseconds right. This laggin like serveral seconds when opening a new tab it's like you hate to see things you enjoy just turning into ( actually never mind I think since I enjoy it I should be patient too ) BTW can you just roll back the public version to before the bug happens already and release the fixed update later.