simonhong
commented
4 years ago Got strange error while generating delta installer.
Previous version's chrome.7z extracting is failed. but extracted properly when I do it in console.
Curious why it think as an overwrite??? - Before running GetPrevVersion, this script delete previous temp dir. So, it should not be an overwrite when extracting.
=> Found the reason
when below temp_dir is passed with -o'"temp_dir"', temp_dir is generated under C:/.
However, temp_dir is generated in cwd when it's passed with -o'temp_dir'.
Because of this, it warns about overwriting. Normally, that temp_dir becomes empty because MakeStagingDirectory deletes it before extracting it into temp_diir.
cmd = [lzma_exec,
'x',
'-o%s' % temp_dir,
prev_archive_file,
'Chrome-bin/*/chrome.dll',][1/279] ACTION //components/resources:about_credits(//build/toolchain/win:win_clang_x64)
[2/9] ACTION //chrome/installer/mini_installer:mini_installer_archive(//build/toolchain/win:win_clang_x64)
FAILED: chrome.7z setup.ex_ gen/chrome/installer/mini_installer/mini_installer/packed_files.rc chrome.packed.7z
C:/Projects/brave/brave-browser/vendor/depot_tools/bootstrap-3_8_0_chromium_8_bin/python/bin/python.exe ../../chrome/tools/build/win/create_installer_archive.py --build_dir . --staging_dir gen/chrome/installer/mini_installer/mini_installer --input_file ../../chrome/installer/mini_installer/chrome.release --resource_file_path gen/chrome/installer/mini_installer/mini_installer/packed_files.rc --target_arch=x64 --distribution=_brave --output_dir . --chrome_runtime_deps gen/chrome_component.runtime_deps --setup_runtime_deps gen/setup.runtime_deps --last_chrome_installer=C:/build/installer --setup_exe_format=DIFF --diff_algorithm=COURGETTE --verbose --skip_signing --enable_hidpi=1 --depfile gen/chrome/installer/mini_installer/archive.d
['../../chrome/tools/build/win/create_installer_archive.py', '--build_dir', '.', '--staging_dir', 'gen/chrome/installer/mini_installer/mini_installer', '--input_file', '../../chrome/installer/mini_installer/chrome.release', '--resource_file_path', 'gen/chrome/installer/mini_installer/mini_installer/packed_files.rc', '--target_arch=x64', '--distribution=_brave', '--output_dir', '.', '--chrome_runtime_deps', 'gen/chrome_component.runtime_deps', '--setup_runtime_deps', 'gen/setup.runtime_deps', '--last_chrome_installer=C:/build/installer', '--setup_exe_format=DIFF', '--diff_algorithm=COURGETTE', '--verbose', '--skip_signing', '--enable_hidpi=1', '--depfile', 'gen/chrome/installer/mini_installer/archive.d']
C:/build/installer\chrome.7z
gen/chrome/installer/mini_installer/mini_installer\temp_installer_archive
Running .\..\..\third_party\lzma_sdk\Executable\7za.exe x -o"gen/chrome/installer/mini_installer/mini_installer\temp_installer_archive" C:/build/installer\chrome.7z Chrome-bin\*\chrome.dll
Traceback (most recent call last):
File "../../chrome/tools/build/win/create_installer_archive.py", line 665, in <module>
sys.exit(main(options))
File "../../chrome/tools/build/win/create_installer_archive.py", line 538, in main
options.output_name)
File "../../chrome/tools/build/win/create_installer_archive.py", line 188, in GetPrevVersion
RunSystemCommand(cmd, options.verbose)
File "../../chrome/tools/build/win/create_installer_archive.py", line 232, in RunSystemCommand
(e.cmd, e.returncode, e.output))
Exception: Error while running cmd: ['.\\..\\..\\third_party\\lzma_sdk\\Executable\\7za.exe', 'x', '-o"gen/chrome/installer/mini_installer/mini_installer\\temp_installer_archive"', 'C:/build/installer\\chrome.7z', 'Chrome-bin\\*\\chrome.dll']
Exit code: 2
Command output:
7-Zip (a) [64] 15.14 : Copyright (c) 1999-2015 Igor Pavlov : 2015-12-31
Scanning the drive for archives:
1 file, 220406223 bytes (211 MiB)
Extracting archive: C:\build\installer\chrome.7z
--
Path = C:\build\installer\chrome.7z
Type = 7z
Physical Size = 220406223
Headers Size = 2965
Method = Copy
Solid = -
Blocks = 187
Would you like to replace the existing file:
Path: \gen/chrome/installer/mini_installer/mini_installer\temp_installer_archive\Chrome-bin\81.1.8.90\chrome.dll
Size: 134749328 bytes (129 MiB)
Modified: 2020-05-05 11:27:19
with the file from archive:
Path: Chrome-bin\81.1.8.90\chrome.dll
Size: 134749328 bytes (129 MiB)
Modified: 2020-05-05 11:27:19
? (Y)es / (N)o / (A)lways / (S)kip all / A(u)to rename all / (Q)uit?
ERROR: Can't allocate required memory!
Archives with Errors: 1
ninja: build stopped: subcommand failed.
null
null
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! brave@1.10.23 create_dist: `node ./scripts/commands.js create_dist "Release" "--skip_signing"`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the brave@1.10.23 create_dist script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR! C:\Users\simon\AppData\Roaming\npm-cache\_logs\2020-05-07T02_20_15_743Z-debug.log
mihaiplesa
GeetaSarvadnya
create_distcommand for generating delta installerLet's start investigation about delta update with below archive type. Maybe
INCREMENTAL_ARCHIVE_TYPEis used for delta installer.Currently,
mini_installertarget usescourgettealgorithm for generating delta installer. Courgette: https://www.chromium.org/developers/design-documents/software-updates-courgetteAccording to the below code in
chrome/installer/setup/setup_main.cc, maybe setup.exe generates output file(newer version file) by using patch file(new delta file?) and input file(current version). and output file would be a complete file for update to next version.create_installer_archive.pygenerates patch file bymini_installertarget. Uncompressedchrome.7zfile is used to get diff.