brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.66k stars 2.3k forks source link

[Desktop] Link to Web Store isn't properly colored in the extensions menu in dark mode #9702

Open wackbyte opened 4 years ago

wackbyte commented 4 years ago

Description

The link to the Chrome Web Store in the extensions menu (brave://extensions) isn't properly colored in dark mode.

Steps to Reproduce

  1. Enable dark mode.
  2. Go to brave://extensions.
  3. Look at the bottom of the page.

Actual result:

image

Expected result:

The "Web Store" link should be a lighter shade of blue.

Reproduces how often:

Always.

Brave version (brave://version info)

Brave | 1.8.95 Chromium: 81.0.4044.138 (Official Build) unknown (64-bit)
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | Linux

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

rebron commented 4 years ago

@0xedward Is this something you can help with? Want to give this one a try?

0xedward commented 4 years ago

@rebron sure, I'll give it a go!

0xedward commented 4 years ago

I noticed the issue is not reproducible on the latest stable version (1.9.80) on Linux, Windows and MacOS in dark mode when there are no extensions installed, but reproduces once there is at least 1 extension installed.

No extensions installed:

image

image

image

With number of extensions installed >= 1:

image image

0xedward commented 4 years ago

@rebron @karenkliu Under the following conditions:

Do we want to change the color from rgb(0, 0, 238) to rgb(255, 69, 48) or do we want to make rgb(0, 0, 238) lighter?

karenkliu commented 4 years ago

@0xedward Change it to #FF7654