brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.58k stars 2.28k forks source link

CryptoWallet signing typed data UI is blocked #9775

Closed nicholasmueller closed 4 years ago

nicholasmueller commented 4 years ago

Description

The signing modal using the built in crypto wallet does not allow scrolling down when the typed data message is larger than the modal height.

Steps to Reproduce

  1. try to sign a typeddata transaction

Actual result:

81643786-8a7d8d80-9450-11ea-8fcf-feb3963ca451

See the orange arrow, you are unable to scroll down to confirm the signature.

Expected result:

Be able to scroll down and see all the typeddata and click confirm. Same like metamask.

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Version 1.8.96 Chromium: 81.0.4044.138 (Official Build) (64-bit)

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

srirambv commented 4 years ago

Fixed by https://github.com/brave/ethereum-remote-client/pull/147

srirambv commented 4 years ago

Verification passed on

Brave 1.12.86 Chromium: 84.0.4147.85 (Official Build) beta (64-bit)
Revision e20c13e958edc3707db3d26d513780a7f6331a4b-refs/branch-heads/4147@{# 837}
OS Linux
Component 0.1.56
Ethjs Personal Sign Sign Typed Data Sign Typed Data V3 Sign Typed Data V4
image image image image

Verification passed on

Brave 1.11.97 Chromium: 84.0.4147.89 (Official Build) (64-bit)
Revision 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{# 852}
OS Windows 10 OS Version 1809 (Build 17763.1339)
Component 0.1.56
Ethjs Personal Sign Sign Typed Data Sign Typed Data V3 Sign Typed Data V4
Screenshot 2020-07-16 at 12 55 56 p m Screenshot 2020-07-16 at 12 53 16 p m Screenshot 2020-07-16 at 12 53 55 p m Screenshot 2020-07-16 at 12 55 13 p m

Verification passed on

Brave 1.13.16 Chromium: 84.0.4147.89 (Official Build) nightly (64-bit)
Revision 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{# 852}
OS macOS Version 10.15.5 (Build 19F101)
Component 0.1.56
Ethjs Personal Sign Sign Typed Data Sign Typed Data V3 Sign Typed Data V4
Screenshot 2020-07-16 at 1 01 36 p m Screenshot 2020-07-16 at 1 01 48 p m Screenshot 2020-07-16 at 1 02 00 p m Screenshot 2020-07-16 at 1 02 11 p m