search

brave / brave-core-crx-packager

Mozilla Public License 2.0
41 stars 35 forks source link

Deprecated modules #380

Open diracdeltas opened 2 years ago

diracdeltas commented 2 years ago

npm install shows various deprecated modules; we should try to update them

fmarier commented 2 years ago

@diracdeltas What do you run to see the deprecated modules?

This is what I see with npm 8.11.0: `` $ npm install

brave-core-crx-packager@1.0.0 preinstall npx npm-force-resolutions

added 12 packages, removed 1 package, changed 1 package, and audited 832 packages in 10s

102 packages are looking for funding run npm fund for details

found 0 vulnerabilities

fmarier commented 2 years ago

To see the warnings, delete your node_modules directory first:

$ rm -rf node_modules/
$ npm install
...
npm WARN deprecated har-validator@5.1.5: this library is no longer supported
npm WARN deprecated querystring@0.2.0: The querystring API is considered Legacy. new code should use the URLSearchParams API instead.
npm WARN deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142
diracdeltas commented 2 years ago

@fmarier that works,npm outdated will also show at least outdated packages. nowadays socket security will also report unmaintained packages on new PRs

antonok-edm commented 2 years ago

Noting that request in particular is not able to fetch https://adblock.ee/list.php (from the Eesti saitidele kohandatud filter regional list). The builtin fetch API seems to be okay though, I'll try to migrate things towards that.